[gtaplayer1]

Hello,

I have played with scripting a gamemode in pawn before, but I am new to using this plugin by xeeZ.

So far I have got a working game mode but with some issues, here are the relevant functions:

Код:

void fscm(int nPlayerID, const char * Format, ...)
{
	char szBuffer[1024];
	va_list args;
	va_start(args, Format);
	vsprintf(szBuffer, Format, args);

	if (SendClientMessage(nPlayerID, 0xFFFFFFFF, szBuffer))
	{
	}

	va_end(args);
}

PLUGIN_EXPORT bool PLUGIN_CALL OnPlayerCommandText(int playerid, const char *cmdtext)
{
	fscm(playerid, "cmdtext: %s", cmdtext);

	char *token1 = NULL;

	char seps[] = " ";

	token1 = strtok((char*)cmdtext, seps);

	char szPlayerName[MAX_PLAYER_NAME];
	GetPlayerName(playerid, szPlayerName, MAX_PLAYER_NAME);

	if (strcmp(token1, "/fix") == 0)
	{
		int nTargetID = 0;

		int nResult = sscanf(cmdtext + strlen(token1) + 1, "%d", &nTargetID);

		if (nResult == 1)
		{
		}
		else
			nTargetID = playerid;

		fscm(playerid, "res: %d | tid: %d | pid: %d", nResult, nTargetID, playerid);

		int nCurVehicle = GetPlayerVehicleID(nTargetID);

		char szTargetName[MAX_PLAYER_NAME];
		GetPlayerName(nTargetID, szTargetName, MAX_PLAYER_NAME);

		if (nCurVehicle)
		{
			SetVehicleHealth(nCurVehicle, 1000.0f);
			RepairVehicle(nCurVehicle);

			fscm(playerid, "You have fixed a vehicle for %s (%d).", szTargetName, nTargetID);
		}
		else
		{
			fscm(playerid, "%s (%d) is not in a vehicle.", szTargetName, nTargetID);
		}

		return true;
	}
}

here is an image with some output:


I realize I should be checking for if it's a valid player or not, but I think there is some deeper issue I don't understand here.

If I put in "/fix 1", and there is nobody with ID 1, I would expect the output from this code to say

Quote:

res: 1 | tid: 1 | pid: 0 (1) is not in a vehicle.

But if you notice when I type anything other than /fix (a valid id), the messages seem to get mangled

Quote:

res: 1 | tid: 1 | pid: 0 res: 1 | tid: 1 | pid: (1) is not in a vehicle.

I am guessing it has something to do with fscm being in a different thread and data getting overwritten, but I don't really understand it.

If somebody can give me an idea what's going on here that would be awesome.

Thanks.

P.S: I know this is the plugin development section, but I think this is more relevant to plugin development than scripting. Let me know if I'm wrong.

[xeeZ]

You can't just get the name of an unconnected player and expect it to be empty. Maybe it was OK in Pawn but not here, sorry. You have to either check if the player exists before calling GetPlayerName or check the return value of GetPlayerName to determine whether it succeeded.

Otherwise you get whatever happens to be in memory before the the call to GetPlayerName, and here it's "res: 1 | tid: 1 | pid: " (notice how it's exactly MAX_PLAYER_NAME characters long).

[Neavorce]

Код:

int nCurVehicle = GetPlayerVehicleID(nTargetID);
if (nCurVehicle)
//...

I think it's not fine, because if the nCurVehicle value is 0 then call the else part.
Use the IsPlayerInVehicle function.

[gtaplayer1]

Quote:

Originally Posted by xeeZ You can't just get the name of an unconnected player and expect it to be empty. Maybe it was OK in Pawn but not here, sorry. You have to either check if the player exists before calling GetPlayerName or check the return value of GetPlayerName to determine whether it succeeded. Otherwise you get whatever happens to be in memory before the the call to GetPlayerName, and here it's "res: 1 | tid: 1 | pid: " (notice how it's exactly MAX_PLAYER_NAME characters long).

Ahh I understand, makes sense now. Thank you for the explanation.

One other question about this plugin.

I know how to do this in pawn, but if I wanted to access functions in another plugin, say, https://sampforum.blast.hk/showthread.php?tid=428066, from within my c++ code, what would be the proper way to access the plugin's functions?

Thanks.

[gtaplayer1]

Quote:

Originally Posted by Neavorce Код: int nCurVehicle = GetPlayerVehicleID(nTargetID); if (nCurVehicle) //... I think it's not fine, because if the nCurVehicle value is 0 then call the else part. Use the IsPlayerInVehicle function.

Thanks, but I think this is fine because I want it to call the else part if there is no vehicle, and there is only 2 options here: in a vehicle or not.

[xeeZ]

Quote:

Originally Posted by gtaplayer1 I know how to do this in pawn, but if I wanted to access functions in another plugin, say, https://sampforum.blast.hk/showthread.php?tid=428066, from within my c++ code, what would be the proper way to access the plugin's functions?

Use sampgdk_invoke_native: http://forum.sa-mp.com/showpost.php?...&postcount=137

[gtaplayer1]

Quote:

Originally Posted by xeeZ Use sampgdk_invoke_native: http://forum.sa-mp.com/showpost.php?...&postcount=137

Thanks, but it is giving me trouble.

When I call sampgdk_invoke_native I get this error:

Quote:

"samp-server.exe - Entry Point Not Found" "The procedure entry point sampgdk_invoke_native could not be located in the dynamic link library sampgdk3.dll"

I presume this means it is defined in the source but the function does not exist in the compiled dll? Why would this be?

Thanks.

EDIT: Nevermind I had an older version of sampgdk3.dll for some reason. Got 3.6 and it is fixed.