1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
Help me with this save file issue
Flashlight
Little Clucker
**
Posts: 20
Threads: 4
Joined: Feb 2013
Reputation: 0
#1

03.02.2013, 12:24
I gave players the possibility that they can own up to 3 vehicles, but when they buy a car the FileID doesnt save in the playerfile:

pawn Код:
new FileID = GetFreeVehicleSlot();
                        if(Player[playerid][Money] >= Player[playerid][DSCarPrice])
                        {
                            Player[playerid][Money] -= Player[playerid][DSCarPrice];
                            GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);

                            new string[36];
                            {
                                
                                format(string, sizeof(string), "Vehicles/Vehicle_%d.ini", FileID);
                            }

                            if(!fexist(string))
                            {
                                Player[playerid][Money] -= Player[playerid][DSCarPrice];
                                GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);

                                SpawnedVehicles++;
                                new VehPlate[255];
                                format(VehPlate, 255, "%s", GetFreeVehiclePlate());

                                dini_Create(string);
                                dini_IntSet(string, "CarID", SpawnedVehicles);
                                dini_IntSet(string, "FactionCar", 0);
                                dini_IntSet(string, "Model", Player[playerid][DSCarID]);
                                dini_FloatSet(string, "XSpawn", 1080.5363);
                                dini_FloatSet(string, "YSpawn", -1738.8501);
                                dini_FloatSet(string, "ZSpawn", 13.3230);
                                dini_FloatSet(string, "AngleSpawn", 267.1113);
                                dini_IntSet(string, "VirtualWorld", 0);
                                dini_IntSet(string, "InteriorID", 0);
                                dini_IntSet(string, "Color1", 1);
                                dini_IntSet(string, "Color2", 1);
                                dini_IntSet(string, "CarGroup", 0);
                                dini_IntSet(string, "RentalCar", -1);
                                dini_Set(string, "vOwner", GetName(playerid));
                                dini_Set(string, "Plate", VehPlate);

                                new NewCar = AddStaticVehicleEx(dini_Int(string, "Model"), dini_Float(string, "XSpawn"), dini_Float(string, "YSpawn"), dini_Float(string, "ZSpawn"), dini_Float(string, "AngleSpawn"), dini_Int(string, "Color1"), dini_Int(string, "Color2"), -1);
                                dini_IntSet(string, "CarID", NewCar);
                                SetVehicleNumberPlate(NewCar, VehPlate);

                                Player[playerid][DSCarPrice] = 0;
                                Player[playerid][DSCarCoins] = 0;
                                Player[playerid][DSCarID] = 0;

                                if(Player[playerid][Car1File] == -1)//starts here the saving part
                                {
                                    Player[playerid][Car1File] = FileID;
                                }
                                else if(Player[playerid][Car2File] == -1 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car2File] = FileID;
                                }
                                else if(Player[playerid][Car3File] == -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car3File] = FileID;
                                }
                                else if(Player[playerid][Car3File] >= -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    SCM(playerid, RED, "You don't have any free vehicle slot.");
                                }
                            }
                            else
                            {
                                SendClientMessage(playerid, WHITE, "This car File already exist");
                            }
                        }
                        else
                        {
                            SCM(playerid, RED, "You don't have enough money with you!");
                        }
-1 means they dont have a car issued on that slot
Find
Reply
Flashlight
Little Clucker
**
Posts: 20
Threads: 4
Joined: Feb 2013
Reputation: 0
#2

04.02.2013, 13:31
*bump*
Find
Reply
Flashlight
Little Clucker
**
Posts: 20
Threads: 4
Joined: Feb 2013
Reputation: 0
#3

05.02.2013, 14:39
*bump*
Find
Reply
ThePhenix
Gangsta
*****
Posts: 801
Threads: 29
Joined: May 2012
Reputation: 0
#4

05.02.2013, 14:45
Try it:
PHP код:
new FileID = GetFreeVehicleSlot();
                        if(Player[playerid][Money] >= Player[playerid][DSCarPrice])
                        {
                            Player[playerid][Money] -= Player[playerid][DSCarPrice];
                            GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);
                          }
                            new string[36];
                            format(string, sizeof(string), "Vehicles/Vehicle_%d.ini", FileID);
                            if(!fexist(string))
                            {
                                Player[playerid][Money] -= Player[playerid][DSCarPrice];
                                GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);
                                SpawnedVehicles++;
                                new VehPlate[255];
                                format(VehPlate, 255, "%s", GetFreeVehiclePlate());
                                dini_Create(string);
                                dini_IntSet(string, "CarID", SpawnedVehicles);
                                dini_IntSet(string, "FactionCar", 0);
                                dini_IntSet(string, "Model", Player[playerid][DSCarID]);
                                dini_FloatSet(string, "XSpawn", 1080.5363);
                                dini_FloatSet(string, "YSpawn", -1738.8501);
                                dini_FloatSet(string, "ZSpawn", 13.3230);
                                dini_FloatSet(string, "AngleSpawn", 267.1113);
                                dini_IntSet(string, "VirtualWorld", 0);
                                dini_IntSet(string, "InteriorID", 0);
                                dini_IntSet(string, "Color1", 1);
                                dini_IntSet(string, "Color2", 1);
                                dini_IntSet(string, "CarGroup", 0);
                                dini_IntSet(string, "RentalCar", -1);
                                dini_Set(string, "vOwner", GetName(playerid));
                                dini_Set(string, "Plate", VehPlate);
                                new NewCar = AddStaticVehicleEx(dini_Int(string, "Model"), dini_Float(string, "XSpawn"), dini_Float(string, "YSpawn"), dini_Float(string, "ZSpawn"), dini_Float(string, "AngleSpawn"), dini_Int(string, "Color1"), dini_Int(string, "Color2"), -1);
                                dini_IntSet(string, "CarID", NewCar);
                                SetVehicleNumberPlate(NewCar, VehPlate);
                                Player[playerid][DSCarPrice] = 0;
                                Player[playerid][DSCarCoins] = 0;
                                Player[playerid][DSCarID] = 0;
                                if(Player[playerid][Car1File] == -1)//starts here the saving part
                                {
                                    Player[playerid][Car1File] = FileID;
                                }
                                else if(Player[playerid][Car2File] == -1 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car2File] = FileID;
                                }
                                else if(Player[playerid][Car3File] == -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car3File] = FileID;
                                }
                                else if(Player[playerid][Car3File] >= -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    SCM(playerid, RED, "You don't have any free vehicle slot.");
                                }
                            }
                            else
                            {
                                SendClientMessage(playerid, WHITE, "This car File already exist");
                            }
                        }
                        else
                        {
                            SCM(playerid, RED, "You don't have enough money with you!");
                        } 
Find
Reply
Pangea
Big Clucker
***
Posts: 72
Threads: 2
Joined: Feb 2011
Reputation: 0
#5

05.02.2013, 14:46
Does it never save, or does it save when you only have 1 or 2 cars?
BTW: The if-statement can be changed into:

pawn Код:
if(Player[playerid][Car1File] == -1)//starts here the saving part
{
    Player[playerid][Car1File] = FileID;
}
else if(Player[playerid][Car2File] == -1)
{
    Player[playerid][Car2File] = FileID;
}
else if(Player[playerid][Car3File] == -1)
{
    Player[playerid][Car3File] = FileID;
}
else
{
    SCM(playerid, RED, "You don't have any free vehicle slot.");
}
If you check carfile1 the first time and it isn't -1, why would you check it 3 more times?
Find
Reply
Flashlight
Little Clucker
**
Posts: 20
Threads: 4
Joined: Feb 2013
Reputation: 0
#6

05.02.2013, 14:53
The other ones are for CarFile 2 and 3, people can own up to 3 cars.
And it never saved... it stays -1
Find
Reply
ThePhenix
Gangsta
*****
Posts: 801
Threads: 29
Joined: May 2012
Reputation: 0
#7

05.02.2013, 14:56
Just try it..
After that, Try to improve the code:

PHP код:
new FileID = GetFreeVehicleSlot();
                        if(Player[playerid][Money] >= Player[playerid][DSCarPrice])
                        {
                            Player[playerid][Money] -= Player[playerid][DSCarPrice];
                            GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);
                          }
                            new string[36];
                            format(string, sizeof(string), "Vehicles/Vehicle_%d.ini", FileID);
                            if(!fexist(string))
                            {
                                Player[playerid][Money] -= Player[playerid][DSCarPrice];
                                GivePlayerMoney(playerid, -Player[playerid][DSCarPrice]);
                                SpawnedVehicles++;
                                new VehPlate[255];
                                format(VehPlate, 255, "%s", GetFreeVehiclePlate());
                                dini_Create(string);
                                dini_IntSet(string, "CarID", SpawnedVehicles);
                                dini_IntSet(string, "FactionCar", 0);
                                dini_IntSet(string, "Model", Player[playerid][DSCarID]);
                                dini_FloatSet(string, "XSpawn", 1080.5363);
                                dini_FloatSet(string, "YSpawn", -1738.8501);
                                dini_FloatSet(string, "ZSpawn", 13.3230);
                                dini_FloatSet(string, "AngleSpawn", 267.1113);
                                dini_IntSet(string, "VirtualWorld", 0);
                                dini_IntSet(string, "InteriorID", 0);
                                dini_IntSet(string, "Color1", 1);
                                dini_IntSet(string, "Color2", 1);
                                dini_IntSet(string, "CarGroup", 0);
                                dini_IntSet(string, "RentalCar", -1);
                                dini_Set(string, "vOwner", GetName(playerid));
                                dini_Set(string, "Plate", VehPlate);
                                new NewCar = AddStaticVehicleEx(dini_Int(string, "Model"), dini_Float(string, "XSpawn"), dini_Float(string, "YSpawn"), dini_Float(string, "ZSpawn"), dini_Float(string, "AngleSpawn"), dini_Int(string, "Color1"), dini_Int(string, "Color2"), -1);
                                dini_IntSet(string, "CarID", NewCar);
                                SetVehicleNumberPlate(NewCar, VehPlate);
                                Player[playerid][DSCarPrice] = 0;
                                Player[playerid][DSCarCoins] = 0;
                                Player[playerid][DSCarID] = 0;
                                if(Player[playerid][Car1File] == -1)//starts here the saving part
                                {
                                    Player[playerid][Car1File] = FileID;
                                }
                                else if(Player[playerid][Car2File] == -1 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car2File] = FileID;
                                }
                                else if(Player[playerid][Car3File] == -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    Player[playerid][Car3File] = FileID;
                                }
                                else if(Player[playerid][Car3File] >= -1 && Player[playerid][Car2File] >= 0 && Player[playerid][Car1File] >= 0)
                                {
                                    SCM(playerid, RED, "You don't have any free vehicle slot.");
                                }
                            }
                            else
                            {
                                SendClientMessage(playerid, WHITE, "This car File already exist");
                            }
                        }
                        else
                        {
                            SCM(playerid, RED, "You don't have enough money with you!");
                        } 
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help