1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
How to do this without spamming (onplayerupdate / sendclientmessage)
AMEENAMEEN
Huge Clucker
****
Posts: 418
Threads: 56
Joined: Aug 2009
Reputation: 0
#1

07.01.2013, 05:09
Alright so this is my weapon cheat detection system

pawn Код:
enum ServerWeapons
{
    Melee,
    Thrown,
    Pistols,
    Shotguns,
    SubMachine,
    Assault,
    Rifles,
    Heavy,
    Handheld,

}
new ServerWeapons[MAX_PLAYERS][ServerWeapons];
pawn Код:
public OnPlayerUpdate(playerid)
{
CheckServerWeapons(playerid);
return 1;
}

How to make it Not to spam these admin messages?
pawn Код:
CheckServerWeapons(playerid)
{
    new weaponid = GetPlayerWeapon(playerid);

    if(weaponid >= 1 && weaponid <= 15)
    {
        if(weaponid == ServerWeapons[playerid][Melee])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a melee weapon.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1); // ABroadCast Is same as send client message but only sends to admins
            }
    }

        if( weaponid >= 16 && weaponid <= 18 || weaponid == 39 ) // Checking Thrown
    {
        if(weaponid == ServerWeapons[playerid][Thrown])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Thrown weapon.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }
    if( weaponid >= 22 && weaponid <= 24 ) // Checking Pistols
    {
        if(weaponid == ServerWeapons[playerid][Pistols])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Pistol.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }

    if( weaponid >= 25 && weaponid <= 27 ) // Checking Shotguns
    {
        if(weaponid == ServerWeapons[playerid][Shotguns])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Shotgun.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }
    if( weaponid == 28 || weaponid == 29 || weaponid == 32 ) // Checking Sub Machine Guns
    {
        if(weaponid == ServerWeapons[playerid][SubMachine])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Sub machine gun weapon.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }

    if( weaponid == 30 || weaponid == 31 ) // Checking Assault
    {
        if(weaponid == ServerWeapons[playerid][Assault])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Assault weapon.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }

    if( weaponid == 33 || weaponid == 34 ) // Checking Rifles
    {
        if(weaponid == ServerWeapons[playerid][Rifles])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a Rifle.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }
    if( weaponid >= 35 && weaponid <= 38 ) // Checking Heavy
    {
        if(weaponid == ServerWeapons[playerid][Heavy])
        {
        return 1;
        }
            else
            {
            new sendername[ MAX_PLAYER_NAME ];
            new string[128];
            GetPlayerName(playerid, sendername, sizeof(sendername));
            format(string, 128, "AdmWarn: %s has possibly hacked a heavy weapon.", sendername);
            ABroadCast(COLOR_YELLOW, string, 1);
            }
    }
    else { return 1; }
    
return 1;
}
pawn Код:
ServerWeapon(playerid, weaponid, ammo)
{
if(weaponid >= 1 && weaponid <= 15)
    {
    ServerWeapons[playerid][Melee] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }

        if( weaponid >= 16 && weaponid <= 18 || weaponid == 39 ) // Checking Thrown
    {
    ServerWeapons[playerid][Thrown] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }
    if( weaponid >= 22 && weaponid <= 24 ) // Checking Pistols
    {
    ServerWeapons[playerid][Pistols] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }

    if( weaponid >= 25 && weaponid <= 27 ) // Checking Shotguns
    {
    ServerWeapons[playerid][Shotguns] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }
    if( weaponid == 28 || weaponid == 29 || weaponid == 32 ) // Checking Sub Machine Guns
    {
    ServerWeapons[playerid][SubMachine] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }

    if( weaponid == 30 || weaponid == 31 ) // Checking Assault
    {
    ServerWeapons[playerid][Assault] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }

    if( weaponid == 33 || weaponid == 34 ) // Checking Rifles
    {
    ServerWeapons[playerid][Rifles] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }
    if( weaponid >= 35 && weaponid <= 38 ) // Checking Heavy
    {
    ServerWeapons[playerid][Heavy] = weaponid;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
    }
return 1;
}
Find
Reply
dr.lozer
Huge Clucker
****
Posts: 371
Threads: 66
Joined: Oct 2012
Reputation: 0
#2

07.01.2013, 05:51
make a public and callback it
Find
Reply
AMEENAMEEN
Huge Clucker
****
Posts: 418
Threads: 56
Joined: Aug 2009
Reputation: 0
#3

07.01.2013, 06:25
Can you show me an example
Find
Reply
cosbraa
Big Clucker
***
Posts: 126
Threads: 14
Joined: Apr 2012
Reputation: 0
#4

07.01.2013, 06:40
OnGameModeInit:
SetTimer("CheckServerWeapons", 1000, true);

Remove "CheckServerWeapons(playerid);" from OnPlayerUpdate.

And change the CheckServerWeapons(playerid) to CheckServerWeapons(), then replace callback with this;
pawn Код:
forward CheckServerWeapons();
public CheckServerWeapons()
{
    foreach(Player, playerid)
    {
        new weaponid = GetPlayerWeapon(playerid);

        if(weaponid >= 1 && weaponid <= 15)
        {
            if(weaponid == ServerWeapons[playerid][Melee])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a melee weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1); // ABroadCast Is same as send client message but only sends to admins
                }
        }

            if( weaponid >= 16 && weaponid <= 18 || weaponid == 39 ) // Checking Thrown
        {
            if(weaponid == ServerWeapons[playerid][Thrown])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Thrown weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid >= 22 && weaponid <= 24 ) // Checking Pistols
        {
            if(weaponid == ServerWeapons[playerid][Pistols])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Pistol.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid >= 25 && weaponid <= 27 ) // Checking Shotguns
        {
            if(weaponid == ServerWeapons[playerid][Shotguns])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Shotgun.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid == 28 || weaponid == 29 || weaponid == 32 ) // Checking Sub Machine Guns
        {
            if(weaponid == ServerWeapons[playerid][SubMachine])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Sub machine gun weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid == 30 || weaponid == 31 ) // Checking Assault
        {
            if(weaponid == ServerWeapons[playerid][Assault])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Assault weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid == 33 || weaponid == 34 ) // Checking Rifles
        {
            if(weaponid == ServerWeapons[playerid][Rifles])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Rifle.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid >= 35 && weaponid <= 38 ) // Checking Heavy
        {
            if(weaponid == ServerWeapons[playerid][Heavy])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a heavy weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        else { return 1; }
    }
    return 1;
}
Find
Reply
cosbraa
Big Clucker
***
Posts: 126
Threads: 14
Joined: Apr 2012
Reputation: 0
#5

07.01.2013, 06:42
double post
Find
Reply
AMEENAMEEN
Huge Clucker
****
Posts: 418
Threads: 56
Joined: Aug 2009
Reputation: 0
#6

07.01.2013, 07:13
Thanks , will test this.
Find
Reply
dr.lozer
Huge Clucker
****
Posts: 371
Threads: 66
Joined: Oct 2012
Reputation: 0
#7

07.01.2013, 07:36
Quote:
Originally Posted by cosbraa
Посмотреть сообщение
OnGameModeInit:
SetTimer("CheckServerWeapons", 1000, true);

Remove "CheckServerWeapons(playerid);" from OnPlayerUpdate.

And change the CheckServerWeapons(playerid) to CheckServerWeapons(), then replace callback with this;
pawn Код:
forward CheckServerWeapons();
public CheckServerWeapons()
{
    foreach(Player, playerid)
    {
        new weaponid = GetPlayerWeapon(playerid);

        if(weaponid >= 1 && weaponid <= 15)
        {
            if(weaponid == ServerWeapons[playerid][Melee])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a melee weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1); // ABroadCast Is same as send client message but only sends to admins
                }
        }

            if( weaponid >= 16 && weaponid <= 18 || weaponid == 39 ) // Checking Thrown
        {
            if(weaponid == ServerWeapons[playerid][Thrown])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Thrown weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid >= 22 && weaponid <= 24 ) // Checking Pistols
        {
            if(weaponid == ServerWeapons[playerid][Pistols])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Pistol.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid >= 25 && weaponid <= 27 ) // Checking Shotguns
        {
            if(weaponid == ServerWeapons[playerid][Shotguns])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Shotgun.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid == 28 || weaponid == 29 || weaponid == 32 ) // Checking Sub Machine Guns
        {
            if(weaponid == ServerWeapons[playerid][SubMachine])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Sub machine gun weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid == 30 || weaponid == 31 ) // Checking Assault
        {
            if(weaponid == ServerWeapons[playerid][Assault])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Assault weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }

        if( weaponid == 33 || weaponid == 34 ) // Checking Rifles
        {
            if(weaponid == ServerWeapons[playerid][Rifles])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a Rifle.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        if( weaponid >= 35 && weaponid <= 38 ) // Checking Heavy
        {
            if(weaponid == ServerWeapons[playerid][Heavy])
            {
            return 1;
            }
                else
                {
                new sendername[ MAX_PLAYER_NAME ];
                new string[128];
                GetPlayerName(playerid, sendername, sizeof(sendername));
                format(string, 128, "AdmWarn: %s has possibly hacked a heavy weapon.", sendername);
                ABroadCast(COLOR_YELLOW, string, 1);
                }
        }
        else { return 1; }
    }
    return 1;
}
he doesn't have foreach (i think)
Find
Reply
AMEENAMEEN
Huge Clucker
****
Posts: 418
Threads: 56
Joined: Aug 2009
Reputation: 0
#8

07.01.2013, 07:58
I do have it
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help