1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive

Threaded Mode
/event problem.
Razvann
Huge Clucker
****
Posts: 301
Threads: 54
Joined: Jul 2009
Reputation: 0
#1

26.02.2010, 18:58
pawn Код:
if(strcmp(cmd, "/event", true) == 0)
    {
      if(IsPlayerConnected(playerid))
      {
        if(PlayerInfo[playerid][pAdmin] >= 4)
        {
                new x_nr[256];
                x_nr = strtok(cmdtext, idx);
            if(!strlen(x_nr))
            {
                SendClientMessage(playerid, COLOR_WHITE, "USAGE: /event [guns,health,teleport]");
            return 1;
        }
            if(strcmp(x_nr,"guns",true) == 0)
            {
            tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                    SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /event guns [gunid][ammo]");
            return 1;
                }
                    new gun;
                new ftext[50];
                    if(gun == 1) { ftext = "Brass Knuckles"; }
                    else if(gun == 2) { ftext = "Golf Club"; }
                    else if(gun == 3) { ftext = "NightStick"; }
                    else if(gun == 4) { ftext = "Knife"; }
                    else if(gun == 5) { ftext = "Baseball Bat"; }
                    else if(gun == 6) { ftext = "Shovel"; }
                    else if(gun == 7) { ftext = "Pool Cue"; }
                    else if(gun == 8) { ftext = "Katana"; }
                    else if(gun == 9) { ftext = "Chainsaw"; }
                    else if(gun == 10) { ftext = "Purple Dildo"; }
                    else if(gun == 11) { ftext = "Small White Vibrator"; }
                    else if(gun == 12) { ftext = "Large White Vibrator"; }
                    else if(gun == 13) { ftext = "Silver Vibrator"; }
                    else if(gun == 14) { ftext = "Flowers"; }
                    else if(gun == 15) { ftext = "Cane"; }
                    else if(gun == 16) { ftext = "Grenade"; }
                    else if(gun == 17) { ftext = "Tear Gas"; }
                    else if(gun == 18) { ftext = "Molotov Cocktail"; }
                    else if(gun == 22) { ftext = "9MM"; }
                    else if(gun == 23) { ftext = "Silenced 9mm"; }
                    else if(gun == 24) { ftext = "Desert Eagle"; }
                    else if(gun == 25) { ftext = "Shotgun"; }
                    else if(gun == 26) { ftext = "Sawn-off Shotgun"; }
                    else if(gun == 27) { ftext = "Combat Shotgun"; }
                    else if(gun == 28) { ftext = "Micro SMG"; }
                    else if(gun == 29) { ftext = "MP5"; }
                    else if(gun == 30) { ftext = "AK-47"; }
                    else if(gun == 31) { ftext = "M4"; }
                    else if(gun == 32) { ftext = "Tec9"; }
                    else if(gun == 33) { ftext = "Country Rifle"; }
                    else if(gun == 34) { ftext = "Sniper Rifle"; }
                    else if(gun == 35) { ftext = "Rocket Launcher"; }
                    else if(gun == 36) { ftext = "HS Rocket Launcher"; }
                    else if(gun == 37) { ftext = "Flamethrower"; }
                    else if(gun == 38) { ftext = "Minigun"; }
                    else if(gun == 41) { ftext = "Spraycan"; }
                    else if(gun == 42) { ftext = "Fire Extinguisher"; }
                    else if(gun == 43) { ftext = "Camera"; }
                    else if(gun == 44) { ftext = "Nightvision Goggle"; }
                    else if(gun == 45) { ftext = "Thermal Goggles"; }
                    else if(gun == 46) { ftext = "Parachutte"; }
                    new ammo;
                    gun = strval(tmp);
                    if(gun < 1||gun > 46||gun==27||gun==1||gun==2||gun==9||gun==17||gun==19||gun==20||gun==21||gun==36||gun==38||gun==39||gun==40||gun==44||gun==45)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  wrong WeaponID!"); return 1; }
                    ammo = strval(tmp);
                    if(ammo <1 ||ammo > 999)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  dont go below 1 or above 999 bullets!"); return 1; }
                    for(new i;i<MAX_PLAYERS;i++)
                    {
                      GivePlayerWeapon(i, gun, ammo);
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        format(string, 256, "You have received a %s with %d ammo from admin %s.",ftext,ammo,sendername);
                        SendClientMessage(i,0xC84200AA,string);
                        format(string, 256, "[EVENT]: %s has gived a %s with %d ammo.",sendername,ftext,ammo);
                        SendClientMessageToAll(COLOR_LIGHTRED, string);
                      return 1;
                    }
                }
            }
        }
        return 1;
    }
What's wrong?

I type /event guns 24 100 and I receive a Deagle with 24 ammo not with 100, why?
Find
Reply
Jeffry
High-roller
*****
Posts: 1,594
Threads: 61
Joined: Oct 2009
Reputation: 0
#2

26.02.2010, 19:19
pawn Код:
if(strcmp(cmd, "/event", true) == 0)
    {
      if(IsPlayerConnected(playerid))
      {
        if(PlayerInfo[playerid][pAdmin] >= 4)
        {
                new x_nr[256];
                x_nr = strtok(cmdtext, idx);
            if(!strlen(x_nr))
            {
                SendClientMessage(playerid, COLOR_WHITE, "USAGE: /event [guns,health,teleport]");
            return 1;
        }
            if(strcmp(x_nr,"guns",true) == 0)
            {
            tmp = strtok(cmdtext, idx);
            tmp2 = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                    SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /event guns [gunid][ammo]");
            return 1;
                }
                    new gun;
                new ftext[50];
                    gun = strval(tmp);
                    if(gun == 1) { ftext = "Brass Knuckles"; }
                    else if(gun == 2) { ftext = "Golf Club"; }
                    else if(gun == 3) { ftext = "NightStick"; }
                    else if(gun == 4) { ftext = "Knife"; }
                    else if(gun == 5) { ftext = "Baseball Bat"; }
                    else if(gun == 6) { ftext = "Shovel"; }
                    else if(gun == 7) { ftext = "Pool Cue"; }
                    else if(gun == 8) { ftext = "Katana"; }
                    else if(gun == 9) { ftext = "Chainsaw"; }
                    else if(gun == 10) { ftext = "Purple Dildo"; }
                    else if(gun == 11) { ftext = "Small White Vibrator"; }
                    else if(gun == 12) { ftext = "Large White Vibrator"; }
                    else if(gun == 13) { ftext = "Silver Vibrator"; }
                    else if(gun == 14) { ftext = "Flowers"; }
                    else if(gun == 15) { ftext = "Cane"; }
                    else if(gun == 16) { ftext = "Grenade"; }
                    else if(gun == 17) { ftext = "Tear Gas"; }
                    else if(gun == 18) { ftext = "Molotov Cocktail"; }
                    else if(gun == 22) { ftext = "9MM"; }
                    else if(gun == 23) { ftext = "Silenced 9mm"; }
                    else if(gun == 24) { ftext = "Desert Eagle"; }
                    else if(gun == 25) { ftext = "Shotgun"; }
                    else if(gun == 26) { ftext = "Sawn-off Shotgun"; }
                    else if(gun == 27) { ftext = "Combat Shotgun"; }
                    else if(gun == 28) { ftext = "Micro SMG"; }
                    else if(gun == 29) { ftext = "MP5"; }
                    else if(gun == 30) { ftext = "AK-47"; }
                    else if(gun == 31) { ftext = "M4"; }
                    else if(gun == 32) { ftext = "Tec9"; }
                    else if(gun == 33) { ftext = "Country Rifle"; }
                    else if(gun == 34) { ftext = "Sniper Rifle"; }
                    else if(gun == 35) { ftext = "Rocket Launcher"; }
                    else if(gun == 36) { ftext = "HS Rocket Launcher"; }
                    else if(gun == 37) { ftext = "Flamethrower"; }
                    else if(gun == 38) { ftext = "Minigun"; }
                    else if(gun == 41) { ftext = "Spraycan"; }
                    else if(gun == 42) { ftext = "Fire Extinguisher"; }
                    else if(gun == 43) { ftext = "Camera"; }
                    else if(gun == 44) { ftext = "Nightvision Goggle"; }
                    else if(gun == 45) { ftext = "Thermal Goggles"; }
                    else if(gun == 46) { ftext = "Parachutte"; }
                    new ammo;
                    if(gun < 1||gun > 46||gun==27||gun==1||gun==2||gun==9||gun==17||gun==19||gun==20||gun==21||gun==36||gun==38||gun==39||gun==40||gun==44||gun==45)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  wrong WeaponID!"); return 1; }
                    ammo = strval(tmp2);
                    if(ammo <1 ||ammo > 999)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  dont go below 1 or above 999 bullets!"); return 1; }
                    for(new i;i<MAX_PLAYERS;i++)
                    {
                      GivePlayerWeapon(i, gun, ammo);
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        format(string, 256, "You have received a %s with %d ammo from admin %s.",ftext,ammo,sendername);
                        SendClientMessage(i,0xC84200AA,string);
                        format(string, 256, "[EVENT]: %s has gived a %s with %d ammo.",sendername,ftext,ammo);
                        SendClientMessageToAll(COLOR_LIGHTRED, string);
                      return 1;
                    }
                }
            }
        }
        return 1;
    }
Try this. Its untested. Say if there are any errors.
I can test it tomorrow, if it wont work now.
Find
Reply
notime
Big Clucker
***
Posts: 198
Threads: 3
Joined: Nov 2008
Reputation: 0
#3

26.02.2010, 23:16
let me guess, you try this in a server where ur id 0?
i think the problem is:
Код:
for(new i;i<MAX_PLAYERS;i++)
{
	GivePlayerWeapon(i, gun, ammo);
	GetPlayerName(playerid, sendername, sizeof(sendername));
	format(string, 256, "You have received a %s with %d ammo from admin %s.",ftext,ammo,sendername);
	SendClientMessage(i,0xC84200AA,string);
	format(string, 256, "[EVENT]: %s has gived a %s with %d ammo.",sendername,ftext,ammo);
	SendClientMessageToAll(COLOR_LIGHTRED, string);
	return 1;<<<here
}
remove the "return 1;" and i think it wil work
Find
Reply
Razvann
Huge Clucker
****
Posts: 301
Threads: 54
Joined: Jul 2009
Reputation: 0
#4

27.02.2010, 13:24
Quote:
Originally Posted by Jeffry
pawn Код:
if(strcmp(cmd, "/event", true) == 0)
    {
      if(IsPlayerConnected(playerid))
      {
        if(PlayerInfo[playerid][pAdmin] >= 4)
        {
                new x_nr[256];
                x_nr = strtok(cmdtext, idx);
            if(!strlen(x_nr))
            {
                SendClientMessage(playerid, COLOR_WHITE, "USAGE: /event [guns,health,teleport]");
            return 1;
        }
            if(strcmp(x_nr,"guns",true) == 0)
            {
            tmp = strtok(cmdtext, idx);
            tmp2 = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                    SendClientMessage(playerid, COLOR_GRAD1, "USAGE: /event guns [gunid][ammo]");
            return 1;
                }
                    new gun;
                new ftext[50];
                    gun = strval(tmp);
                    if(gun == 1) { ftext = "Brass Knuckles"; }
                    else if(gun == 2) { ftext = "Golf Club"; }
                    else if(gun == 3) { ftext = "NightStick"; }
                    else if(gun == 4) { ftext = "Knife"; }
                    else if(gun == 5) { ftext = "Baseball Bat"; }
                    else if(gun == 6) { ftext = "Shovel"; }
                    else if(gun == 7) { ftext = "Pool Cue"; }
                    else if(gun == 8) { ftext = "Katana"; }
                    else if(gun == 9) { ftext = "Chainsaw"; }
                    else if(gun == 10) { ftext = "Purple Dildo"; }
                    else if(gun == 11) { ftext = "Small White Vibrator"; }
                    else if(gun == 12) { ftext = "Large White Vibrator"; }
                    else if(gun == 13) { ftext = "Silver Vibrator"; }
                    else if(gun == 14) { ftext = "Flowers"; }
                    else if(gun == 15) { ftext = "Cane"; }
                    else if(gun == 16) { ftext = "Grenade"; }
                    else if(gun == 17) { ftext = "Tear Gas"; }
                    else if(gun == 18) { ftext = "Molotov Cocktail"; }
                    else if(gun == 22) { ftext = "9MM"; }
                    else if(gun == 23) { ftext = "Silenced 9mm"; }
                    else if(gun == 24) { ftext = "Desert Eagle"; }
                    else if(gun == 25) { ftext = "Shotgun"; }
                    else if(gun == 26) { ftext = "Sawn-off Shotgun"; }
                    else if(gun == 27) { ftext = "Combat Shotgun"; }
                    else if(gun == 28) { ftext = "Micro SMG"; }
                    else if(gun == 29) { ftext = "MP5"; }
                    else if(gun == 30) { ftext = "AK-47"; }
                    else if(gun == 31) { ftext = "M4"; }
                    else if(gun == 32) { ftext = "Tec9"; }
                    else if(gun == 33) { ftext = "Country Rifle"; }
                    else if(gun == 34) { ftext = "Sniper Rifle"; }
                    else if(gun == 35) { ftext = "Rocket Launcher"; }
                    else if(gun == 36) { ftext = "HS Rocket Launcher"; }
                    else if(gun == 37) { ftext = "Flamethrower"; }
                    else if(gun == 38) { ftext = "Minigun"; }
                    else if(gun == 41) { ftext = "Spraycan"; }
                    else if(gun == 42) { ftext = "Fire Extinguisher"; }
                    else if(gun == 43) { ftext = "Camera"; }
                    else if(gun == 44) { ftext = "Nightvision Goggle"; }
                    else if(gun == 45) { ftext = "Thermal Goggles"; }
                    else if(gun == 46) { ftext = "Parachutte"; }
                    new ammo;
                    if(gun < 1||gun > 46||gun==27||gun==1||gun==2||gun==9||gun==17||gun==19||gun==20||gun==21||gun==36||gun==38||gun==39||gun==40||gun==44||gun==45)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  wrong WeaponID!"); return 1; }
                    ammo = strval(tmp2);
                    if(ammo <1 ||ammo > 999)
                    { SendClientMessage(playerid, COLOR_GRAD1, "  dont go below 1 or above 999 bullets!"); return 1; }
                    for(new i;i<MAX_PLAYERS;i++)
                    {
                      GivePlayerWeapon(i, gun, ammo);
                        GetPlayerName(playerid, sendername, sizeof(sendername));
                        format(string, 256, "You have received a %s with %d ammo from admin %s.",ftext,ammo,sendername);
                        SendClientMessage(i,0xC84200AA,string);
                        format(string, 256, "[EVENT]: %s has gived a %s with %d ammo.",sendername,ftext,ammo);
                        SendClientMessageToAll(COLOR_LIGHTRED, string);
                      return 1;
                    }
                }
            }
        }
        return 1;
    }
Try this. Its untested. Say if there are any errors.
I can test it tomorrow, if it wont work now.
Undefined symbol, tmp2.
Find
Reply
Jeffry
High-roller
*****
Posts: 1,594
Threads: 61
Joined: Oct 2009
Reputation: 0
#5

27.02.2010, 13:26
Add at your command.
pawn Код:
new tmp[256];
Test it, and tell me if it works. Else I will test it for you later.





EDIT: 300st post.
Find
Reply
Razvann
Huge Clucker
****
Posts: 301
Threads: 54
Joined: Jul 2009
Reputation: 0
#6

27.02.2010, 13:29
Код:
warning 219: local variable "tmp" shadows a variable at a preceding level
error 017: undefined symbol "tmp2" - x2
Find
Reply
Vince
Spam Machine
*****
Posts: 10,066
Threads: 38
Joined: Sep 2007
Reputation: 0
#7

27.02.2010, 13:37
Start using dcmd or zcmd with sscanf, much simpler than calling strtok all the time.

pawn Код:
dcmd_event(playerid, params[])
{
  if(PlayerInfo[playerid][pAdmin] < 4) return SendClientMessage(playerid, COLOR_RED, "Not admin");
  new
    event[32],
    gunid,
    ammo;

  if(sscanf(params, "sii", event, gunid, ammo)) return SendClientMessage(playerid, COLOR_RED, "Usage: /event ...");
  
  if(!strcmp(event, "guns"))
  {
    GivePlayerWeapon(playerid, gunid, ammo);
    // or whatever should happen if an admin types /event guns ..
  }

  if(!strcmp(event, "health))
  {
    SetPlayerHealth(playerid, 100.0);
  }

  if(!strcmp(event, "teleport))
  {
    SetPlayerPos(playerid, 0.0, 0.0, 5.0);
  }
  return 1;
}
Oh, btw, use the switch function for those gunid's instead of 50 times else if.
Find
Reply
Jeffry
High-roller
*****
Posts: 1,594
Threads: 61
Joined: Oct 2009
Reputation: 0
#8

27.02.2010, 15:35
Yeah, thats the better way.
Find
Reply
Razvann
Huge Clucker
****
Posts: 301
Threads: 54
Joined: Jul 2009
Reputation: 0
#9

27.02.2010, 15:49
Know that but I don't use dcmd .

btw, I will try.
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 1 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help
  4. Help Archive