[Kraeror]

Hello guys! I have a problem, when I type /territories to see all territories of the factions/gangs and if the factions/gangs like Ballas and Grove owns 0 territories it says:

Quote:

Ballas owns 0 territories Ballas owns 0 territories

I mean 2 times that, instead of:

Quote:

Grove owns 0 territories Ballas owns 0 territories

There is the code of sorting the territories:

PHP код:

cmd:Territories(playerid, params[])
{
    new FactionNamee[255], string2[256];
    enum ENUM_GANG
    {
        E_TEAMNAME[32],
        E_TERRITORIESWON
    };
    new SIZE_ENUM_GANG[ENUM_GANG];
    new array[MAX_FACTIONS][ENUM_GANG];
     for(new i = 0; i < MAX_FACTIONS; i++)
    {
        format(string2, sizeof(string2), "/Factions/%d.dini.save", i);
        if(dini_Exists(string2))
        {
            FactionNamee = dini_Get(string2,"FactionName");
        }
         strcpy(array[i][E_TEAMNAME], FactionNamee, sizeof(SIZE_ENUM_GANG[E_TEAMNAME]));
        array[i][E_TERRITORIESWON] = FactionInfo[i][tWons];
    }
    SortDeepArray(array, E_TERRITORIESWON, .order = SORT_DESC);
    new TerritoryString[2560];
     for(new i = 0; i < MAX_FACTIONS; i++)
    {
        format(string2, sizeof(string2), "/Factions/%d.dini.save", i);
        if(!dini_Exists(string2))
        {
            break;
        }
        format(TerritoryString, sizeof(TerritoryString), "{%06x}%s%s owns %d territories.\n", COLOR_FACTIONS  >>> 8, TerritoryString, array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]);
    }
    ShowPlayerDialog(playerid,29,DIALOG_STYLE_MSGBOX, "{82FFFF}Territories:", TerritoryString, "{FF0000}Close", "");
    SIZE_ENUM_GANG[E_TERRITORIESWON] = 0;
    return 1;
} 


EDITED: +1 REP if You help me

[d1git]

PHP код:

new TerritoryString[2560];
format(TerritoryString, sizeof(TerritoryString), "{%06x}%s%s owns %d territories.\n", COLOR_FACTIONS  >>> 8, TerritoryString, array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]); 


You're formatting the string variable inside the loop, causing it to reset and eventually only contain the last value of whatever it is you're formatting inside the loop.

PHP код:

new 
    territoryString[1024],
    territoryStringTemp[128]
;
for(new i = 0; i < MAX_FACTIONS; i++) { 
    format(string2, sizeof string2, "/Factions/%d.dini.save", i); 
    if(!dini_Exists(string2))
        break; 
    
    format(territoryStringTemp, sizeof territoryStringTemp, "{%06x}%s%s owns %d territories.\n", COLOR_FACTIONS  >>> 8, TerritoryString, array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]);
    strcat(territoryString, territoyStringTemp);
} 


PHP код:

ShowPlayerDialog(playerid,29,DIALOG_STYLE_MSGBOX, "{82FFFF}Territories:", territoryString, "{FF0000}Close", ""); 


[Kraeror]

Quote:

Originally Posted by d1git PHP код: new TerritoryString[2560]; format(TerritoryString, sizeof(TerritoryString), "{%06x}%s%s owns %d territories.\n", COLOR_FACTIONS  >>> 8, TerritoryString, array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]);  You're formatting the string variable inside the loop, causing it to reset and eventually only contain the last value of whatever it is you're formatting inside the loop. PHP код: new      territoryString[1024],     territoryStringTemp[128] ; for(new i = 0; i < MAX_FACTIONS; i++) {      format(string2, sizeof string2, "/Factions/%d.dini.save", i);      if(!dini_Exists(string2))         break;           format(territoryStringTemp, sizeof territoryStringTemp, "{%06x}%s%s owns %d territories.\n", COLOR_FACTIONS  >>> 8, TerritoryString, array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]);     strcat(territoryString, territoyStringTemp); }  PHP код: ShowPlayerDialog(playerid,29,DIALOG_STYLE_MSGBOX, "{82FFFF}Territories:", territoryString, "{FF0000}Close", "");

Still the same problem!
Here is the output, when all gangs have no territories: https://imgur.com/a/fldFE
Here is the second one, when the gangs have 1,1 and 7 territories: https://imgur.com/a/JFAN4

[d1git]

Start by debugging your code, check what "array" contains after the first loop, debug the entries that get put into the array in the first loop, do approximately the same for the second loop.

By the way, you're sorting the array by territories won, the second loop will mix up the ids;

Код:

Ballas = 0 [1 Win]
Grove = 1 [0 Wins]
White = 2 [3 Wins]

After the sorting, the array will look like this;

Код:

White = 2 [3 Wins]
Ballas = 0 [1 Win]
Grove = 1 [0 Wins]

The second loop loops in order, 0 to MAX_FACTIONS, you're getting the array entry data by order;

PHP код:

for(new i = 0; i < MAX_FACTIONS; i++) {
    array[i][E_TEAMNAME], array[i][E_TERRITORIESWON]
} 


Array Entry 1 contains "Ballas" but because you're looping in order, it actually contains "Grove" - this is something you should fix.

[Kraeror]

Quote:

Originally Posted by d1git Start by debugging your code, check what "array" contains after the first loop, debug the entries that get put into the array in the first loop, do approximately the same for the second loop. By the way, you're sorting the array by territories won, the second loop will mix up the ids; Код: Ballas = 0 [1 Win] Grove = 1 [0 Wins] White = 2 [3 Wins] After the sorting, the array will look like this; Код: White = 2 [3 Wins] Ballas = 0 [1 Win] Grove = 1 [0 Wins] The second loop loops in order, 0 to MAX_FACTIONS, you're getting the array entry data by order; PHP код: for(new i = 0; i < MAX_FACTIONS; i++) {     array[i][E_TEAMNAME], array[i][E_TERRITORIESWON] }  Array Entry 1 contains "Ballas" but because you're looping in order, it actually contains "Grove" - this is something you should fix.

Sorry, but I didn't understand You, can you tell me what I have to do to remove this mix up and fix this?

[Kraeror]

Any help ?

[Andre02]

Quote:

Originally Posted by Kraeror Any help ?

Is the command used to simply show how many territories a gang has?

[Kraeror]

Quote:

Originally Posted by Andre02 Is the command used to simply show how many territories a gang has?

Yes, but the territories are sorted in descending order!

[Kraeror]

Anybody can help me with this problem?

[Kraeror]

All fixed! I fixed it solo!
Thanks anyway!