[XHunterZ]

make it like anyone can use it(NO ZCMD PLEASE)

[Hansrutger]

At least follow your own signature status and try to learn then. Here you go, since you capsed all in to not use ZCMD, happy holidays!

Код:

CMD:setskin(playerid, params[])
{
	new targetid, skinid;
	if (sscanf(params, "ui", targetid, skinid))
	{
		return SendClientMessage(playerid, 0xFF0000FF, "/setskin");
	}
	SetPlayerSkin(targetid, skinid);
	SendClientMessage(playerid, 0xFFFFFFFF, "You have set someone's skin to something... yay.");
	return 1;
}

Remember to restrict it to the skin id's as well so players can't input more or lower than the allowed skin ID (https://sampwiki.blast.hk/wiki/Skins:All).

[GoldenLion]

Making a command like this without a command processor is a bad idea as you will need to use OnPlayerCommandText (it's slow) and strtok (or you could use strmid if you know the length of the command).

[RyderX]

Zcmd would be easier than strcmp

[SickAttack]

Quote:

Originally Posted by RyderX Zcmd would be easier than strcmp

Only because people use strtok, tmp, idx and all that, using sscanf will make it the same.

[GoldenLion]

Код:

CMD:skin(playerid, params[]) return SetPlayerSkin(playerid, strval(params));

Enjoy.

[Yaa]

strcmp :

PHP код:

new idx;
public OnPlayerCommandText(playerid, cmdtext[])
{
    if (!strcmp("/skin", cmdtext, true) == 0)
    {
        new tmp[256], str[75];
        tmp = strtok (cmdtext, idx);
        if (!strlen(tmp)  return  SendClientMessage(playerid, -1, "USAGE: /skin [Skin Id]");
        SetPlayerSkin(playerid, strval(tmp));
        format(str, sizeof(str), "You have changed your skin to Id : %s", GetPlayerSkin(playerid));
        SendClientMessage(playerid, -1, str);
        return 1;
    }
    return 0;
} 


ZCMD / IZCMD / Pawn:CMD

PHP код:

CMD:skin(playerid, params[])
{
        new str[75];
        if (isnull(params)  return  SendClientMessage(playerid, -1, "USAGE: /skin [Skin Id]");
        SetPlayerSkin(playerid, params);
        format(str, sizeof(str), "You have changed your skin to Id : %s" ,params);
        SendClientMessage(playerid, -1, str);
        return 1;
} 


choose what you want

take care

[RyderX]

ZCMD & Sscanf2 Ways :

PHP код:

CMD:skin(playerid,params[])
{
        new skin;
        if(sscanf(params,"i",skin)) return SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}Usage: /skin (skinid)");
        if(!IsValidSkin(skin)) return SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}Invalid skinID");
        SetPlayerSkin(playerid,skin);
        SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}You've chosen your Custom Skin.");
        return 1;
}
stock IsValidSkin(SkinID)
{
    if((SkinID >= 0 && SkinID <= 2)||(SkinID == 7)||(SkinID >= 9 && SkinID <= 41)||(SkinID >= 43 && SkinID <= 64)||(SkinID >= 66 && SkinID <= 73)||(SkinID >= 75 && SkinID <= 85)||(SkinID >= 87 && SkinID <= 118)||(SkinID >= 120 && SkinID <= 148)||(SkinID >= 150 && SkinID <= 207)||(SkinID >= 209 && SkinID <= 264)||(SkinID >= 274 && SkinID <= 288)||(SkinID >= 290 && SkinID <= 299)) return true;
    else return false;
} 


[GoldenLion]

Quote:

Originally Posted by RyderX ZCMD & Sscanf2 Ways : PHP код: CMD:skin(playerid,params[]) {         new skin;         if(sscanf(params,"i",skin)) return SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}Usage: /skin (skinid)");         if(!IsValidSkin(skin)) return SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}Invalid skinID");         SetPlayerSkin(playerid,skin);         SendClientMessage(playerid,0xF8F8F8FFF,"[SERVER]: {FFFFFF}You've chosen your Custom Skin.");         return 1; } stock IsValidSkin(SkinID) {     if((SkinID >= 0 && SkinID <= 2)||(SkinID == 7)||(SkinID >= 9 && SkinID <= 41)||(SkinID >= 43 && SkinID <= 64)||(SkinID >= 66 && SkinID <= 73)||(SkinID >= 75 && SkinID <= 85)||(SkinID >= 87 && SkinID <= 118)||(SkinID >= 120 && SkinID <= 148)||(SkinID >= 150 && SkinID <= 207)||(SkinID >= 209 && SkinID <= 264)||(SkinID >= 274 && SkinID <= 288)||(SkinID >= 290 && SkinID <= 299)) return true;     else return false; }

First of all you don't need the stock keyword there, second you can simply do

Код:

if (skinid >= 0 && skinid <= 311)

and third you can simply use strval instead of sscanf.

[SickAttack]

Quote:

Originally Posted by GoldenLion Код: if (skinid >= 0 && skinid <= 311)

No, 74 isn't a valid skin.