[lulo356]

I don't know what to do anymore, I tried everything, but i'm getting this error everytime error 029: invalid expression, assumed zero, If i remove this line the textdraw with player is not connected will showup every singel time if you use this command

PHP код:

command(give, playerid, params[])
{
    new Usage[128], id, Value, string[128];
    if(sscanf(params, "uzd", id, Usage, Value))
    {
        SendClientMessage(playerid, WHITE, "SYNTAX: /give [playerid] [usage] [value]");
        SendClientMessage(playerid, GREY, "Usages: Money , Gun");
     }
     else
     {
         if(strlen(Usage) >= 1 && IsPlayerConnectedEx(id))
         {
            if(strcmp(Usage, "Money", true) == 0)
            {
                if(GetDistanceBetweenPlayers(playerid, id) <7)
                {
                      TakePlayerCash(playerid, Value);
                     GivePlayerCash(id, Value);
                     SavePlayerData(id);
                    format(string, sizeof(string), "[%s] [GIVE MONEY] %s gave %s money $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value);
                    RefundLog(string);
                      format(string, sizeof(string), "[%s] [GIVE MONEY] %s gave %s money $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value);
                    RefundLog(string);
                    format(string, sizeof(string), "* %s opned his wallet and gave some money to %s.", RPName(playerid), RPName(id));
                    NearByMessage(playerid, NICESKY, string);
                }
            }
            else
            {
                SCM(playerid, RED, "> You're too far away!");
            }
        }
        else
        {
            RemoveTextMessage(playerid);
            TextDrawShowForPlayer(playerid, Text:PlayerNotConnected);
            SetTimerEx("RemoveTextMessage", 3500, false, "d", playerid);
        }
    }
    else <<<<<<<=== This is the line
    {
        if(strlen(Usage) >= 1 && IsPlayerConnectedEx(id))
        {
            if(strcmp(Usage, "Gun", true) == 0)
            {
                if(GetDistanceBetweenPlayers(playerid, id) <7)
                {
                    new playergun, playerammo;
                    playergun = GetPlayerWeapon(playerid);
                    playerammo = GetPlayerAmmo(playerid);
                    GivePlayerWeapon(id, playergun, playerammo);
                    GivePlayerWeapon(playerid, playergun, -playerammo);
                    format(string, sizeof(string), "* %s handed his weapon over to %s.", RPName(playerid), RPName(id));
                    NearByMessage(playerid, NICESKY, string);
                }
            }
            else
            {
                SCM(playerid, RED, "> You're too far away!");
            }
          }
        else
        {
            RemoveTextMessage(playerid);
            TextDrawShowForPlayer(playerid, Text:PlayerNotConnected);
            SetTimerEx("RemoveTextMessage", 3500, false, "d", playerid);
        }
     }
    return 1;
} 


[feartonyb]

You got alot of problems in your code. I'll fix it for you.

Also, you are using if incorrectly.

This is your order:

Код:

if
{
}
else
{
}
else
{
}

You see the problem here?


Fixed command:

PHP код:

   command(give, playerid, params[]) 
   { 
        new Usage[128], id, Value, string[128]; 
        if(sscanf(params, "uzd", id, Usage, Value)) 
        { 
                SendClientMessage(playerid, WHITE, "SYNTAX: /give [playerid] [usage] [value]"); 
                SendClientMessage(playerid, GREY, "Usages: Money , Gun"); 
        return 1;
         } 
     if(strlen(Usage) >= 1 && IsPlayerConnectedEx(id)) 
     { 
        if(strcmp(Usage, "Money", true) == 0) 
        { 
            if(GetDistanceBetweenPlayers(playerid, id) <7) 
            { 
                  TakePlayerCash(playerid, Value); 
                 GivePlayerCash(id, Value); 
                 SavePlayerData(id); 
                format(string, sizeof(string), "[%s] [GIVE MONEY] %s gave %s money $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value); 
                RefundLog(string); 
                  format(string, sizeof(string), "[%s] [GIVE MONEY] %s gave %s money $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value); 
                RefundLog(string); 
                format(string, sizeof(string), "* %s opned his wallet and gave some money to %s.", RPName(playerid), RPName(id)); 
                NearByMessage(playerid, NICESKY, string); 
            } 
            else 
            { 
                SCM(playerid, RED, "> You're too far away!"); 
            } 
        }
        else if(strcmp(Usage, "Gun", true) == 0) 
        { 
            if(GetDistanceBetweenPlayers(playerid, id) <7) 
            { 
                new playergun, playerammo; 
                playergun = GetPlayerWeapon(playerid); 
                playerammo = GetPlayerAmmo(playerid); 
                GivePlayerWeapon(id, playergun, playerammo); 
                GivePlayerWeapon(playerid, playergun, -playerammo); 
                format(string, sizeof(string), "* %s handed his weapon over to %s.", RPName(playerid), RPName(id)); 
                NearByMessage(playerid, NICESKY, string); 
            } 
            else 
            { 
                SCM(playerid, RED, "> You're too far away!"); 
            } 
        }
        else return SCM(playerid, RED, "> Wrong option chosen!"); 
    } 
    else 
    { 
        RemoveTextMessage(playerid); 
        TextDrawShowForPlayer(playerid, Text:PlayerNotConnected); 
        SetTimerEx("RemoveTextMessage", 3500, false, "d", playerid); 
    } 
        return 1; 
   } 


[lulo356]

Thanks for your advise,

I created this now

PHP код:

command(give, playerid, params[])
{
    new Usage[128], id, Value, string[128];
    if(sscanf(params, "uzd", id, Usage, Value))
    {
        SendClientMessage(playerid, WHITE, "SYNTAX: /give [playerid] [usage] [value]");
        SendClientMessage(playerid, GREY, "Usages: Money , Gun");
     }
     else
     {
         if(strcmp(Usage, "money", true) == 0)
         {
             if(strlen(Usage) >= 1 && IsPlayerConnectedEx(id))
             {
                 if(GetDistanceBetweenPlayers(playerid, id) < 7)
                 {
                    if(Player[playerid][Money] >= Value)
                    {
                        SCM(playerid, RED, "> You don't have enough money");
                    }
                    else
                    {
                        GivePlayerCash(id, Value);
                        TakePlayerCash(playerid, Value);
                        SavePlayerData(id);
                           format(string, sizeof(string), "* %s gave some money out his wallet to %s.", RPName(playerid), RPName(id));
                          NearByMessage(playerid, NICESKY, string);
                        format(string, sizeof(string), "[%s] [MONEY] Player %s has given %s Money to $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value);
                        RefundLog(string);
                        format(string, sizeof(string), "[%s] [MONEY] Player %s has given %s Money to $%d", date(gettime()+3600, 9), RPName(playerid), RPName(id), Value);
                        SendToAdmins(YELLOW, string);
                     }
                }
                else
                {
                    SCM(playerid, RED, "> You're too far away!");
                }
            }
            else
            {
                RemoveTextMessage(playerid);
                TextDrawShowForPlayer(playerid, Text:PlayerNotConnected);
                SetTimerEx("RemoveTextMessage", 3500, false, "d", playerid);
            }
        }
        else 
        {
            if(strcmp(Usage, "Gun", true) == 0)
            {
                if(strlen(Usage) >= 1 && IsPlayerConnectedEx(id))
                {
                    if(GetDistanceBetweenPlayers(playerid, id) <7)
                    {
                        new playergun, playerammo;
                        playergun = GetPlayerWeapon(playerid);
                        playerammo = GetPlayerAmmo(playerid);
                        GivePlayerWeapon(id, playergun, playerammo);
                        GivePlayerWeapon(playerid, playergun, -playerammo);
                        format(string, sizeof(string), "* %s handed his weapon over to %s.", RPName(playerid), RPName(id));
                        NearByMessage(playerid, NICESKY, string);
                     }
                }
                else
                {
                    SCM(playerid, RED, "> You're too far away!");
                }
            }
            else
            {
                RemoveTextMessage(playerid);
                TextDrawShowForPlayer(playerid, Text:PlayerNotConnected);
                SetTimerEx("RemoveTextMessage", 3500, false, "d", playerid);
            }
        }
     }
    return 1;
} 


But there are still some issues, Like

He is not reading this code,

PHP код:

                    if(Player[playerid][Money] >= Value)
                    {
                        SCM(playerid, RED, "> You don't have enough money");
                    } 


And by the weapon it doesn't see if the id is offline, It returns as This player is to far away,

But how can i make the /give [id] gun [value] to /give [id] gun ?

[lulo356]

bump

[Trucido]

Quote:

Originally Posted by lulo356 Код: if(Player[playerid][Money] >= Value) { SCM(playerid, RED, "> You don't have enough money"); }

...........

Код:

   
if(Player[playerid][Money] < Value) return SCM(playerid, RED, "> You don't have enough money");