[KingPersona]

Hello,

i have problem in cmd /factions , when was my srv in 0.3z was work norm, and when i maked it in 0.3.7 and i write cmd /factions i get crash

Code

pawn Код:

stock ShowFactions(playerid)
{
    /*new stringz2[MAX_STRING];*/
    new stringz2[2400];
    if(DynamicFactions[1][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", GetFactionMembers(1), DynamicFactions[1][fMaxMembers], DynamicFactions[1][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"{FFFFFF}[%d/%d] %s\n{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}", GetFactionMembers(1), DynamicFactions[1][fMaxMembers], DynamicFactions[1][fName]);
    }
    if(DynamicFactions[2][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(2), DynamicFactions[2][fMaxMembers], DynamicFactions[2][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(2), DynamicFactions[2][fMaxMembers], DynamicFactions[2][fName]);
    }
    if(DynamicFactions[3][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(3), DynamicFactions[3][fMaxMembers], DynamicFactions[3][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(3), DynamicFactions[3][fMaxMembers], DynamicFactions[3][fName]);
    }
    if(DynamicFactions[4][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(4), DynamicFactions[4][fMaxMembers], DynamicFactions[4][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(4), DynamicFactions[4][fMaxMembers], DynamicFactions[4][fName]);
    }
    if(DynamicFactions[5][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(5), DynamicFactions[5][fMaxMembers], DynamicFactions[5][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(5), DynamicFactions[5][fMaxMembers], DynamicFactions[5][fName]);
    }
    if(DynamicFactions[6][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(6), DynamicFactions[6][fMaxMembers], DynamicFactions[6][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(6), DynamicFactions[6][fMaxMembers], DynamicFactions[6][fName]);
    }
    if(DynamicFactions[8][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(8), DynamicFactions[8][fMaxMembers], DynamicFactions[8][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(8), DynamicFactions[8][fMaxMembers], DynamicFactions[8][fName]);
    }
    if(DynamicFactions[9][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(9), DynamicFactions[9][fMaxMembers], DynamicFactions[9][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(9), DynamicFactions[9][fMaxMembers], DynamicFactions[9][fName]);
    }
    if(DynamicFactions[10][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(10), DynamicFactions[10][fMaxMembers], DynamicFactions[10][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(10), DynamicFactions[10][fMaxMembers], DynamicFactions[10][fName]);
    }
    if(DynamicFactions[11][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(11), DynamicFactions[11][fMaxMembers], DynamicFactions[11][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(11), DynamicFactions[11][fMaxMembers], DynamicFactions[11][fName]);
    }
    if(DynamicFactions[12][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(12), DynamicFactions[12][fMaxMembers], DynamicFactions[12][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(12), DynamicFactions[12][fMaxMembers], DynamicFactions[12][fName]);
    }
    if(DynamicFactions[13][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]\n", stringz2, GetFactionMembers(13), DynamicFactions[13][fMaxMembers], DynamicFactions[13][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}\n", stringz2, GetFactionMembers(13), DynamicFactions[13][fMaxMembers], DynamicFactions[13][fName]);
    }
    if(DynamicFactions[14][fApplication] > 0)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s {00FF00}[applications online]", stringz2, GetFactionMembers(14), DynamicFactions[14][fMaxMembers], DynamicFactions[14][fName]);
    }
    else
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s{FFFFFF}[{FF0000}applications offline{FFFFFF}]{FFFFFF}", stringz2, GetFactionMembers(14), DynamicFactions[14][fMaxMembers], DynamicFactions[14][fName]);
    }
    ShowPlayerDialog(playerid, DIALOG_FACTIONS, DIALOG_STYLE_LIST,"Factions", stringz2, "Select", "Cancel");
    return 1;
}

[Konstantinos]

Client crash? I don't see anything that could cause that and I doubt something in GetFactionMembers would do as well.

Anyway, this can be improved with a loop:

PHP код:

ShowFactions(playerid)
{
    new stringz2[2400];
    for (new i = 1; i != 15; ++i)
    {
        format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s %s\n", stringz2, GetFactionMembers(i), DynamicFactions[i][fMaxMembers], DynamicFactions[i][fName], (DynamicFactions[i][fApplication] > 0) ? ("{00FF00}[applications online]") : ("{FFFFFF}[{FF0000}applications offline{FFFFFF}]"));
    }
    ShowPlayerDialog(playerid, DIALOG_FACTIONS, DIALOG_STYLE_LIST,"Factions", stringz2, "Select", "Cancel");
    return 1;
} 


If the crash has anything to do with the server, load crashdetect plugin.

[KingPersona]

Quote:

Originally Posted by Konstantinos Client crash? I don't see anything that could cause that and I doubt something in GetFactionMembers would do as well. Anyway, this can be improved with a loop: PHP код: ShowFactions(playerid) {     new stringz2[2400];     for (new i = 1; i != 15; ++i)     {         format(stringz2, sizeof(stringz2),"%s{FFFFFF}[%d/%d] %s %s\n", stringz2, GetFactionMembers(i), DynamicFactions[i][fMaxMembers], DynamicFactions[i][fName], (DynamicFactions[i][fApplication] > 0) ? ("{00FF00}[applications online]") : ("{FFFFFF}[{FF0000}applications offline{FFFFFF}]"));     }     ShowPlayerDialog(playerid, DIALOG_FACTIONS, DIALOG_STYLE_LIST,"Factions", stringz2, "Select", "Cancel");     return 1; }  If the crash has anything to do with the server, load crashdetect plugin.

Thanks, Fixed , u are best <3 +rep.