[nezo2001]

i made a rob command and here is the code

PHP код:

CMD:rob(playerid, params[])
{
new targetid;
if(sscanf(params, "u", targetid)) return SendClientMessage(playerid, COLOR_WHITE, "Usage: /rob [id]");
if(!IsPlayerConnected(targetid)) return SendClientMessage(playerid, COLOR_RED, "This player is not connected");
new Float:x, Float:y, Float:z;
new tPos = GetPlayerPos(targetid, x, y, z);
if(!IsPlayerInRangeOfPoint(playerid, 5, x, y, z)) return SendClientMessage(playerid, COLOR_RED, "This player is too far away");
if(GetPlayerMoney(targetid) < 1000) return SendClientMessage(playerid, COLOR_RED, "This player doesn't have enough money");
new money = GetPlayerMoney(targetid);
GivePlayerMoney(playerid, money / 10);
GivePlayerMoney(targetid, -money / 10);
new name[MAX_PLAYER_NAME], string[24+MAX_PLAYER_NAME];
GetPlayerName(playerid, name, sizeof(name));
new name2[MAX_PLAYER_NAME], string1[24+MAX_PLAYER_NAME];
GetPlayerName(targetid, name2, sizeof(name2));
format(string,sizeof(string),"%s has robbed %s",name, name2);
SendClientMessage(playerid, COLOR_SILVER, "You robbed %d", money);
SendClientMessage(targetid, COLOR_SILVER, "You got robbed and lost %d", money/10);
SendClientMessageToAll(COLOR_GREEN,string);
return 1;
} 


It works but when i rob someone i doesn't send the amount of money in the chat it give the player the amount of money but i doesn't do in the chat

[Banana_Ghost]

pawn Код:

CMD:rob(playerid, params[])
{
    new targetid,name[MAX_PLAYER_NAME], name2[MAX_PLAYER_NAME],string[50+MAX_PLAYER_NAME];
    if(sscanf(params, "u", targetid)) return SendClientMessage(playerid, COLOR_WHITE, "Usage: /rob [id]");
    if(!IsPlayerConnected(targetid)) return SendClientMessage(playerid, COLOR_RED, "This player is not connected");
    new Float:x, Float:y, Float:z;
    new tPos = GetPlayerPos(targetid, x, y, z);
    if(!IsPlayerInRangeOfPoint(playerid, 5, x, y, z)) return SendClientMessage(playerid, COLOR_RED, "This player is too far away");
    if(GetPlayerMoney(targetid) < 1000) return SendClientMessage(playerid, COLOR_RED, "This player doesn't have enough money");
    new money = GetPlayerMoney(targetid);
    GivePlayerMoney(playerid, money / 10);
    GivePlayerMoney(targetid, -money / 10);
    GetPlayerName(playerid, name, sizeof(name));
    GetPlayerName(targetid, name2, sizeof(name2));
    format(string,sizeof(string),"%s has robbed %s",name, name2);
    SendClientMessageToAll(COLOR_GREEN,string);
    format(string,sizeof(string),"You robbed $%d", money/10);
    SendClientMessage(playerid,COLOR_SILVER,string);
    format(string,sizeof(string),"You got robbed and lost $%d", money/10);
    SendClientMessage(targetid,COLOR_SILVER,string);
    return 1;
}

try this

[nezo2001]

What is new ?!

[Banana_Ghost]

1. Indentation
2.

pawn Код:

format(string,sizeof(string),"%s has robbed %s",name, name2); 
SendClientMessage(playerid, COLOR_SILVER, "You robbed %d", money); 
SendClientMessage(targetid, COLOR_SILVER, "You got robbed and lost %d", money/10); 
SendClientMessageToAll(COLOR_GREEN,string);

You cannot format a client message, it has been replaced with:

pawn Код:

format(string,sizeof(string),"%s has robbed %s",name, name2);
    SendClientMessageToAll(COLOR_GREEN,string);
    format(string,sizeof(string),"You robbed $%d", money/10);
    SendClientMessage(playerid,COLOR_SILVER,string);
    format(string,sizeof(string),"You got robbed and lost $%d", money/10);
    SendClientMessage(targetid,COLOR_SILVER,string);

3. A little bit of a cleanup.

[nezo2001]

This fromat is for SendClientMessageToAll

[Banana_Ghost]

yes, but you cannot format the SendClientMessage function. You must do the same as you did with SendClientMessageToAll, format the string, then send the string to the player via SendClientMessage(ToAll).

[nezo2001]

Ok thank you but if i used the command many time the samp-server.exe crash and send me a message "The server is restarting" and doesn't do anything

[Banana_Ghost]

pawn Код:

CMD:rob(playerid, params[])
{
    new targetid,name[MAX_PLAYER_NAME], name2[MAX_PLAYER_NAME],string[60],Float:x, Float:y, Float:z;
    if(sscanf(params, "u", targetid)) return SendClientMessage(playerid, COLOR_WHITE, "Usage: /rob [id]");
    if(!IsPlayerConnected(targetid)) return SendClientMessage(playerid, COLOR_RED, "This player is not connected");
    new tPos = GetPlayerPos(targetid, x, y, z);
    if(!IsPlayerInRangeOfPoint(playerid, 5.0, x, y, z)) return SendClientMessage(playerid, COLOR_RED, "This player is too far away");
    if(GetPlayerMoney(targetid) < 1000) return SendClientMessage(playerid, COLOR_RED, "This player doesn't have enough money");
    else
    {
        new money = GetPlayerMoney(targetid);
        GivePlayerMoney(playerid, money / 10);
        GivePlayerMoney(targetid, -money / 10);
        GetPlayerName(playerid, name, sizeof(name));
        GetPlayerName(targetid, name2, sizeof(name2));
        format(string,sizeof(string),"%s has robbed %s",name, name2);
        SendClientMessageToAll(COLOR_GREEN,string);
        format(string,sizeof(string),"You robbed $%d", money/10);
        SendClientMessage(playerid,COLOR_SILVER,string);
        format(string,sizeof(string),"You got robbed and lost $%d", money/10);
        SendClientMessage(targetid,COLOR_SILVER,string);
    }
    return 1;
}

I tend to write commands in that style. Personally, I see nothing wrong, but if something is crashing your server, I recommend using crashdetect https://sampforum.blast.hk/showthread.php?tid=262796 to see what's causing the problem.

[nezo2001]

I didn't use it before how to install it ?

[Banana_Ghost]

download the file, include <crashdetect> in your gamemode and filterscripts (if you have filterscripts), and in server.cfg, load the crashdetect plugin and start the server. If it crashes, check the server log file and paste the results here.