[Opah]

PHP код:

public OnPlayerDeath(playerid, killerid, reason)
{
    if((killerid != playerid) || (killerid = INVALID_PLAYER_ID))
    {
        pInfo[killerid][Kills]++;
        pInfo[playerid][Deaths]++;
    }
    else
    {
        pInfo[playerid][Suicides]++;
    }
    return 1;
} 


no errors or warnings but it doesn't work

[niels44]

pawn Код:

if((killerid != playerid) || (killerid = INVALID_PLAYER_ID))

shouldnt it be:

pawn Код:

if((killerid != playerid) || (killerid != INVALID_PLAYER_ID))

or

pawn Код:

if((killerid != playerid) && (killerid != INVALID_PLAYER_ID))

or with the removed ( and )

pawn Код:

if((killerid != playerid && killerid != INVALID_PLAYER_ID)

??

[Faisal_khan]

Quote:

Originally Posted by ****** It is MUCH simpler to write and read "if" checks with the "true" version first: pawn Код: if((killerid == playerid) || (killerid == INVALID_PLAYER_ID)) {         pInfo[playerid][Suicides]++; } else {         pInfo[killerid][Kills]++;         pInfo[playerid][Deaths]++; }

Yeah I prefer this way. It's much easier, non-confusing and understandable.

[Opah]

still doesn't work

[Faisal_khan]

Try this:

pawn Код:

if((killerid == playerid))
{
        pInfo[playerid][Suicides]++;
}
else
{
        pInfo[killerid][Kills]++;
        pInfo[playerid][Deaths]++;
}

[Opah]

same

[Faisal_khan]

So whats the problem? Is it just adding suicides or only kills and deaths?

[Opah]

the suicides