[NewerthRoleplay]

Hey I'm having a problem that I am able to enter any cop vehicle regardless of what my faction id is even though I have tried many ways to prevent this from happening.

Variable for LSPDVehicles

pawn Код:

new LSPDVehicles[34];

I have added the vehicles like this:

pawn Код:

LSPDVehicles[0] = AddStaticVehicle(596,1535.8279,-1667.0283,13.1042,1.2749,0,1); // //Copcar 1
    LSPDVehicles[1] = AddStaticVehicle(596,1535.7777,-1678.2174,13.1041,359.0435,0,1); // //Copcar 2
    LSPDVehicles[2] = AddStaticVehicle(596,1602.2314,-1688.1366,5.6119,88.9127,0,1); // //Copcar 3
    LSPDVehicles[3] = AddStaticVehicle(596,1602.3998,-1696.2252,5.6117,89.5110,0,1); // //Copcar 4
    LSPDVehicles[4] = AddStaticVehicle(596,1602.2968,-1704.6088,5.6114,89.2925,0,1); // //Copcar 5
    LSPDVehicles[5] = AddStaticVehicle(596,1591.6299,-1711.7292,5.6110,0.5575,0,1); // //Copcar 6
    LSPDVehicles[6] = AddStaticVehicle(596,1583.3506,-1711.8403,5.6123,359.9798,0,1); // //Copcar 7
    LSPDVehicles[7] = AddStaticVehicle(596,1574.4407,-1711.5636,5.6112,0.4981,0,1); // //Copcar 8
    LSPDVehicles[8] = AddStaticVehicle(596,1564.4946,-1711.8907,5.6117,0.0557,0,1); // //Copcar 9
    LSPDVehicles[9] = AddStaticVehicle(597,1602.1552,-1691.9513,5.6600,90.2862,1,0); // //Copcar 10
    LSPDVehicles[10] = AddStaticVehicle(597,1602.1045,-1684.0902,5.6588,89.9887,1,0); // //Copcar 11
    LSPDVehicles[11] = AddStaticVehicle(597,1602.5887,-1700.3116,5.6600,90.1532,1,0); // //Copcar 12
    LSPDVehicles[12] = AddStaticVehicle(597,1595.2753,-1711.4293,5.6598,1.4325,1,93); // //Copcar 13
    LSPDVehicles[13] = AddStaticVehicle(597,1587.3236,-1711.8318,5.6587,359.5460,1,93); // //Copcar 14
    LSPDVehicles[14] = AddStaticVehicle(598,1578.6815,-1712.0513,5.6365,358.1766,1,93); // //Copcar 15
    LSPDVehicles[15] = AddStaticVehicle(598,1570.2655,-1711.8102,5.6356,359.8264,1,93); // //Copcar 16
    LSPDVehicles[16] = AddStaticVehicle(596,1558.4491,-1711.7164,5.6120,0.7168,1,93); // //Copcar 17
    LSPDVehicles[17] = AddStaticVehicle(596,1584.6483,-1671.5382,5.6145,270.2792,1,93); // //Copcar 18
    LSPDVehicles[18] = AddStaticVehicle(596,1584.6222,-1667.4482,5.6145,270.0910,1,93); // //Copcar 19
    LSPDVehicles[19] = AddStaticVehicle(599,1546.2502,-1650.8398,6.0786,90.8912,0,1); // //cop car 20
    LSPDVehicles[20] = AddStaticVehicle(599,1546.8645,-1659.1162,6.0787,90.3100,0,1); // //cop car 21
    LSPDVehicles[21] = AddStaticVehicle(599,1546.6399,-1667.8623,6.0780,90.4493,0,1); // //cop car 22
    LSPDVehicles[22] = AddStaticVehicle(601,1545.8365,-1655.1222,5.6494,89.7686,0,1); // //cop car Swat Tank 23
    LSPDVehicles[23] = AddStaticVehicle(528,1546.2603,-1662.9534,5.9328,89.3495,0,1); // //cop FBI truck(blue one) 24
    LSPDVehicles[24] = AddStaticVehicle(427,1530.1572,-1644.9054,6.0225,179.7986,0,1); // //SWAT Enforcer 25
    LSPDVehicles[25] = AddStaticVehicle(427,1538.6517,-1644.5701,6.0426,180.0564,0,1); // //SWAT Enforcer 26
    LSPDVehicles[26] = AddStaticVehicle(427,1534.6859,-1645.0800,6.0228,178.4550,0,1); // //SWAT Enforcer 27
    LSPDVehicles[27] = AddStaticVehicle(427,1526.0662,-1645.3656,6.0223,180.0917,0,1); // //SWAT Enforcer 28
    LSPDVehicles[28] = AddStaticVehicle(428,570.7433,-1252.2587,17.6663,292.1557,24,1); // //Bank Truck in Rodeo Car 29
    LSPDVehicles[29] = AddStaticVehicle(428,608.0444,-1237.8926,18.4802,111.9092,24,1); // //Bank Truck in Rodeo Car 30
    LSPDVehicles[30] = AddStaticVehicle(426,1543.2870,-1612.4788,13.1262,269.5055,25,25); // //Cop Undercover Car 31
    LSPDVehicles[31] = AddStaticVehicle(426,1543.1644,-1606.7509,13.1253,269.9076,25,25); // //Cop Undercover Car 32
    LSPDVehicles[32] = AddStaticVehicle(421,1555.6886,-1605.9546,13.2653,180.6853,53,53); // //Cop Undercover Car 33
    LSPDVehicles[33] = AddStaticVehicle(421,1561.6571,-1606.0315,13.2653,180.1476,53,53); // //Cop Undercover Car 34

And to stop users from entering a vehicle I used this:

pawn Код:

public OnPlayerEnterVehicle(playerid, vehicleid, ispassenger)
{
    for(new i = 0; i < 35; i++) 
    { 
        if(vehicleid == LSPDVehicles[i])
        { 
            if(pData[playerid][Faction] != 1) 
            { 
                ClearAnimations(playerid); 
                SendClientMessage(playerid, -1, "You don`t have the keys for this car."); 
            } 
        } 
    } 
    return 1;
}

All help is appreciated -Connor

[Varkoll_]

OnPlayerEnterVehicle isn't very effective :/

Try to use OnPlayerState to check if a player enter in a vehicle (newstate == PLAYER_STATE_DRIVER) and put your code.

[Vince]

Your loop is out of bounds. You are accessing index 34 which doesn't exist. Just use the sizeof operator for the upper bound. Also consider adding a break statement.