[iLearner]

Hello,

Recently i've been working on a small function that check if the team which's ID is passed as parameter is full (has more members then others?), but i literally failed as i am really bad at maths, would anyone mind giving me a hand?

This the function that i made which i dont think is good / accurate:

PHP код:

IsTeamFull(TeamID)
{
    new Teams[MAX_TEAMS], bool:rt;
    for(new i =0; i< MAX_PLAYERS; i++)
    {
        for(new k = 0; k < MAX_TEAMS; k++)
        {
             if((GetPlayerTeam(i) == k)
             {
                Teams[k]++;
             }
        }
    }
    for(new i = 0; i< MAX_TEAMS; i++)
    {
        if(Teams[i] < Teams[TeamID])
        {
            rt = true;
        }
        else
        {
            rt = false;
        }
    }
    return rt;
} 


[SyS]

can u explain it bit more. I'm confused whether you want to check the number of members in that team reached maximum or has highest number of members or check it against anyother team's member count.

[TitanX]

PHP код:

if the team which's ID is passed as parameter is full 


you means full team check if it's full ( places on it are full )
or
the largest team on server ( who got the most players on server )

[iLearner]

Simple, got some teams, but sometimes they get overloaded, which means some teams have alot of players in it while other a few, so i was trying to make a function to check if the team is "full" (has more players then others?), so i can prevent them from selecting that team.

[TopShooter2]

He wants to make a team balance to be more clear lol.

[SyS]

PHP код:

IsTeamFull(TeamID) 
{ 
    new Teams[MAX_TEAMS],i,k; 
    for(i =0; i< MAX_PLAYERS; i++) 
            for(k = 0; k < MAX_TEAMS; k++) 
                    if((GetPlayerTeam(i) == k) 
                             Teams[k]++; 
        
    for(i = 0; i< MAX_TEAMS; i++) 
            if(Teams[i] < Teams[TeamID]) 
                    return true; 
               
    return false; 
} 


More effiicient will be storing count upon joining instead of looping and do the last check.

[TitanX]

PHP код:

#define MAX_PLAYERS_IN_TEAM 15
IsTeamFull(TeamID) 
{ 
    new Count, bool:rt; 
    for(new i =0; i< MAX_PLAYERS; i++) 
    { 
        if(GetPlayerTeam(i) == TeamID) 
        { 
            Count++; 
        } 
    } 
    if(Count == MAX_PLAYERS_IN_TEAM)
    { 
        return true;  
    }
    else return false;
}  
IsHightestTeam(TeamID)
{
    new id, output = -1, Teams[MAX_TEAMS], bool:rt;
    for(new i =0; i< MAX_PLAYERS; i++)
    {
        for(new k = 0; k < MAX_TEAMS; k++)
        {
            if(GetPlayerTeam(i) == k)
            {
                Teams[k]++;
            }
        }
    }
    for (new ht; ht != sizeof(Teams); ++ht)
    {
        if (Teams[ht] > output) output = Teams[ht], id = ht;
    }
    
    if(id == TeamID && id != -1)
    {
        return true;
    }
    else return false;
} 


something like that ?

[SyS]

Quote:

Originally Posted by TitanX PHP код: #define MAX_PLAYERS_IN_TEAM 15 IsTeamFull(TeamID)  {      static Count, bool:rt;      for(new i =0; i< MAX_PLAYERS; i++)      {          if(GetPlayerTeam(i) == TeamID)          {              Count++;          }      }      if(Count == MAX_PLAYERS_IN_TEAM)     {          return true;       }     else return false; }  something like that ?

Don't unnecessarily put static key word to every declaration if you actually don't know what it does. Your code wont work as the variable count being a static variable will be stored on data section and will be remembered on each overhead. That means the count variable never be reset.

[TitanX]

Quote:

Originally Posted by Sreyas Don't unnecessarily put static key word to every declaration if you actually don't know what it does. Your code wont work as the variable count being a static variable will be stored on data section and will be remembered on each overhead. That means the count variable never be reset.

forgot dat thing, thanks :P

[Trucido]

Quote:

Originally Posted by iLearner Simple, got some teams, but sometimes they get overloaded, which means some teams have alot of players in it while other a few, so i was trying to make a function to check if the team is "full" (has more players then others?), so i can prevent them from selecting that team.

make a variable for each team or array e.g

Код:

new g_TeamCount[MAX_TEAMS];

each time a person joins

Код:

++g_TeamCount

and each time a person leaves it, do the opposite.

then u can fix ur IsTeamFull easily

Код:

IsTeamFull(teamid)
{
    if ( g_TeamCount[teamid] >= MAX_TEAM_MEMBERS )
	return true;
		
    return false;	
}