[bugmenotlol]

as the title says my command is not working properly.
i had added hours as 3rd part but that is not working it is coming as reason

PHP код:

if(strcmp(cmd, "/ban", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) hours (reason)");
                return 1;
            }
            new giveplayerid;
            new len;
            giveplayerid = ReturnUser(tmp);
            len = strvalEx(tmp);
            if(IsPlayerNPC(giveplayerid)) return 1;
            if(PInfo[playerid][AdminLevel] >= 1)
            {
                if(IsPlayerConnected(giveplayerid))
                {
                    if(giveplayerid != INVALID_PLAYER_ID)
                    {
                        new length = strlen(cmdtext);
                        while ((idx < length) && (cmdtext[idx] <= ' '))
                        {
                            idx++;
                        }
                        new offset = idx;
                        new result[156];
                        while ((idx < length) && ((idx - offset) < (sizeof(result) - 1)))
                        {
                            result[idx - offset] = cmdtext[idx];
                            idx++;
                        }
                        result[idx - offset] = EOS;
                        if(!strlen(result))
                        {
                            SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) (reason)");
                            return 1;
                        }
                        new date,month,year;
                        getdate(date,month,year);
                        new hour,minute,second;
                        gettime(hour,minute,second);
                        format(string, sizeof(string), "Administrator %s has banned %s due to %s",PlayerName(playerid), PlayerName(giveplayerid), (result));
                        SendClientMessageToAll(COLOR_WHITE, string);
                        PInfo[giveplayerid][Banned] = len;
                        GettingBanned[giveplayerid] = 1;
                        new Name[MAX_PLAYER_NAME];
                        new plrIP[25];
                        new query[256];
                        //new date2[128];
                        //format(date2, sizeof(date2), "%d/%d/%d", year,month,date);
                        GetPlayerName(giveplayerid,Name,sizeof(Name));
                        GetPlayerName(playerid,sendername,sizeof(sendername));
                        GetPlayerIp(giveplayerid, plrIP, sizeof(plrIP));
                        mysql_real_escape_string(Name,Name);
                        mysql_real_escape_string((result),(result));
                        mysql_real_escape_string(sendername,sendername);
                        mysql_real_escape_string(plrIP,plrIP);
                        format(query,sizeof(query),"INSERT INTO `bans` (Username, Reason, Administrator, IP, Date, Time) VALUES ('%s','%s','%s','%s','%d/%d/%d','%d:%d:%d')",Name,(result),sendername,plrIP,year,month,date,hour,minute,second);
                        mysql_reconnect();
                        mysql_query(query);
                        AdminLog(playerid, "/ban", (result), Name);
                        Kick(giveplayerid);
                        return 1;
                    }
                }
                else
                {
                    format(string, sizeof(string), "Could not find player (%d)", giveplayerid);
                    SendClientMessage(playerid, COLOR_ERROR, string);
                }
            }
            else
            {
                SendClientMessage(playerid, COLOR_ERROR, "You are not an administrator !");
            }
        }
        return 1;
    }
    
    return SendClientMessage(playerid, COLOR_ERROR, "Unknown command, please type /commands for a list of available commands to use.");
} 


[bugmenotlol]

anyone plz
++rep

[Sew_Sumi]

You would find this a lot easier with sscanf and zcmd... Just saying...


Where'd the code come from, and what have you done to it, as it doesn't seem like it's been copy/pasted/editted correctly.

Here's the reason I say it's copy-pasted... "SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) (reason)");"

That's missing the hour in it's feedback, and thus if you haven't done it correctly throughout the command then it WILL come out with the hour in the reason.

[bugmenotlol]

Quote:

Originally Posted by Sew_Sumi You would find this a lot easier with sscanf and zcmd... Just saying... Where'd the code come from, and what have you done to it, as it doesn't seem like it's been copy/pasted/editted correctly. Here's the reason I say it's copy-pasted... "SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) (reason)");" That's missing the hour in it's feedback, and thus if you haven't done it correctly throughout the command then it WILL come out with the hour in the reason.

Sendclientmessage i had done i thought of editing it after fixing these current bug
Sendclient message also has connection with the command parameters ?

[Sew_Sumi]

I can't even understand that at all...



What I see when I see things like this difference in the SendClientMessage is that you've simply copied that command from elsewhere, and edited it...

The reason you are having the issue if you have done this is because you haven't edited it correctly due to not knowing what you are doing.

[Yaa]

PHP код:

if(strcmp(cmd, "/ban", true) == 0) 
    { 
        if(IsPlayerConnected(playerid)) 
        { 
            tmp = strtok(cmdtext, idx); 
            if(!strlen(tmp)) 
            { 
                SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) hours (reason)"); 
                return 1; 
            } 
            new giveplayerid; 
            new len; 
            giveplayerid = ReturnUser(tmp); 
            len = strvalEx(tmp); 
            if(IsPlayerNPC(giveplayerid)) return 1; 
            if(PInfo[playerid][AdminLevel] >= 1) 
            { 
                if(IsPlayerConnected(giveplayerid)) 
                { 
                    if(giveplayerid != INVALID_PLAYER_ID) 
                    { 
                        new length = strlen(cmdtext); 
                        while ((idx < length) && (cmdtext[idx] <= ' ')) 
                        { 
                            idx++; 
                        } 
                        new offset = idx; 
                        new result[156]; 
                        while ((idx < length) && ((idx - offset) < (sizeof(result) - 1))) 
                        { 
                            result[idx - offset] = cmdtext[idx]; 
                            idx++; 
                        } 
                        result[idx - offset] = EOS; 
                        if(!strlen(result)) 
                        { 
                            SendClientMessage(playerid, COLOR_SECURITY, "Syntax: /ban (id/name) (reason)"); 
                            return 1; 
                        } 
                        new date,month,year; 
                        getdate(date,month,year); 
                        new hour,minute,second; 
                        gettime(hour,minute,second); 
                        PInfo[giveplayerid][Banned] = len; 
                        GettingBanned[giveplayerid] = 1; 
                        new Name[MAX_PLAYER_NAME]; 
                        new plrIP[25]; 
                        new query[256]; 
                        //new date2[128]; 
                        //format(date2, sizeof(date2), "%d/%d/%d", year,month,date); 
                        GetPlayerName(giveplayerid,Name,sizeof(Name)); 
                        GetPlayerName(playerid,sendername,sizeof(sendername)); 
                        GetPlayerIp(giveplayerid, plrIP, sizeof(plrIP)); 
                        mysql_real_escape_string(Name,Name); 
                        mysql_real_escape_string((result),(result)); 
                        mysql_real_escape_string(sendername,sendername); 
                        mysql_real_escape_string(plrIP,plrIP); 
                        format(query,sizeof(query),"INSERT INTO `bans` (Username, Reason, Administrator, IP, Date, Time) VALUES ('%s','%s','%s','%s','%d/%d/%d','%d:%d:%d')",Name,(result),sendername,plrIP,year,month,date,hour,minute,second); 
                        mysql_query(query); 
                        AdminLog(playerid, "/ban", (result), Name); 
                        Kick(giveplayerid); 
                        format(string, sizeof(string), "Administrator %s has banned %s due to %s",PlayerName(playerid), PlayerName(giveplayerid), (result)); 
                        SendClientMessageToAll(COLOR_WHITE, string); 
                        return 1; 
                    } 
                } 
                else 
                { 
                    format(string, sizeof(string), "Could not find player (%d)", giveplayerid); 
                    SendClientMessage(playerid, COLOR_ERROR, string); 
                } 
            } 
            return  SendClientMessage(playerid, COLOR_ERROR, "You are not an administrator !"); 
       } 
       return SendClientMessage(playerid, COLOR_ERROR, "Unknown command, please type /commands for a list of available commands to use."); 
} 


[bugmenotlol]

stilll not working and i dont see any chnages u did to it ....

[Sew_Sumi]

Quote:

Originally Posted by bugmenotlol stilll not working and i dont see any chnages u did to it ....

He does that often.

He's moved the format, and Send Client Message further down, and removed the mysql_reconnect line entirely.

Not saying that it works or that it's good, he's simply bad for pasting up "fixes" that aren't fixes with no explanation.

[Yaa]

Quote:

Originally Posted by bugmenotlol stilll not working and i dont see any chnages u did to it ....

what the problem ?

did players still can join ?

[bugmenotlol]

Quote:

Originally Posted by Yaa what the problem ? did players still can join ?

it is not the problem.
The problem is;
The Syntac should be /ban playername/id hours reason
But it only gives /ban playername/id reason >>> Hours cannot be saved