[SkillNasr]

Skinchange command not working
Im trying to start zcmd, so i did everything but i have 1 warning

Code:

warning 225: unreachable code

Line 11,

Code:

if (dialogid == 1)

. everytime i try it it work but not changing my skin

PHP Code:

#include <a_samp>
#include <a_players>
#include <zcmd>
#pragma tabsize 0
CMD:skin(playerid, listitem, response, dialogid, inputtext[])
        {
         ShowPlayerDialog(playerid, 1, DIALOG_STYLE_INPUT, "Skin Change", "Enter the skin id you wish to have below", "Confirm", "Cancel");
                return 1;
        if (dialogid == 1)
        {
            if(response)
                {
                    new skinid, message[64];
                        skinid = strval(inputtext);
                        if(skinid < 0 || skinid > 299)
                        {
                            SendClientMessage(playerid, 0xFFFFFFFF, "SERVER: Skin id may be between 0 and 299.");
                        }
                        else
                        {
                            SetPlayerSkin(playerid, skinid);
                            format(message, sizeof(message), "SERVER: You have changed your skin id to %d.", skinid);
                            SendClientMessage(playerid, 0xFFFFFFFF, message);
                    }
                }
        }
            return 1;
} 


[Stinged]

https://sampforum.blast.hk/showthread.php?tid=91354

zcmd is a command processor, it's supposed to 2 arguments, which are playerid and params.

What you're doing is showing the player the dialog, and doing what the dialog should do, all inside the command.
You're supposed to code what dialogs do under OnDialogResponse.

[Luicy.]

Here:

PHP Code:

CMD:skin(playerid, listitem, response, dialogid, inputtext[]) 
{ 
    ShowPlayerDialog(playerid, 1, DIALOG_STYLE_INPUT, "Skin Change", "Enter the skin id you wish to have below", "Confirm", "Cancel"); 
    if (dialogid == 1) 
    { 
        if(response) 
        { 
            new skinid, message[64]; 
            skinid = strval(inputtext); 
            if(skinid < 0 || skinid > 299) 
            { 
                SendClientMessage(playerid, 0xFFFFFFFF, "SERVER: Skin id may be between 0 and 299."); 
            } 
            else 
            { 
                SetPlayerSkin(playerid, skinid); 
                format(message, sizeof(message), "SERVER: You have changed your skin id to %d.", skinid); 
                SendClientMessage(playerid, 0xFFFFFFFF, message); 
            } 
        } 
    } 
    return 1; 
} 


You can't return before it's finished, and you used return twice, removed the first return. Now should it be reachable.

Edit:

PHP Code:

CMD:skin(playerid) 
{ 
    ShowPlayerDialog(playerid, 1, DIALOG_STYLE_INPUT, "Skin Change", "Enter the skin id you wish to have below", "Confirm", "Cancel"); 
    return 1; 
}  
public OnDialogResponse(playerid, dialogid, response, listitem, inputtext[])
{
    if(dialogid == 1) 
    { 
        if(response) 
        { 
            new skinid, message[64]; 
            skinid = strval(inputtext); 
            if(skinid < 0 || skinid > 299) 
            { 
                SendClientMessage(playerid, 0xFFFFFFFF, "SERVER: Skin id may be between 0 and 299."); 
            } 
            else 
            { 
                SetPlayerSkin(playerid, skinid); 
                format(message, sizeof(message), "SERVER: You have changed your skin id to %d.", skinid); 
                SendClientMessage(playerid, 0xFFFFFFFF, message); 
            } 
        } 
    }
} 


Read the reply above me.

[SkillNasr]

Quote:

Originally Posted by Stinged https://sampforum.blast.hk/showthread.php?tid=91354 zcmd is a command processor, it's supposed to 2 arguments, which are playerid and params. What you're doing is showing the player the dialog, and doing what the dialog should do, all inside the command. You're supposed to code what dialogs do under OnDialogResponse.

Thanks man i know that i forget something

Quote:

Originally Posted by Meller Here: PHP Code: CMD:skin(playerid, listitem, response, dialogid, inputtext[])  {      ShowPlayerDialog(playerid, 1, DIALOG_STYLE_INPUT, "Skin Change", "Enter the skin id you wish to have below", "Confirm", "Cancel");      if (dialogid == 1)      {          if(response)          {              new skinid, message[64];              skinid = strval(inputtext);              if(skinid < 0 || skinid > 299)              {                  SendClientMessage(playerid, 0xFFFFFFFF, "SERVER: Skin id may be between 0 and 299.");              }              else              {                  SetPlayerSkin(playerid, skinid);                  format(message, sizeof(message), "SERVER: You have changed your skin id to %d.", skinid);                  SendClientMessage(playerid, 0xFFFFFFFF, message);              }          }      }      return 1;  }  You can't return before it's finished, and you used return twice, removed the first return. Now should it be reachable. Edit: PHP Code: CMD:skin(playerid)  {      ShowPlayerDialog(playerid, 1, DIALOG_STYLE_INPUT, "Skin Change", "Enter the skin id you wish to have below", "Confirm", "Cancel");      return 1;  }   public OnDialogResponse(playerid, dialogid, response, listitem, inputtext[]) {     if(dialogid == 1)      {          if(response)          {              new skinid, message[64];              skinid = strval(inputtext);              if(skinid < 0 || skinid > 299)              {                  SendClientMessage(playerid, 0xFFFFFFFF, "SERVER: Skin id may be between 0 and 299.");              }              else              {                  SetPlayerSkin(playerid, skinid);                  format(message, sizeof(message), "SERVER: You have changed your skin id to %d.", skinid);                  SendClientMessage(playerid, 0xFFFFFFFF, message);              }          }      } }  Read the reply above me.

Thanks m8, im gonna be sure to use it next time. im using Dialog atm then gonna update it to Textdraw

[SkillNasr]

But it do nothing as the past one.