1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help

Threaded Mode
OnPlayerKeyStateChange ID0 problem
ayoub001
Little Clucker
**
Posts: 46
Threads: 12
Joined: Jan 2015
Reputation: 0
#1

30.09.2015, 22:17
hi everyone i need hellp im trying to don that when a cop presse ALT <KEY_WALK> the player near of playerid get cuffed and when it pressed again he will be send to jail but it work only on ID:0
please help

PHP код:
//cuff
public :confused:(playerid, newkeys, oldkeys)
{
    new string[128];
    if(newkeys == KEY_WALK)
    {
        for(new i=0;i<MAX_PLAYERS;i++)
        {
            if(CommandsBlocked[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] Your commands are blocked, You cannot use commands.");
                return 1;
            }
            if(InDuel[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use commands while on duel, Use /leave to exit the duel.");
                return 1;
            }
            if(pInfo[playerid][Spawned] != 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You must be alive and spawned in order to be able to use this command.");
                return 1;
            }
            if(IsKidnapped[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You are kidnapped. You cannot use this command.");
                return 1;
            }
            if(IsFrozen[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You have been frozen by a Server Administrator. You cannot use this command.");
                return 1;
            }
            if(AccInfo[i][OnDuty] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use this command on this player because they are in Administrator mode.");
                return 1;
            }
            if(gTeam[playerid] != COP && gTeam[playerid] != ARMY && gTeam[playerid] != CIA && gTeam[playerid] != FBI)
            {
                return 1;
            }
            if(i == playerid)
            {
                return 1;
            }
            if(GetDistanceBetweenPlayers(playerid,i) > 4)
            {
                format(string,sizeof(string),"[ERROR] %s[%d] is too far away. You cannot reach him to place cuffs on him.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(GetPlayerWantedLevel(i) == 0)
            {
                format(string,sizeof(string),"[ERROR] %s[%d] is innocent. use /cuff to place cuffs on him.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(gTeam[i] == COP || gTeam[i] == ARMY || gTeam[i] == CIA || gTeam[i] == FBI)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot cuff other Law Enforcement officers. You might lose your job for that ...");
                return 1;
            }
            if(GetPlayerState(playerid) == PLAYER_STATE_DRIVER || GetPlayerState(playerid) == PLAYER_STATE_PASSENGER)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while in a vehicle. Exit the vehicle first.");
                return 1;
            }
            if(GetPlayerState(i) == PLAYER_STATE_DRIVER || GetPlayerState(i) == PLAYER_STATE_PASSENGER)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while they are in a vehicle. Get them to exit the vehicle first.");
                return 1;
            }
            if(pInfo[i][Spawned] != 1)
            {
                format(string,sizeof(string),"[ERROR] %s(%d) is not spawned. You cannot place cuffs on dead people ..",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(IsFrozen[i] == 1)
            {
                format(string,sizeof(string),"[ERROR] %s(%d) is frozen by a Server Administrator. You cannot place cuffs them.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(IsCuffed[i] == 1 && cuff_arrest_time[i] != 0) return 1;
            
            if(IsCuffed[i] == 1 && cuff_arrest_time[i] == 0)
            {
                    ARREST(playerid,i);
            }
            CUFF(playerid,i);
            
        }
    }
    return 1;
} 
Find
Reply
jihadmeneer
Big Clucker
***
Posts: 69
Threads: 5
Joined: Mar 2014
Reputation: 0
#2

01.10.2015, 08:48
Try this:

https://sampforum.blast.hk/showthread.php?tid=570868

Instead of the normal loop.

And for a more effecient way, you should run the loop the find out the nearest ID(the one you want to cuff/arrest), and after that do all the rest(close the loop before) because your loop is running shitloads of code and it's being returned 1; which is why it stops.
Find
Reply
ayoub001
Little Clucker
**
Posts: 46
Threads: 12
Joined: Jan 2015
Reputation: 0
#3

01.10.2015, 12:35
Quote:
Originally Posted by jihadmeneer
Посмотреть сообщение
Try this:

https://sampforum.blast.hk/showthread.php?tid=570868

Instead of the normal loop.

And for a more effecient way, you should run the loop the find out the nearest ID(the one you want to cuff/arrest), and after that do all the rest(close the loop before) because your loop is running shitloads of code and it's being returned 1; which is why it stops.
tnx for your answer can you show me how
Find
Reply
jlalt
Banned
Posts: 1,266
Threads: 6
Joined: Oct 2014
#4

01.10.2015, 13:00
PHP код:
public :confused:(newkeys, oldkeys)
{
    new string[128];
    if(newkeys == KEY_WALK)
    {
        for(new i=0;i<MAX_PLAYERS;i++)
        {
         for(new playerid;playerid<MAX_PLAYERS;playerid++)
           {
            if(CommandsBlocked[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] Your commands are blocked, You cannot use commands.");
                return 1;
            }
            if(InDuel[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use commands while on duel, Use /leave to exit the duel.");
                return 1;
            }
            if(pInfo[playerid][Spawned] != 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You must be alive and spawned in order to be able to use this command.");
                return 1;
            }
            if(IsKidnapped[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You are kidnapped. You cannot use this command.");
                return 1;
            }
            if(IsFrozen[playerid] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You have been frozen by a Server Administrator. You cannot use this command.");
                return 1;
            }
            if(AccInfo[i][OnDuty] == 1)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use this command on this player because they are in Administrator mode.");
                return 1;
            }
            if(gTeam[playerid] != COP && gTeam[playerid] != ARMY && gTeam[playerid] != CIA && gTeam[playerid] != FBI)
            {
                return 1;
            }
            if(i == playerid)
            {
                return 1;
            }
            if(GetDistanceBetweenPlayers(playerid,i) > 4)
            {
                format(string,sizeof(string),"[ERROR] %s[%d] is too far away. You cannot reach him to place cuffs on him.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(GetPlayerWantedLevel(i) == 0)
            {
                format(string,sizeof(string),"[ERROR] %s[%d] is innocent. use /cuff to place cuffs on him.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(gTeam[i] == COP || gTeam[i] == ARMY || gTeam[i] == CIA || gTeam[i] == FBI)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot cuff other Law Enforcement officers. You might lose your job for that ...");
                return 1;
            }
            if(GetPlayerState(playerid) == PLAYER_STATE_DRIVER || GetPlayerState(playerid) == PLAYER_STATE_PASSENGER)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while in a vehicle. Exit the vehicle first.");
                return 1;
            }
            if(GetPlayerState(i) == PLAYER_STATE_DRIVER || GetPlayerState(i) == PLAYER_STATE_PASSENGER)
            {
                SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while they are in a vehicle. Get them to exit the vehicle first.");
                return 1;
            }
            if(pInfo[i][Spawned] != 1)
            {
                format(string,sizeof(string),"[ERROR] %s(%d) is not spawned. You cannot place cuffs on dead people ..",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(IsFrozen[i] == 1)
            {
                format(string,sizeof(string),"[ERROR] %s(%d) is frozen by a Server Administrator. You cannot place cuffs them.",GetName(i),i);
                SendClientMessage(playerid,COLOR_ERROR,string);
                return 1;
            }
            if(IsCuffed[i] == 1 && cuff_arrest_time[i] != 0) return 1;
            
            if(IsCuffed[i] == 1 && cuff_arrest_time[i] == 0)
            {
                    ARREST(playerid,i);
            }
            CUFF(playerid,i);
            
        }
    }
    return 1;
} 
instead of putting playerid in public try to add >>
PHP код:
for(new playerid;playerid<MAX_PLAYERS;playerid++)
    { 
wish it will work
Find
Reply
Pottus
High-roller
*****
Posts: 4,885
Threads: 57
Joined: Jun 2012
Reputation: 0
#5

01.10.2015, 13:07
I had a good laugh reading the stupidity of the replies you got. You have a lot of code here that does not even belong in a loop and there other issues as well with the logic structure. I won't even begin to explain how out to lunch this code is as it is quite apparent you have not the slightest clue as to what you are doing simply you are using downloaded scripts.
Find
Reply
Kaliber
High-roller
*****
Posts: 1,092
Threads: 4
Joined: Jun 2012
Reputation: 0
#6

01.10.2015, 13:16
Quote:
Originally Posted by Pottus
Посмотреть сообщение
I had a good laugh reading the stupidity of the replies you got. You have a lot of code here that does not even belong in a loop and there other issues as well with the logic structure.
You say it

I am so friendly and solve this "problem" for you


Here you go:

PHP код:
new string[128];
    if(newkeys & KEY_WALK)
    {
        if(CommandsBlocked[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] Your commands are blocked, You cannot use commands.");
        if(InDuel[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use commands while on duel, Use /leave to exit the duel.");
        if(pInfo[playerid][Spawned] != 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You must be alive and spawned in order to be able to use this command.");
        if(IsKidnapped[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You are kidnapped. You cannot use this command.");
        if(IsFrozen[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You have been frozen by a Server Administrator. You cannot use this command.");
        if(AccInfo[i][OnDuty] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use this command on this player because they are in Administrator mode.");
        if(gTeam[playerid] != COP && gTeam[playerid] != ARMY && gTeam[playerid] != CIA && gTeam[playerid] != FBI) return 1;
        new i = GetClosestPlayer(playerid);
        if(i == -1) return 1;
        if(GetDistanceBetweenPlayers(playerid,i) > 4)
        {
            format(string,sizeof(string),"[ERROR] %s[%d] is too far away. You cannot reach him to place cuffs on him.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(GetPlayerWantedLevel(i) == 0)
        {
            format(string,sizeof(string),"[ERROR] %s[%d] is innocent. use /cuff to place cuffs on him.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(gTeam[i] == COP || gTeam[i] == ARMY || gTeam[i] == CIA || gTeam[i] == FBI)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot cuff other Law Enforcement officers. You might lose your job for that ...");
            return 1;
        }
        if(GetPlayerState(playerid) == PLAYER_STATE_DRIVER || GetPlayerState(playerid) == PLAYER_STATE_PASSENGER)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while in a vehicle. Exit the vehicle first.");
            return 1;
        }
        if(GetPlayerState(i) == PLAYER_STATE_DRIVER || GetPlayerState(i) == PLAYER_STATE_PASSENGER)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while they are in a vehicle. Get them to exit the vehicle first.");
            return 1;
        }
        if(pInfo[i][Spawned] != 1)
        {
            format(string,sizeof(string),"[ERROR] %s(%d) is not spawned. You cannot place cuffs on dead people ..",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(IsFrozen[i] == 1)
        {
            format(string,sizeof(string),"[ERROR] %s(%d) is frozen by a Server Administrator. You cannot place cuffs them.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(IsCuffed[i] == 1 && cuff_arrest_time[i] != 0) return 1;
        if(IsCuffed[i] == 1 && cuff_arrest_time[i] == 0)
        {
                ARREST(playerid,i);
        }
        CUFF(playerid,i);
    }
    return 1;
}
stock GetClosestPlayer(playerid) {
    new idx=-1,Float:x,Float:y,Float:z;
    GetPlayerPos(playerid,x,y,z);
    for(new i=GetPlayerPoolSize()+1,Float:tmp,Float:max=3000.0; --i!=-1; ) {
        if(!IsPlayerConnected(i) || IsPlayerNPC(i) || i==playerid) continue;
        tmp = GetPlayerDistanceFromPoint(i,x,y,z);
        if(tmp < max) max=tmp,idx=i;
    }
    return idx;
} 
Find
Reply
Pottus
High-roller
*****
Posts: 4,885
Threads: 57
Joined: Jun 2012
Reputation: 0
#7

01.10.2015, 13:58
That isn't even close to solved.
Find
Reply
ayoub001
Little Clucker
**
Posts: 46
Threads: 12
Joined: Jan 2015
Reputation: 0
#8

01.10.2015, 15:14
Quote:
Originally Posted by Kaliber
Посмотреть сообщение
You say it

I am so friendly and solve this "problem" for you


Here you go:

PHP код:
new string[128];
    if(newkeys & KEY_WALK)
    {
        if(CommandsBlocked[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] Your commands are blocked, You cannot use commands.");
        if(InDuel[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use commands while on duel, Use /leave to exit the duel.");
        if(pInfo[playerid][Spawned] != 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You must be alive and spawned in order to be able to use this command.");
        if(IsKidnapped[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You are kidnapped. You cannot use this command.");
        if(IsFrozen[playerid] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You have been frozen by a Server Administrator. You cannot use this command.");
        if(AccInfo[i][OnDuty] == 1) return SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot use this command on this player because they are in Administrator mode.");
        if(gTeam[playerid] != COP && gTeam[playerid] != ARMY && gTeam[playerid] != CIA && gTeam[playerid] != FBI) return 1;
        new i = GetClosestPlayer(playerid);
        if(i == -1) return 1;
        if(GetDistanceBetweenPlayers(playerid,i) > 4)
        {
            format(string,sizeof(string),"[ERROR] %s[%d] is too far away. You cannot reach him to place cuffs on him.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(GetPlayerWantedLevel(i) == 0)
        {
            format(string,sizeof(string),"[ERROR] %s[%d] is innocent. use /cuff to place cuffs on him.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(gTeam[i] == COP || gTeam[i] == ARMY || gTeam[i] == CIA || gTeam[i] == FBI)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot cuff other Law Enforcement officers. You might lose your job for that ...");
            return 1;
        }
        if(GetPlayerState(playerid) == PLAYER_STATE_DRIVER || GetPlayerState(playerid) == PLAYER_STATE_PASSENGER)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while in a vehicle. Exit the vehicle first.");
            return 1;
        }
        if(GetPlayerState(i) == PLAYER_STATE_DRIVER || GetPlayerState(i) == PLAYER_STATE_PASSENGER)
        {
            SendClientMessage(playerid,COLOR_ERROR,"[ERROR] You cannot place a suspect in cuffs while they are in a vehicle. Get them to exit the vehicle first.");
            return 1;
        }
        if(pInfo[i][Spawned] != 1)
        {
            format(string,sizeof(string),"[ERROR] %s(%d) is not spawned. You cannot place cuffs on dead people ..",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(IsFrozen[i] == 1)
        {
            format(string,sizeof(string),"[ERROR] %s(%d) is frozen by a Server Administrator. You cannot place cuffs them.",GetName(i),i);
            SendClientMessage(playerid,COLOR_ERROR,string);
            return 1;
        }
        if(IsCuffed[i] == 1 && cuff_arrest_time[i] != 0) return 1;
        if(IsCuffed[i] == 1 && cuff_arrest_time[i] == 0)
        {
                ARREST(playerid,i);
        }
        CUFF(playerid,i);
    }
    return 1;
}
stock GetClosestPlayer(playerid) {
    new idx=-1,Float:x,Float:y,Float:z;
    GetPlayerPos(playerid,x,y,z);
    for(new i=GetPlayerPoolSize()+1,Float:tmp,Float:max=3000.0; --i!=-1; ) {
        if(!IsPlayerConnected(i) || IsPlayerNPC(i) || i==playerid) continue;
        tmp = GetPlayerDistanceFromPoint(i,x,y,z);
        if(tmp < max) max=tmp,idx=i;
    }
    return idx;
} 
TNX MEN I fix it

ps: Pottus stop playing script hero help me or shut up
Find
Reply
Mowgli
Huge Clucker
****
Posts: 268
Threads: 60
Joined: Apr 2009
Reputation: 0
#9

01.10.2015, 15:19
Quote:
Originally Posted by Pottus
Посмотреть сообщение
That isn't even close to solved.
What is wrong withe calibers code?

That for loop looks strange to me.
Find
Reply
Kaliber
High-roller
*****
Posts: 1,092
Threads: 4
Joined: Jun 2012
Reputation: 0
#10

01.10.2015, 18:10
Quote:
Originally Posted by Pottus
Посмотреть сообщение
That isn't even close to solved.
As you can see..it's right


Quote:
Originally Posted by Mowgli;
That for loop looks strange to me.
Yeah it looks strange..but, it is very fast & right
Find
Reply
« Next Oldest | Next Newest »


Forum Jump:


Users browsing this thread: 2 Guest(s)
  1. SA-MP Forums Archive
  2. SA-MP Scripting and Plugins
  3. Scripting Help