[chencong]

Furniture System v1.0

Carring the furniture and place it to your house,garden and everywhere

INTRODUCTION
I only help my friend(Jin_Zhi) to release this script to forum. It did not made by me. This is a furniture system, you can create all objects in samp and place it to your house, garden and everywhere, it including save/read/edit system. This script is a part of HCOS(Open Source Project Of HuiCheng Gaming)

SCREENSHOT







HOW TO INSTALL
1. Decompress the packet to your server folder.
2. Open server.cfg, add 'Furniture' to the line of 'filterscripts'.
3. Start samp-server.exe and enter the game, and type that command(see 'HOW TO USE' below).

HOW TO USE
This script have these command to use:

Code:

Y - Control the furniture
Mouse Right - Put down the furniture
/Create - Create a furniture
/Remove - Delete a furniture
/Closest - Get the nearly furniture
All furniture data are save in scriptfiles/Furniture

DOWNLOAD
Link 1: https://sourceforge.net/projects/hco...mp_rafixed.rar [Fixed Rotation Angle Bug]

BUGS
None as of yet, please reply this topic, go to the projects website (http://sourceforget.net/projects/hcos) or go to http://samp.hcyxsq.cn (Page Non-English) to post any you find.

SUPPORT
You can contact me with skype(hcyxsq) , steam(hcyxsq) or E-mail(xghc@foxmail.com).

[FailerZ]

WOW good job

[jakejohnsonusa]

Wow this is awesome!

Nice work- +1.

[JimmyCh]

Nice work, repped.

[LeMoi]

I gotta test it

[Pottus]

I'm looking at the code for this and I don't really like what I'm seeing, DINI and poor dynamic design the system looks pretty good but I would change this up.

1.) Use sqlite - I recommend https://sampforum.blast.hk/showthread.php?tid=303682
2.) Redesign the dynamic element there should be two functions CreateFurniture() DestroyFurniture()
3.) Use y_iterate to create a custom iterator for your furnature array this is a perfect application
4.) Use zcmd having all your commands in one callback is messy (I don't care even if it's one command do it)
5.) y_inline/y_dialog allows you to integrate dialogs directly into functions
(Quick Example)

pawn Code:

else if(Object_Clear_Click == clickedid)
        {
            if(CostumeData[playerid][p_CObjectID][CurrCostumeEditSlot[playerid]] != 0)
            {
                inline Response(pid, dialogid, response, listitem, string:text[])
                {
                    #pragma unused listitem, dialogid, pid, text
                    if(response)
                    {
                        RemoveAttachedObject(playerid, CurrCostumeEditSlot[playerid]);
                        PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cleared object from selected slot");
                    }
                    else PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cancelled clear object");
                }
                Dialog_ShowCallback(playerid, using inline Response, DIALOG_STYLE_MSGBOX, "Costume Editor", "Are you sure you want to clear this object?", "Ok", "Cancel");
            }
        }

Doesn't that look at more natural?

Those are my suggestions, otherwise the coding looks fairly decent but if you can make my proposed improvements the system will be much more extensible if someone decides to implement a custom edit and for your own updates.

[Plix]

Eh .. Nice..

[jin_zhi]

Quote:

Originally Posted by [uL]Pottus I'm looking at the code for this and I don't really like what I'm seeing, DINI and poor dynamic design the system looks pretty good but I would change this up. 1.) Use sqlite - I recommend https://sampforum.blast.hk/showthread.php?tid=303682 2.) Redesign the dynamic element there should be two functions CreateFurniture() DestroyFurniture() 3.) Use y_iterate to create a custom iterator for your furnature array this is a perfect application 4.) Use zcmd having all your commands in one callback is messy (I don't care even if it's one command do it) 5.) y_inline/y_dialog allows you to integrate dialogs directly into functions (Quick Example) pawn Code: else if(Object_Clear_Click == clickedid)         {             if(CostumeData[playerid][p_CObjectID][CurrCostumeEditSlot[playerid]] != 0)             {                 inline Response(pid, dialogid, response, listitem, string:text[])                 {                     #pragma unused listitem, dialogid, pid, text                     if(response)                     {                         RemoveAttachedObject(playerid, CurrCostumeEditSlot[playerid]);                         PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cleared object from selected slot");                     }                     else PlayerTextDrawSetString(playerid, Object_Info_Player[playerid], "Cancelled clear object");                 }                 Dialog_ShowCallback(playerid, using inline Response, DIALOG_STYLE_MSGBOX, "Costume Editor", "Are you sure you want to clear this object?", "Ok", "Cancel");             }         } Doesn't that look at more natural? Those are my suggestions, otherwise the coding looks fairly decent but if you can make my proposed improvements the system will be much more extensible if someone decides to implement a custom edit and for your own updates.

Thanks for your valuable suggestion.

[Pottus]

No problem, it's a good system but the changes I've proposed will make it a much better system

[Krakuski]

I've found a bug, Whenever you close the command prompt, the furniture seems to lose its rotation, I've tried clicking the link, but it doesnt direct me anywhere Sorry.

[TheChimpJr]

Great, however it can be improved.

[FiReMaNStone]

Good Job Try To make the version 1.2

[Jankingston]

good, +rep

[chencong]

Quote:

Originally Posted by Krakuski I've found a bug, Whenever you close the command prompt, the furniture seems to lose its rotation, I've tried clicking the link, but it doesnt direct me anywhere Sorry.

Thanks for your report. now we fixed that bug, download the latest version at: https://sourceforge.net/projects/hco...mp_rafixed.rar

[DouglasRamirez]

There's a problem.

- When I go near it then press "Y" the dialog appears. but when I choose one then press select - Nothing happens... Still the same on the other one.
Please fix this.

[Krakuski]

Quote:

Originally Posted by DouglasRamirez There's a problem. - When I go near it then press "Y" the dialog appears. but when I choose one then press select - Nothing happens... Still the same on the other one. Please fix this.

Go under

pawn Код:

OnPlayerEditDynamicObject

IN your gamemode, and hash out all the codes inside of it, meaning /* in the beginning, and */ at the end. Worked for me

[VinPure]

Nice Script...........

[iBots]

Bug:
when you finish editing the object you made,i mean edit it not lift it ,then you cant press on y again
please fix it

[SWAT4]

i LIKE it HHH nice