Posts: 6,236
Threads: 310
Joined: Jan 2011
Reputation:
0
Ban them? You just send a message, you don't actually ban them.
Also, omit parachutes from checks as they can get them from aircraft:
if(weap > 0 && Weapon[i][weap] == false)
->
if(weap > 0 && weap != WEAPON_PARACHUTE && Weapon[i][weap] == false)
Also you should change
if(GetPlayerState(i) == 1 || GetPlayerState(i) == 2 || GetPlayerState(i) == 3) {
to
if(GetPlayerState(i) >= 1|| GetPlayerState(i) <= 3)
{
A. Move the bracket down to keep your code clean
B. Saved one check
Posts: 1,023
Threads: 50
Joined: Mar 2007
Reputation:
0
It helps if you use the ban function. Although careful with exactly what you do at OnPlayerUpdate. All players call that function, so just do a single check for that specific player, don't loop through all players at OPU. As all players will call it up multiple times a second anyway. So you're just causing lots of checks that just don't need to be done.
Posts: 79
Threads: 0
Joined: Apr 2012
Reputation:
0
ban or kick them then it will stop spamming because they are disconnected
Posts: 2,938
Threads: 162
Joined: May 2010
try this
pawn Код:
public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
if(newkeys & KEY_FIRE)
{
new weap = GetPlayerWeapon(i);
if(weap > 0 && Weapon[i][weap] == false && weap != 46 && weap != 40)
{
if(1 <= GetPlayerState(i) <= 3) {
new msg[128];
new Nam[MAX_PLAYER_NAME];
GetPlayerName(playerid,Nam,sizeof(Nam));
format(msg,sizeof(msg),"ANTI WEAPON HACK: %s has been banned from server for spawning a bad weapon!",Nam);
SendClientMessageToAll(0xFF0000FF,msg);
SendClientMessage(playerid, COLOR_RED, "No Hacking");
SafeRemovePlayerWeapon(playerid, weap);
//ban or warning code here
}
}
}
return 1;
}
stock SafeRemovePlayerWeapon(playerid, ...) {
new iArgs = numargs(), idx, wList[13], wIter;
while(--iArgs)
{
idx = getarg(iArgs);
SetPlayerAmmo(playerid, idx, 0);
wList[wIter] = idx;
wIter++;
}
for(; wIter != 0; wIter--)
{
Weapon[playerid][wList[wIter]] = false;
printf("[System: SafeRemovePlayerWeapon] - Removing Player Weapon: %d - Playerid: %d", wList[wIter], playerid);
wList[wIter] = 0;
}
return 1;
}
Posts: 6,236
Threads: 310
Joined: Jan 2011
Reputation:
0
Anti-cheat stuff under OnPlayerUpdate is a silly thing to do. Just run a loop every 3 seconds or so.
Posts: 2,938
Threads: 162
Joined: May 2010
Quote:
Originally Posted by Scripter12345
How would i do that
Thank You
Please Help Me Please
|
check my post above.. should work else show errors
Quote:
Originally Posted by MP2
Also, omit parachutes from checks as they can get them from aircraft:
|
Also omit denoter, since it's also given by the client.
TBH, I see no point of a timer or any of the sort with a weapon anti-cheat, it's a waste of cpu and what not.
KeyStateChange should work fine, if a player shoots the weapon, remove it. or if you have a OnPlayerWeaponChange or something.
