IsPlayerConnected problem - Printable Version

IsPlayerConnected problem - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: IsPlayerConnected problem (/showthread.php?tid=664164)

IsPlayerConnected problem - polygxn - 20.02.2019

So I have a weird problem with (zcmd?) the IsPlayerConnected function. Here is some code:

PHP код:



CMD:givemoney(playerid, params[])

{

    new

        targetID,

        parameter

    ;


    if(sscanf(params, "ui", targetID, parameter)) return UsageTag(playerid, "/givemoney [ID] [AMOUNT]");

    if(!IsPlayerConnected(targetID)) return ErrorTag(playerid, "The specified player is offline!");

    GivePlayerCash(targetID, parameter);

    return 1;

}

So my problem is when I type a non-connected ID with the command it just returns the unknown command thing. The really strange thing about is that this same exact command is worked before, but since I re-wrote it its just broken. Any suggestions?

Re: IsPlayerConnected problem - Beckett - 20.02.2019

Could you show us the function ErrorTag?

Re: IsPlayerConnected problem - CherryMond - 20.02.2019

Look:

Код:

new 
        targetID, 
        parameter, 
    ;

Delete comma (,)after parameter.

Re: IsPlayerConnected problem - polygxn - 20.02.2019

Sure, here:

PHP код:



stock ErrorTag(playerid, message[])

{

    new string[128];


    format(string, sizeof(string), ""TEXT_RED"[ERROR] "TEXT_WHITE"%s", message);

    SendClientMessage(playerid, RED, string);

    return 1;

}

Quote:

Originally Posted by CherryMond

Look:

Код:

new 
        targetID, 
        parameter, 
    ;

Delete comma (,)after parameter.

Nope, thats not it, I just deleted couple of lines before I posted this code. It would be an error if I complie it but I edited the post.

EDIT:

Here is the full code, I just figured it out its something else in this code even if the IsPlayerConnected line is correct:

PHP код:



CMD:givemoney(playerid, params[])

{

    new

        targetID,

        parameter,

        string[128],

        query[128]

    ;


    if(pData[playerid][pAdmin] < 2) return ErrorTag(playerid, "You have no permission to use this command!");


    if(sscanf(params, "ui", targetID, parameter)) return UsageTag(playerid, "/givemoney [ID] [AMOUNT]");

    if(parameter < 0) return ErrorTag(playerid, "You cant use minus value.");

    if(pData[targetID][pIsLoggedIn] == false) return ErrorTag(playerid, "The selected player is not logged in!");

    if(!IsPlayerConnected(targetID)) return SendClientMessage(playerid, 0xFFFFFF, "Test");


    mysql_format(g_sql, query, sizeof(query), "UPDATE characters SET p_money = '%d' WHERE p_name = '%e'", pData[playerid][pMoney], ReturnName(targetID));

    mysql_tquery(g_sql, query);


    format(string, sizeof(string), "%s gave you $%d", ReturnName(playerid), parameter);

    ServerTag(targetID, string);


    format(string, sizeof(string), "You gave %s $%d", ReturnName(targetID), parameter);

    ServerTag(playerid, string);


    GivePlayerCash(targetID, parameter);

    return 1;

}

EDIT 2:

Its fixed, I just needed to move the IsPlayerConnected line directly below the sscanf one.

Re: IsPlayerConnected problem - Undef1ned - 20.02.2019

mysql_format(g_sql, query, sizeof(query), "UPDATE characters SET p_money = '%d' WHERE p_name = '%e'", pData[playerid][pMoney], ReturnName(targetID));

'pData[playerid][pMoney]' should be 'pData[targetID][pMoney]'

By the way, it should be like this:

PHP код:



pData[targetID][pMoney] += parameter;

ResetPlayerMoney(targetID);

GivePlayerMoney(targetID, pData[targetID][pMoney]);


mysql_format(g_sql, query, sizeof(query), "UPDATE characters SET p_money = '%d' WHERE p_name = '%e'", pData[targetID][pMoney], ReturnName(targetID)); 

    mysql_tquery(g_sql, query);

Re: IsPlayerConnected problem - polygxn - 20.02.2019

Quote:

Originally Posted by Undef1ned

mysql_format(g_sql, query, sizeof(query), "UPDATE characters SET p_money = '%d' WHERE p_name = '%e'", pData[playerid][pMoney], ReturnName(targetID));

'pData[playerid][pMoney]' should be 'pData[targetID][pMoney]'

Oh yeah, thats another problem. Much appreciated haha. Oh and yeah, I just forgot to update the enum, but that one is done already.

Re: IsPlayerConnected problem - AdamsLT - 20.02.2019

Also, the IsPlayerConnected check should be above the pData[targetID][pIsLoggedIn] check, shouldn't it?
Because if you receive an Invalid Player ID with sscanf, then you will have an error when trying to access the array at that invalid index, I believe.

And you should use "r" instead of "u" for sscanf, because "u" also detects NPCs, which you don't want, right?
https://sampforum.blast.hk/showthread.php?tid=570927

Re: IsPlayerConnected problem - polygxn - 20.02.2019

Quote:

Originally Posted by AdamsLT

Also, the IsPlayerConnected check should be above the pData[targetID][pIsLoggedIn] check, shouldn't it?
Because if you receive an Invalid Player ID with sscanf, then you will have an error when trying to access the array at that invalid index, I believe.

And you should use "r" instead of "u" for sscanf, because "u" also detects NPCs, which you don't want, right?
https://sampforum.blast.hk/showthread.php?tid=570927

Yeah, IsPlayerConnected is already directly below the sscanf line, I just figured it out that was the problem. And Im probably not going to use any NPCs in the future but thank you for the useful tip!