SA-MP Forums Archive
strcmp - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: strcmp (/showthread.php?tid=662996)


strcmp - xRadical3 - 18.01.2019

I want if player name is online tarnsfer the cash into player account bank but strcmp not working
why?

Code:
Dialog:DialogATM4(playerid, response, listitem, inputtext[])
{
	if(response)
	{
        new sb_string[256];
        new AmountPool = GetPVarInt(playerid, "atm_cash");
        if(User[playerid][pbank] > AmountPool)
        {
        GetPVarString(playerid, "atm_name_target", sb_string, sizeof(sb_string));
	LOOP(i)
	{
	    if(!strcmp(sb_string, GetName(i), false))
	    { If Online
            SendFormatedMessage(i,-1, "**"orange"Bazikon %s(%i) Moghdare "white"%i$ "orange"Rial Pool Be Hesab Banki Shoma Variz Kard!", GetName(playerid),playerid,AmountPool);
            PlayerPlaySound(i, 1057, 0.0, 0.0, 10.0);
	    User[i][pbank] += AmountPool;
	    }
	    else
	    { If Not Online
            new strb = SQL::GetIntEntryEx(""PLAYERS_TABLE"", "pbank", "username", sb_string);
            new handle = SQL::OpenEx(SQL::UPDATE, ""PLAYERS_TABLE"", "username", sb_string);
            SQL::WriteInt(handle, "pbank", strb+TargetATMCash[playerid]+AmountPool);
            SQL::Close(handle);
	    }
	}
        PlayerPlaySound(playerid, 1057, 0.0, 0.0, 10.0);
	User[playerid][pbank] -= AmountPool;
	SendFormatedMessage(playerid, COLOR_ORANGE,"*Shoma Mablagh %i Pool Be Hesab Banki Bazikon %s Variz Kardid!",AmountPool,sb_string);
	
    } else return Error(playerid, "Shoma In Moghdar Pool Ra Dar Hesab Banki Khod Nadrid!");
    }
    return 1;
}


Re: strcmp - Kaliber - 18.01.2019

Because you have to check all players first.

Use a function like that:

PHP Code:
Dialog:DialogATM4(playerid, response, listitem, inputtext[])
{
    if(!response) return 1;
    new sb_string[256], AmountPool = GetPVarInt(playerid, "atm_cash");
    GetPVarString(playerid, "atm_name_target", sb_string, sizeof(sb_string));
    
    //You should Free the PVar Storage!
    DeletePVar(playerid,"atm_cash");
    DeletePVar(playerid, "atm_name_target");
    
    if(User[playerid][pbank] < AmountPool) return Error(playerid, "Shoma In Moghdar Pool Ra Dar Hesab Banki Khod Nadrid!");
    
    new i = IsPlayerOnline(sb_string);
    if(i!=INVALID_PLAYER_ID)
    { //If Online
        SendFormatedMessage(i,-1, "**"orange"Bazikon %s(%i) Moghdare "white"%i$ "orange"Rial Pool Be Hesab Banki Shoma Variz Kard!", GetName(playerid),playerid,AmountPool);
        PlayerPlaySound(i, 1057, 0.0, 0.0, 10.0);
        User[i][pbank] += AmountPool;
    }
    else
    { //If Not Online
        new strb = SQL::GetIntEntryEx(""PLAYERS_TABLE"", "pbank", "username", sb_string);
        new handle = SQL::OpenEx(SQL::UPDATE, ""PLAYERS_TABLE"", "username", sb_string);
        SQL::WriteInt(handle, "pbank", strb+TargetATMCash[playerid]+AmountPool);
        SQL::Close(handle);
    }
    PlayerPlaySound(playerid, 1057, 0.0, 0.0, 10.0);
    User[playerid][pbank] -= AmountPool;
    SendFormatedMessage(playerid, COLOR_ORANGE,"*Shoma Mablagh %i Pool Be Hesab Banki Bazikon %s Variz Kardid!",AmountPool,sb_string);
    return 1;
}
stock IsPlayerOnline(const name[])
{
    for(new i=GetPlayerPoolSize(); i!=-1; i--)
    {
        if(IsPlayerConnected(i) && !strcmp(name,GetName(i))) return i;
    }
    return INVALID_PLAYER_ID;
} 


Re: strcmp - xRadical3 - 18.01.2019

Quote:
Originally Posted by Kaliber
View Post
Because you have to check all players first.

Use a function like that:

PHP Code:
Dialog:DialogATM4(playerid, response, listitem, inputtext[])
{
    if(!response) return 1;
    new sb_string[256], AmountPool = GetPVarInt(playerid, "atm_cash");
    GetPVarString(playerid, "atm_name_target", sb_string, sizeof(sb_string));
    
    //You should Free the PVar Storage!
    DeletePVar(playerid,"atm_cash");
    DeletePVar(playerid, "atm_name_target");
    
    if(User[playerid][pbank] < AmountPool) return Error(playerid, "Shoma In Moghdar Pool Ra Dar Hesab Banki Khod Nadrid!");
    
    new i = IsPlayerOnline(sb_string);
    if(i!=INVALID_PLAYER_ID)
    { //If Online
        SendFormatedMessage(i,-1, "**"orange"Bazikon %s(%i) Moghdare "white"%i$ "orange"Rial Pool Be Hesab Banki Shoma Variz Kard!", GetName(playerid),playerid,AmountPool);
        PlayerPlaySound(i, 1057, 0.0, 0.0, 10.0);
        User[i][pbank] += AmountPool;
    }
    else
    { //If Not Online
        new strb = SQL::GetIntEntryEx(""PLAYERS_TABLE"", "pbank", "username", sb_string);
        new handle = SQL::OpenEx(SQL::UPDATE, ""PLAYERS_TABLE"", "username", sb_string);
        SQL::WriteInt(handle, "pbank", strb+TargetATMCash[playerid]+AmountPool);
        SQL::Close(handle);
    }
    PlayerPlaySound(playerid, 1057, 0.0, 0.0, 10.0);
    User[playerid][pbank] -= AmountPool;
    SendFormatedMessage(playerid, COLOR_ORANGE,"*Shoma Mablagh %i Pool Be Hesab Banki Bazikon %s Variz Kardid!",AmountPool,sb_string);
    return 1;
}
stock IsPlayerOnline(const name[])
{
    for(new i=GetPlayerPoolSize(); i!=-1; i--)
    {
        if(IsPlayerConnected(i) && !strcmp(name,GetName(i))) return i;
    }
    return INVALID_PLAYER_ID;
} 
Tnx
+rep