SA-MP Forums Archive
Bug in bank system - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Bug in bank system (/showthread.php?tid=660404)


Bug in bank system - mmlinaric - 02.11.2018

So, my problem is that players can withdraw as much money as they want.
PHP Code:
CMD:deposit(playerid,params[])
{
    if(IsPlayerInRangeOfPoint(playerid,50.0,2315.952880,-1.618174,26.742187))
    {
        new money,string[128];
        if(sscanf(params,"d",money)) return SendClientMessage(playerid,COLOR_RED,"Komanda: /deposit [novac]");
        if(GetPlayerMoney(playerid) <= money) return SendClientMessage(playerid,COLOR_RED,"Vi nemate toliko novca!");
        new money1 = money;
        PlayerInfo[playerid][pBankmoney] += money;
        format(string,sizeof(string),"Stavili ste $%d u banku. Sada imate $%d.",money1,PlayerInfo[playerid][pBankmoney]);
        SendClientMessage(playerid,COLOR_GREEN,string);
        GivePlayerMoney(playerid,-money);
        return 1;
    }
    else
    {
        SendClientMessage(playerid,COLOR_RED,"Morate biti u banci da bi ste depositali novac!");
    }
    return 1;
}
CMD:withdraw(playerid,params[])
{
    if(IsPlayerInRangeOfPoint(playerid,50.0,2315.952880,-1.618174,26.742187))
    {
        new money,string[128];
        if(sscanf(params,"i",money)) return SendClientMessage(playerid,COLOR_RED,"Komanda: /withdraw [novac]");
        if(GetPlayerMoney(playerid) <= money) return SendClientMessage(playerid,COLOR_RED,"Vi nemate toliko novca u banci!");
        new money1 = money;
        PlayerInfo[playerid][pBankmoney] -= money;
        format(string,sizeof(string),"Uzeli ste $%d iz banke. Sada imate $%d.",money1,PlayerInfo[playerid][pBankmoney]);
        SendClientMessage(playerid,COLOR_GREEN,string);
        GivePlayerMoney(playerid,money);
        return 1;
    }
    else
    {
        SendClientMessage(playerid,COLOR_RED,"Morate biti u banci da bi ste uzeli novac!");
    }
    return 1;
} 
Sorry, but script is on croatian .
Thanks, Mario M.

Re: Bug in bank system - TheToretto - 02.11.2018

Add a limitation:

pawn Code:
if(money < minvalue  || money > maxvalue)
replace minvalue & maxvalue by integers.