Clan command shows ID 0 instead of anything else

Clan command shows ID 0 instead of anything else - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Clan command shows ID 0 instead of anything else (/showthread.php?tid=660009)

Clan command shows ID 0 instead of anything else - solstice_ - 22.10.2018

Hello, so I've been trying to re-create a clan system, and I'm facing an error...

Here's the code:

PHP код:



CMD:createclan(cmdid, playerid, params[])

{

    if(!UserStats[playerid][Clan])

    {

        new clanname[32], query[300];

        if(sscanf(params, "s[32]", clanname)) return SendClientMessage(playerid, COLOR_RED, "[USAGE]: /createclan [clanname]");

        mysql_format(Database, query, sizeof(query), "SELECT * FROM `clans` WHERE `ClanName` = '%e'", clanname);

        new Cache:result = mysql_query(Database, query);

        if(cache_num_rows())

        {

            SendClientMessageEx(playerid, COLOR_RED, "[ERROR]: Clan name ''%s'' already exists. Pick another name.", clanname);

        }

        else

        {

            mysql_format(Database, query, sizeof(query), "INSERT INTO `clans` (`ClanName`, `ClanLeader`, `Official`) VALUES ('%e', '%e', '0')", clanname, GetName(playerid));

            mysql_tquery(Database, query);


            UserStats[playerid][Clan] = cache_insert_id();

            new clanid = UserStats[playerid][Clan];

            ClanInfo[clanid][ClanID] = clanid;

            ClanInfo[clanid][ClanName] = clanname;

            ClanInfo[clanid][ClanLeader] = GetName(playerid);

            ClanInfo[clanid][Official] = 0;

            cache_delete(result);

        }

    }

    else

    {

        SendClientMessage(playerid, COLOR_RED, "[ERROR]: You already own a clan.");

    }

    return 1;

}

And then when I do /myclan ingame

PHP код:



CMD:myclan(cmdid, playerid, params[])

{

    if(!UserStats[playerid][Clan])

    {

        SendClientMessage(playerid, COLOR_WHITE, "You are not in a clan.");

    }

    else

    {

        SendClientMessageEx(playerid, COLOR_WHITE, "Your current clan ID is: %d", UserStats[playerid][Clan]);

    }

    return 1;

}

It just shows Your current clan ID is: 0 while it should be 1 or 2..

Re: Clan command shows ID 0 instead of anything else - d1git - 22.10.2018

I recommend using threaded queries, you weren't storing the query cache result, therefore it returned 0 when you called cache_insert_id();

PHP код:



mysql_tquery(Database, query, "query_insertIntoClans", "d..", playerid);


forward query_insertIntoClans(playerid, ..);

public query_insertIntoClans(playerid, ..) {

    UserStats[playerid][Clan] = cache_insert_id();


    return 1;

}

Re: Clan command shows ID 0 instead of anything else - solstice_ - 22.10.2018

Quote:

Originally Posted by ******

What is `SendClientMessageEx`? The fact that it shows `0` in an `else` branch that just checked it wasn't 0 implies something else is going on.

It's like formatting a string and sending the message to a player, it's just made by Emmet like that

Re: Clan command shows ID 0 instead of anything else - Calisthenics - 22.10.2018

The problem is no active cache. You need to retrieve insert id in a specified callback of `mysql_tquery` function.

Extra notes:

pawn Код:

mysql_format(Database, query, sizeof(query), "SELECT * FROM `clans` WHERE `ClanName` = '%e'", clanname);

Why do you select everything? A better method would be using COUNT(*) which returns 1 row and 1 column (0 or 1 in your case). An even better method is just 1 INSERT query.

Set `ClanName` column as UNIQUE KEY. Now you execute normally your query with `IGNORE` keyword:

pawn Код:

mysql_format(Database, query, sizeof(query), "INSERT IGNORE INTO `clans` (`ClanName`, `ClanLeader`, `Official`) VALUES ('%e', '%e', '0')", clanname, GetName(playerid)); 
mysql_tquery(Database, query, "OnClanCreate", "ds", playerid, clanname);

You can set `Official` as default value 0 in table structure too.

It will execute the query and affected rows will be:
0) a clan with this name exists
1) all is OK, new row was inserted.

pawn Код:

forward OnClanCreate(playerid, clanname[]);
public OnClanCreate(playerid, clanname[])
{
    if (cache_affected_rows())
    {
        new clanid = UserStats[playerid][Clan] = cache_insert_id(); 
        ...
    }
    else
    {
        SendClientMessageEx(playerid, COLOR_RED, "[ERROR]: Clan name ''%s'' already exists. Pick another name.", clanname); 
    }
}

Do not copy strings directly like this:

pawn Код:

ClanInfo[clanid][ClanName] = clanname; 
ClanInfo[clanid][ClanLeader] = GetName(playerid);

use `strcpy` macro.

Re: Clan command shows ID 0 instead of anything else - solstice_ - 22.10.2018

Hello, thanks to everyone who replied above. I've fixed the issue I had, but now I ran into some other problem.

So, this:

PHP код:



forward OnClanCreate(playerid, clanname[]);

public OnClanCreate(playerid, clanname[])

{

    if(cache_affected_rows())

    {

        new clanid = UserStats[playerid][Clan] = cache_insert_id();

        ClanInfo[clanid][ClanID] = clanid;

        ClanInfo[clanid][ClanName] = clanname;

        ClanInfo[clanid][ClanLeader] = GetName(playerid);

        ClanInfo[clanid][Official] = 0;

        SendClientMessageEx(playerid, COLOR_RED, "[SUCCESS]: (Unofficial) Clan ID %d with the name %s has been created.", clanid, clanname);

    }

    else

    {

        SendClientMessageEx(playerid, COLOR_RED, "[ERROR]: Clan name ''%s'' already exists. Pick another name.", clanname);

    }

    return 1;

}

Line:

PHP код:



ClanInfo[clanid][ClanName] = clanname;

PHP код:



error 047: array sizes do not match, or destination array is too small

Re: Clan command shows ID 0 instead of anything else - Calisthenics - 22.10.2018

I did mention about it in my post:

Quote:

Originally Posted by Calisthenics

Do not copy strings directly like this:

pawn Код:

ClanInfo[clanid][ClanName] = clanname; 
ClanInfo[clanid][ClanLeader] = GetName(playerid);

use `strcpy` macro.

Re: Clan command shows ID 0 instead of anything else - solstice_ - 22.10.2018

Never used strcpy before, can you give me an example to that?

Re: Clan command shows ID 0 instead of anything else - solstice_ - 23.10.2018

Ok, I've added this on my script:

PHP код:



stock strcpy(dest[], const source[], maxlength=sizeof dest)

{

    strcat((dest[0] = EOS, dest), source, maxlength);

}

Now, how would I use it?

pawn Код:

forward OnClanCreate(playerid, clanname[]);
public OnClanCreate(playerid, clanname[])
{
    if(cache_affected_rows())
    {
        new clanid = UserStats[playerid][Clan] = cache_insert_id();
        ClanInfo[clanid][ClanID] = clanid;
        strcpy(clanname, sizeof, clanname))
        ClanInfo[clanid][ClanLeader] = GetName(playerid);
        ClanInfo[clanid][Official] = 0;
        SendClientMessageEx(playerid, COLOR_RED, "[SUCCESS]: (Unofficial) Clan ID %d with the name %s has been created.", clanid, clanname);
    }
    else
    {
        SendClientMessageEx(playerid, COLOR_RED, "[ERROR]: Clan name ''%s'' already exists. Pick another name.", clanname);
    }
    return 1;
}

PHP код:



strcpy(clanname, sizeof, clanname))

or?

Re: Clan command shows ID 0 instead of anything else - Calisthenics - 23.10.2018

Make it a macro:

pawn Код:

#if !defined strcpy
    #define strcpy(%0,%1) strcat((%0[0] = '\0', %0), %1)
#endif

First parameter is the destination string which is `ClanInfo[clanid][ClanName]`
Second parameter is the source which is `clanname`
Third parameter is the length which is optional unless it is an enum-array.

pawn Код:

strcpy(ClanInfo[clanid][ClanName], clanname, 32);

Re: Clan command shows ID 0 instead of anything else - solstice_ - 23.10.2018

Quote:

Originally Posted by Calisthenics

Make it a macro:

pawn Код:

#if !defined strcpy
    #define strcpy(%0,%1) strcat((%0[0] = '\0', %0), %1)
#endif

pawn Код:

strcpy(ClanInfo[clanid][ClanName], clanname, 32);

Alright now everything is fine, thanks to you and everyone else.