MySQL not inserting entries - Printable Version

MySQL not inserting entries - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: MySQL not inserting entries (/showthread.php?tid=658370)

MySQL not inserting entries [RESOLVED] - Aerotactics - 02.09.2018

I have a valid connection to the host, but the query isn't writing entries.

EDIT: Thanks for the support to a new MySQL user. These are the right questions:

Quote:

Originally Posted by Calisthenics

Is mysql_log enabled? The query can fail if the rest of the columns you did not specify in the query do not have a default value. Have you tried executing the query you printed for debug purposes earlier in phpMyAdmin and see the results there?

EDIT: A per-player salt is a better idea.

Short Answer: Integers require a default value.

Code:

Dialog:DIALOG_REGISTER(playerid, response, listitem, inputtext[])
{
	if(!response) return Kick(playerid);
	new passhash[257];
	SHA256_PassHash(inputtext, #SALT, passhash, sizeof passhash);
	pInfo[playerid][Password] = passhash;
	new query[256];
	mysql_format(gSQL, query, sizeof query, "INSERT INTO `users` (`Name`, `Password`, `IP`) VALUES ('%s', '%s', '%s')", pName[playerid], passhash, pInfo[playerid][IP]);
	mysql_tquery(gSQL, query, "OnPlayerRegister", "i", playerid);
	Dialog_Show(playerid, DIALOG_LOGIN, DIALOG_STYLE_PASSWORD, "alone", "Please enter your password.", "Enter", "Exit");
	return 1;
}

function OnPlayerRegister(playerid)
{
	pInfo[playerid][SQLID] = cache_insert_id();
	return 1;
}

Re: MySQL not inserting entries - Stormalle - 02.09.2018

HTML Code:

Dialog:DIALOG_REGISTER(playerid, response, listitem, inputtext[])
{
	if(!response) return Kick(playerid);
	new passhash[257];
	SHA256_PassHash(inputtext, #SALT, passhash, sizeof passhash);
	pInfo[playerid][Password] = passhash;
	new query[256];
	format(query, sizeof(query), "INSERT INTO `users` (`Password`, `Name`, `IP`) VALUES ('%s', '%s', '%s')", passhash, pName[playerid], pInfo[playerid][IP]);
	gSQL = mysql_tquery(gSQL, query, "OnPlayerRegister", "i", playerid);
	Dialog_Show(playerid, DIALOG_LOGIN, DIALOG_STYLE_PASSWORD, "alone", "Please enter your password.", "Enter", "Exit");
	return 1;
}

maybe try this

Re: MySQL not inserting entries - Shinja - 02.09.2018

Quote:

Originally Posted by Stormalle

HTML Code:

Dialog:DIALOG_REGISTER(playerid, response, listitem, inputtext[])
{
	if(!response) return Kick(playerid);
	new passhash[257];
	SHA256_PassHash(inputtext, #SALT, passhash, sizeof passhash);
	pInfo[playerid][Password] = passhash;
	new query[256];
	format(query, sizeof(query), "INSERT INTO `users` (`Password`, `Name`, `IP`) VALUES ('%s', '%s', '%s')", passhash, pName[playerid], pInfo[playerid][IP]);
	gSQL = mysql_tquery(gSQL, query, "OnPlayerRegister", "i", playerid);
	Dialog_Show(playerid, DIALOG_LOGIN, DIALOG_STYLE_PASSWORD, "alone", "Please enter your password.", "Enter", "Exit");
	return 1;
}

maybe try this

Dafak?

1.Print the query after formating it and check (debug)
2.Does OnPlayerRegister get called? (you can check with debug)
3.Check mysql_logs for any errors

Re: MySQL not inserting entries - Aerotactics - 03.09.2018

Quote:

Originally Posted by Shinja

Dafak?

1.Print the query after formating it and check (debug)
2.Does OnPlayerRegister get called? (you can check with debug)
3.Check mysql_logs for any errors

1 and 2, you're right, I should debug.

3) I cant find the logs in PHPMyAdmin

EDIT: OnPlayerRegister is not getting called.

Re: MySQL not inserting entries - solstice_ - 03.09.2018

Quote:

Originally Posted by Aerotactics

3) I cant find the logs in PHPMyAdmin

You can find the logs in logs/plugins/mysql_log.txt

Re: MySQL not inserting entries - Aerotactics - 03.09.2018

Quote:

Originally Posted by willbedie

You can find the logs in logs/plugins/mysql_log.txt

Found it, no errors.

EDIT:
Here's the SAMP Output: [20:10:29] INSERT INTO `users` (`Name`, `Password`, `IP`) VALUES ('Aero', 'SNIP', '127.0.0.1')

And here's the latest MySQL entry: 2018-08-05T05:27:01.398735Z 0 [Warning] InnoDB: New log files created, LSN=2551175

Re: MySQL not inserting entries - solstice_ - 03.09.2018

Have you tried debugging them?

EDIT: Try to debug them, here's an example:

PHP Code:



function OnPlayerRegister(playerid)

{

    pInfo[playerid][SQLID] = cache_insert_id();

     print("OnPlayerRegister has been called");

    return 1;

}

Re: MySQL not inserting entries - Aerotactics - 03.09.2018

Quote:

Originally Posted by willbedie

Have you tried debugging them?

EDIT: Try to debug them, here's an example:

PHP Code:



function OnPlayerRegister(playerid)

{

    pInfo[playerid][SQLID] = cache_insert_id();

     print("OnPlayerRegister has been called");

    return 1;

}

Yes, and the callback was not called. I even put in a static query to test if it would callback then and it didn't.

Re: MySQL not inserting entries - Zeth - 03.09.2018

escape the string! Use '%e' instead of '%s'

Re: MySQL not inserting entries - Calisthenics - 03.09.2018

Is mysql_log enabled? The query can fail if the rest of the columns you did not specify in the query do not have a default value. Have you tried executing the query you printed for debug purposes earlier in phpMyAdmin and see the results there?

EDIT: A per-player salt is a better idea.

Re: MySQL not inserting entries - Shinja - 03.09.2018

Escape the strings, golden rule

PHP код:



mysql_format(gSQL, query, sizeof query, "INSERT INTO `users` (`Name`, `Password`, `IP`) VALUES ('%e', '%e', '%e')", pName[playerid], passhash, pInfo[playerid][IP]);

If it doesnt work yet, try again with mysql_log(ALL)