SA-MP Forums Archive
Vehicle doesn't spawn - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Vehicle doesn't spawn (/showthread.php?tid=650152)


Vehicle doesn't spawn - IndependentGaming - 21.02.2018

Hello, I have been trying to make a copy of my /veh command but then with the mselection this is the /veh cmd:


PHP код:
CMD:veh(playerid, params[]) {
    if(PlayerInfo[playerid][pAdmin] >= 4) {
        new
            iVehicle,
            iColors[2];
        if(sscanf(params, "iii", iVehicle, iColors[0], iColors[1])) {
            SendClientMessageEx(playerid, COLOR_GREY, "USAGE: /veh [model ID] [color 1] [color 2]");
        }
        else if(!(400 <= iVehicle <= 611)) {
            SendClientMessageEx(playerid, COLOR_GRAD2, "Invalid model specified (model IDs start at 400, and end at 611).");
        }
        else if(IsATrain(iVehicle)) {
            SendClientMessageEx(playerid, COLOR_GREY, "Trains cannot be spawned during runtime.");
        }
        else if(!(0 <= iColors[0] <= 255 && 0 <= iColors[1] <= 255)) {
            SendClientMessageEx(playerid, COLOR_GRAD2, "Invalid color specified (IDs start at 0, and end at 255).");
        }
        else for(new iIterator; iIterator < sizeof(CreatedCars); iIterator++) if(iIterator >= 49) {
            return SendClientMessageEx(playerid, COLOR_GRAD1, "The maximum limit of 50 spawned vehicles has been reached.");
        }
        else if(CreatedCars[iIterator] == INVALID_VEHICLE_ID) {
            new
                Float: fVehPos[4];
            new fVW = GetPlayerVirtualWorld(playerid);
            GetPlayerPos(playerid, fVehPos[0], fVehPos[1], fVehPos[2]);
            GetPlayerFacingAngle(playerid, fVehPos[3]);
            CreatedCars[iIterator] = CreateVehicle(iVehicle, fVehPos[0], fVehPos[1], fVehPos[2], fVehPos[3], iColors[0], iColors[1], -1);
            VehicleFuel[CreatedCars[iIterator]] = 100.0;
            Vehicle_ResetData(CreatedCars[iIterator]);
            LinkVehicleToInterior(CreatedCars[iIterator], GetPlayerInterior(playerid));
            SetVehicleVirtualWorld(CreatedCars[iIterator], fVW);
            return SendClientMessageEx(playerid, COLOR_GREY, "Vehicle spawned!");
        }
    }
    else SendClientMessageEx(playerid, COLOR_GRAD1, "You are not authorized to use that command.");
    return 1;
}] 
This is the list to spawn it with the MSelection as you can see I masked things with numbers to see how far it comes in the console, it doesn't go further then number 2


PHP код:
if(listid == AdminCarList)
    {
        new
            iVehicle,
            iColors[2];
        if(IsATrain(iVehicle)) {
            SendClientMessageEx(playerid, COLOR_GREY, "Trains cannot be spawned during runtime.");
        }
        else for(new iIterator; iIterator < sizeof(CreatedCars); iIterator++) if(iIterator >= 49) {
            return SendClientMessageEx(playerid, COLOR_GRAD1, "The maximum limit of 50 spawned vehicles has been reached.");
        }
        else if(CreatedCars[iIterator] == INVALID_VEHICLE_ID) {
            new
                Float: fVehPos[4];
            //new iVehicle[MAX_PLAYERS];
            print("1");
            new fVW = GetPlayerVirtualWorld(playerid);
            GetPlayerPos(playerid, fVehPos[0], fVehPos[1], fVehPos[2]);
            GetPlayerFacingAngle(playerid, fVehPos[3]);
            CreatedCars[iIterator] = CreateVehicle(iVehicle, fVehPos[0], fVehPos[1], fVehPos[2], fVehPos[3], iColors[0], iColors[1], -1);
            print("2");
            VehicleFuel[CreatedCars[iIterator]] = 100.0;
            Vehicle_ResetData(CreatedCars[iIterator]);
            print("3");
            LinkVehicleToInterior(CreatedCars[iIterator], GetPlayerInterior(playerid));
            print("4");
            SetVehicleVirtualWorld(CreatedCars[iIterator], fVW);
            return SendClientMessage(playerid, 0xFF0000FF, "Admin vehicle spawned");
        }
        else SendClientMessage(playerid, 0xFF0000FF, "Canceled Admin vehicle selection");
        return 1;
    } 


Re: Vehicle doesn't spawn - Kaperstone - 21.02.2018

1. use fVehPosX fVehPosY etc. it is faster than multi dimensional.
2. Can you post the code of Vehicle_ResetData or have you checked the logs with the crashdetect plugin?

Re: Vehicle doesn't spawn - IndependentGaming - 21.02.2018

Quote:
Originally Posted by Kaperstone
Посмотреть сообщение
1. use fVehPosX fVehPosY etc. it is faster than multi dimensional.
2. Can you post the code of Vehicle_ResetData or have you checked the logs with the crashdetect plugin?
This is the Vehicle_ResetData and about the FVehpos I just keep it like this for now just need this to work so vehicles spawn
PHP код:
Vehicle_ResetData(iVehicleID) {
    if(GetVehicleModel(iVehicleID)) {
        for(new cv = 0; cv < 6; cv++)
        {
            CrateVehicleLoad[iVehicleID][vCrateID][cv] = -1;
        }
        Vehicle_Armor(iVehicleID);
        LockStatus{iVehicleID} = 0;
        VehicleStatus{iVehicleID} = 0;
        arr_Engine{iVehicleID} = 0;
        stationidv[iVehicleID][0] = 0;
        TruckContents{iVehicleID} = 0;
        TruckDeliveringTo[iVehicleID] = INVALID_BUSINESS_ID;
        VehicleFuel[iVehicleID] = 100.0;
        if(LockStatus{iVehicleID}) {
            foreach(new i: Player)
            {
                if(PlayerInfo[i][pLockCar] == iVehicleID) {
                    PlayerInfo[i][pLockCar] = INVALID_VEHICLE_ID;
                }
            }
        }
        if(VehicleBomb{iVehicleID} == 1) {
            foreach(new i: Player)
            {
                if(PlacedVehicleBomb[i] == iVehicleID) {
                    VehicleBomb{iVehicleID} = 0;
                    PlacedVehicleBomb[i] = INVALID_VEHICLE_ID;
                    PickUpC4(i);
                    PlayerInfo[i][pC4Used] = 0;
                    PlayerInfo[i][pC4Get] = 1;
                }
            }
        }
    }
} 


Re: Vehicle doesn't spawn - IndependentGaming - 22.02.2018

Anyone ?

Re: Vehicle doesn't spawn - AstroPoid - 22.02.2018

Код:
        else if(CreatedCars[iIterator] == INVALID_VEHICLE_ID) { 

            new 
                Float: fVehPos[4]; 
            //new iVehicle[MAX_PLAYERS]; 
            print("1"); 
            new fVW = GetPlayerVirtualWorld(playerid); 
            GetPlayerPos(playerid, fVehPos[0], fVehPos[1], fVehPos[2]); 
            GetPlayerFacingAngle(playerid, fVehPos[3]); 
            CreatedCars[iIterator] = CreateVehicle(iVehicle, fVehPos[0], fVehPos[1], fVehPos[2], fVehPos[3], iColors[0], iColors[1], -1); 
            print("2"); 
            VehicleFuel[CreatedCars[iIterator]] = 100.0; 
            Vehicle_ResetData(CreatedCars[iIterator]); 
            print("3"); 
            LinkVehicleToInterior(CreatedCars[iIterator], GetPlayerInterior(playerid)); 
            print("4"); 
            SetVehicleVirtualWorld(CreatedCars[iIterator], fVW); 
            return SendClientMessage(playerid, 0xFF0000FF, "Admin vehicle spawned");  //Here
        }
may i ask you why you are using return ?

Re: Vehicle doesn't spawn - AstroPoid - 22.02.2018

From my silly experince.
Don't return break all incoming values and cancel all perivous action? unless you didn't control it with conditional (if)
may i ask you to try it without if it works ?

Re: Vehicle doesn't spawn - NaS - 22.02.2018

Quote:
Originally Posted by AstroPoid
Посмотреть сообщение
From my silly experince.
Don't return break all incoming values and cancel all perivous action? unless you didn't control it with conditional (if)
may i ask you to try it without if it works ?
The return does not make any difference here. It's at the very end of the block and the other block cannot be executed even if it continues to run (the else cannot execute, since the if did execute).

Furthermore, a return does stop the current function from executing but it does NOT cancel any previous actions. That's impossible.

Also, OP said it didn't run further than print("2"), then how would the return play a role?

If code does not continue to run without the use of return, break or continue (which were not used anywhere near the print "2") there are most likely only 2 causes:

- An error that stops the execution for good reasons (most likely Array index out of bounds)
- An Infinite Loop

Since there is no loop, you must look for an error.
If you have crashdetect, see crashs.log. If you don't, install it and you will see where and what error occured.

Re: Vehicle doesn't spawn - Mugala - 22.02.2018

are u using SA:MP 0.3.DL or 0.3.8?
try to debug this vehicle's ID, Coordinates and Virtual World when the code ends.

Re: Vehicle doesn't spawn - IndependentGaming - 22.02.2018

Im not using 0.3.8 and as for the crash log there is nothing in there

Re: Vehicle doesn't spawn - IndependentGaming - 22.02.2018

Thing is I just want this to work because otherwise i'm unable to /destroycars and some functions are coming out of /veh and made a new command so admins see the MSelection menu to spawn cars insteat of /veh [VEHID] [Col1][Col2]