SA-MP Forums Archive
Code not loading - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Code not loading (/showthread.php?tid=649918)


Code not loading - Jokers98s - 17.02.2018

When i use /pl i could see the stats of myself but i cant see it... and when i use /pl [id] i can see others but still cant see mine..

Plz check the code and plz help to rewrite it ? plz
PHP код:
CMD:pl(playerid, params[])
{
    new ofplayerid;
    if(IsNumeric1(params))
    {
        ofplayerid = strval(params);
        if(!IsPlayerConnected(ofplayerid)) return SendClientMessage(playerid,COLOR_RED,"[Error] Player Not Connected");
    }
    else
    {
        ofplayerid = INVALID_PLAYER_ID;
        SendClientMessage(playerid,COLOR_RED,"[Error] Not an valid player");
    }
    if(    IsPlayerConnected(ofplayerid) && ofplayerid != playerid)
    {
           //destroy all labels first
        for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
        {
            DestroyPlayerLabel(playerid, i);
        }
        CreatePlayerLabel(playerid, ofplayerid);
        g_LABEL_MODE[playerid] = MODE_SINGLE_PLAYER;//enable labels
    }
    else
    {
        if(g_LABEL_MODE[playerid] == MODE_DISABLED)//enable labels
        {
            for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
            {
                if(IsPlayerConnected(i))
                {
                    if(i != ofplayerid)
                       {
                        CreatePlayerLabel(playerid, i);
                    }
                }
            }
            g_LABEL_MODE[playerid] = MODE_ENABLED;
        }
        else//disable labels
        {
            for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
            {
                DestroyPlayerLabel(playerid, i);
            }
            g_LABEL_MODE[playerid] = MODE_DISABLED;
        }
    }
    return 1;
} 


Re: Code not loading - Dayrion - 17.02.2018

Why don't you use sscanf to extract player id instead of IsNumeric?

Re: Code not loading - Jokers98s - 17.02.2018

Rewrite-d still not showing own pl stats..

Quote:

CMDl(playerid, params[])
{
new targetid = playerid;
if(!sscanf(params, "u", targetid))
{
if(targetid == INVALID_PLAYER_ID) return SendClientMessage(playerid, COLOR_RED, "ERROR: "COL_GREY"Player is not connected.");
if(IsPlayerConnected(targetid) && targetid != playerid)
{
for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
{
DestroyPlayerLabel(playerid, i);
}
CreatePlayerLabel(playerid, targetid);
g_LABEL_MODE[playerid] = MODE_SINGLE_PLAYER;
}
}
else
{
SendClientMessage(playerid, COLOR_BLUE, "* /pl [ID] to view another player's pl.");
targetid = playerid;
if(g_LABEL_MODE[playerid] == MODE_DISABLED)
{
CreatePlayerLabel(playerid, targetid);
g_LABEL_MODE[playerid] = MODE_ENABLED;
}
else
{
for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
{
DestroyPlayerLabel(playerid, i);
}
g_LABEL_MODE[playerid] = MODE_DISABLED;
}
}
return 1;
}


Re: Code not loading - Abagail - 17.02.2018

What is CreatePlayerLabel doing? You cannot see 3D text labels attached to yourself.

Re: Code not loading - Mugala - 17.02.2018

dude, u're using this if(IsPlayerConnected(ofplayerid) && ofplayerid != playerid)
remove && ofplayerid != playerid <-- from code.
use this if(IsPlayerConnected(ofplayerid))

Re: Code not loading - Dayrion - 18.02.2018

There you code wrote more cleanly

PHP код:
CMD:pl(playerid, params[]) 
{ 
    new ofplayerid; 
    if(sscanf(params, "u", ofplayerid))
        return SendClientMessage(playerid,COLOR_RED,"[Error] Player Not Connected");      
    if(!IsPlayerConnected(ofplayerid))
        return SendClientMessage(playerid,COLOR_RED,"[Error] Not an valid player");
    if(ofplayerid == playerid)
    {
        if(g_LABEL_MODE[playerid] == MODE_DISABLED)//enable labels 
        { 
            for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++) 
            { 
                if(IsPlayerConnected(i)) 
                { 
                    if(i != ofplayerid) 
                    { 
                        CreatePlayerLabel(playerid, i); 
                    } 
                } 
            } 
            g_LABEL_MODE[playerid] = MODE_ENABLED; 
        } 
        else//disable labels 
        { 
            for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++) 
            { 
                DestroyPlayerLabel(playerid, i); 
            } 
            g_LABEL_MODE[playerid] = MODE_DISABLED; 
        }     
    }
    else
    {
        //destroy all labels first 
        for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++) 
        { 
            DestroyPlayerLabel(playerid, i); 
        } 
        CreatePlayerLabel(playerid, ofplayerid); 
        g_LABEL_MODE[playerid] = MODE_SINGLE_PLAYER;//enable labels 
    }
    return 1;
} 


Re: Code not loading - DobbysGamertag - 18.02.2018

Just a couple of things Dayrion, IsPlayerConnected(); is useless since it checks players connected.

Re: Code not loading - Dayrion - 18.02.2018

Quote:
Originally Posted by DobbysGamertag
Посмотреть сообщение
Just a couple of things Dayrion, IsPlayerConnected(); is useless since it checks players connected.
What check if is the player is connected?