SA-MP Forums Archive
OnPlayerWeaponShot when shooting a driver/passenger - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP (https://sampforum.blast.hk/forumdisplay.php?fid=3)
+--- Forum: Bug Reports (https://sampforum.blast.hk/forumdisplay.php?fid=20)
+--- Thread: OnPlayerWeaponShot when shooting a driver/passenger (/showthread.php?tid=647818)


OnPlayerWeaponShot when shooting a driver/passenger - IstuntmanI - 11.01.2018

If you are on foot and you shoot a driver/passenger in a vehicle (and damaging him) OnPlayerWeaponShot will only be called with hittype = BULLET_HIT_TYPE_VEHICLE with the hitid = player's vehicleid. The vehicle isn't actually shot at all and it isn't receiving damage and the driver/passenger is actually getting damage. In the "worst case" OnPlayerWeaponShot should be called twice: once for the vehicle and once for the damaged player.

I tried to find if this was already reported, but only the one about driveby-ing without calling the callback was reported.

Re: OnPlayerWeaponShot when shooting a driver/passenger - Paglia - 20.01.2018

I don't know if this will be of much help but it may be somewhat related to this issue.

When a player is on foot, then CPlayer* points to the player itself. However, when a player is on a vehicle, CPlayer* points to the vehicle the player is driving.

I suspect that this goes on in samp too, and that's why the hittype is BULLET_HIT_TYPE_VEHICLE and the hitid = player's vehicleid.

(Guess as to what happens below)
The game checks for the CPlayer * directly to see what the player id's is (keep in mind that in samp the player pointer points to the first element, the id) to see what the player id is, and since that player is in a vehicle, then the hitid becomes that vehicle's id, and therefore the type is assigned BULLET_HIT_TYPE_VEHICLE.

(A possible fix?)
In that part of the code where the callback is evaluated, there should be some check to see if the dereferenced CPlayer* points to the actual player in question. Perhaps this can be done by checking one of the "unique" members for each "object" and to determine that way if the dereferenced object in question is either a car or a player.

I apologize for my confusing input, but this hopefully gives idea on how to go in the right direction to solve this.

Re: OnPlayerWeaponShot when shooting a driver/passenger - Gammix - 22.01.2018

This actually might mess up libraries using OnPlayerWeaponShot, specifically anticheats.

Re: OnPlayerWeaponShot when shooting a driver/passenger - RogueDrifter - 22.01.2018

Quote:
Originally Posted by Gammix
View Post
This actually might mess up libraries using OnPlayerWeaponShot, specifically anticheats.
You can check for hittype 2 and loop through all players if GetPlayerVehicleID(i) = hitid (hitid = vehicle id that was hit) (i = the player picked out the loop) then set a variable to mark that the player riding this vehicle got his vehicle shot and never use it in any other way because what he stated above will fuck it, so you need to detect shots shot for players driving under hittype 2 and a loop, then detect shots shot only for onfoot players (separating them via using GetPlayerState) not sure if u understand me but i used that on my in-process anti gm i'll release soon and i didnt get false positive for the matter that was stated above.

Re: OnPlayerWeaponShot when shooting a driver/passenger - Gammix - 26.01.2018

Quote:
Originally Posted by RogueDrifter
View Post
You can check for hittype 2 and loop through all players if GetPlayerVehicleID(i) = hitid (hitid = vehicle id that was hit) (i = the player picked out the loop) then set a variable to mark that the player riding this vehicle got his vehicle shot and never use it in any other way because what he stated above will fuck it, so you need to detect shots shot for players driving under hittype 2 and a loop, then detect shots shot only for onfoot players (separating them via using GetPlayerState) not sure if u understand me but i used that on my in-process anti gm i'll release soon and i didnt get false positive for the matter that was stated above.


Re: OnPlayerWeaponShot when shooting a driver/passenger - RogueDrifter - 27.01.2018

Quote:
Originally Posted by Gammix
View Post
lmao, what i meant was, his problem is when a player is shot in a vehicle only hittype 2 is called, so what i was saying is why's that a problem when you can loop on hittype 2 for the driver of hitid (vehicle id) right? like this:
PHP Code:
public OnPlayerWeaponShot(playerid, weaponid, hittype, hitid, Float:fX, Float:fY, Float:fZ)
{
    switch(hittype)
    {
        case 1:
        {
            if(GetPlayerState(playerid) == 1)
            {
                //player hit on foot.
                }
            }
        case 2:
        {
            for(new i, j = GetPlayerPoolSize(); i <= j; i++)
            {
                if(!IsPlayerConnected(i) || GetPlayerState(i) == 1) continue;
                if(GetPlayerVehicleID(i) == hitid && GetPlayerState(i) ==2)
                {
                    //driver of the vehicle that was hit by another player is 'i'
                    }
                if(GetPlayerVehicleID(i) == hitid && GetPlayerState(i) ==3)
                {
                    //passenger of the vehicle shot
                    }
                }
            }
        }
    return 1;
} 


Re: OnPlayerWeaponShot when shooting a driver/passenger - Gammix - 27.01.2018

Quote:
Originally Posted by RogueDrifter
View Post
lmao, what i meant was, his problem is when a player is shot in a vehicle only hittype 2 is called, so what i was saying is why's that a problem when you can loop on hittype 2 for the driver of hitid (vehicle id) right? like this:
PHP Code:
public OnPlayerWeaponShot(playerid, weaponid, hittype, hitid, Float:fX, Float:fY, Float:fZ)
{
    switch(hittype)
    {
        case 1:
        {
            if(GetPlayerState(playerid) == 1)
            {
                //player hit on foot.
                }
            }
        case 2:
        {
            for(new i, j = GetPlayerPoolSize(); i <= j; i++)
            {
                if(!IsPlayerConnected(i) || GetPlayerState(i) == 1) continue;
                if(GetPlayerVehicleID(i) == hitid && GetPlayerState(i) ==2)
                {
                    //driver of the vehicle that was hit by another player is 'i'
                    }
                if(GetPlayerVehicleID(i) == hitid && GetPlayerState(i) ==3)
                {
                    //passenger of the vehicle shot
                    }
                }
            }
        }
    return 1;
} 


Re: OnPlayerWeaponShot when shooting a driver/passenger - RogueDrifter - 05.02.2018

I've made a fix for this: LINK