function:OnVehicleUpdate()
{
new
Float:vehicle_health
;
for (new i = 1, j = GetVehiclePoolSize(); i <= j; i++)
for (new q = 0; i < sizeof dmv_vehicles; i++)
{
GetVehicleHealth(i, vehicle_health);
if(i == dmv_vehicles[q])
{
if(vehicle_health <= 850)
{
new playerid = CheckDriver(i);
StopDriverstest(playerid);
SCM(playerid, -1, "You're too reckless! You failed your driversexam.");
}
return 1;
}
if(vehicle_health <= 300)
{
SetVehicleHealth(i, 300);
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
if(VehicleInfo[i][eVehicleFuel] <= 0)
{
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
}
return 1;
}
for (new q = 0; i < sizeof dmv_vehicles; i++)
if(vehicle_health <= 850)
{
new playerid = CheckDriver(i);
StopDriverstest(playerid);
SCM(playerid, -1, "You're too reckless! You failed your driversexam.");
}
return 1;
CheckDriver(q);
for (new i = 1, j = GetVehiclePoolSize(); i <= j; i++)
{
GetVehicleHealth(i, vehicle_health);
if(vehicle_health <= 300)
{
SetVehicleHealth(i, 300);
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
if(VehicleInfo[i][eVehicleFuel] <= 0)
{
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
for (new q = 0; q < sizeof dmv_vehicles; q++)
{
if(i == dmv_vehicles[q])
{
if(vehicle_health <= 850)
{
new playerid = CheckDriver(i);
StopDriverstest(playerid);
SCM(playerid, -1, "You're too reckless! You failed your driversexam.");
}
break;
}
}
}
|
The return always stops the whole function on the first time a DMV vehicle was found (including the outer loop which should not be stopped).
Furthermore you can optimize this a lot by moving the health checks on non-DMV vehicles out of the second loop. Код:
for (new i = 1, j = GetVehiclePoolSize(); i <= j; i++)
{
GetVehicleHealth(i, vehicle_health);
if(vehicle_health <= 300)
{
SetVehicleHealth(i, 300);
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
if(VehicleInfo[i][eVehicleFuel] <= 0)
{
ToggleVehicleEngine(i, false); VehicleInfo[i][eVehicleEngineStatus] = false;
}
for (new q = 0; q < sizeof dmv_vehicles; q++)
{
if(i == dmv_vehicles[q])
{
if(vehicle_health <= 850)
{
new playerid = CheckDriver(i);
StopDriverstest(playerid);
SCM(playerid, -1, "You're too reckless! You failed your driversexam.");
}
break;
}
}
}
|