Why wont this work?? - Printable Version

Why wont this work?? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Why wont this work?? (/showthread.php?tid=642466)

Why wont this work?? - 1fret - 01.10.2017

Could someone tell me whats the issue here? cause Im working on a project for someone and he gave me this gamemode to edit etc... When i do /osetrank , it sends me the error message of what i should input, so thats sign that its working. Now when i do the full command, /osetrank Amanda_Clarke Test it sends me a message say the command doesnt exist

PHP код:



COMMAND:osetrank(playerid, params[])

{

    if(PlayerInfo[playerid][ranklvl] != 0) return SendClientError(playerid, CANT_USE_CMD);

    if(PlayerInfo[playerid][playerteam] == CIV) return SendClientError(playerid, CANT_USE_CMD);

    new iPlayer[ MAX_PLAYER_NAME ], iRank[64];

    if( sscanf ( params, "ss", iPlayer, iRank) || strlen(params) > MAX_PLAYER_NAME) return SCP(playerid, "[Exact Name] [rankname]");

    if(AccountExist(iPlayer) == false) return SendClientError(playerid, "Account hasn't been found!");

    if(GetPlayerFaction(playerid) != GetPlayerFaction(iPlayer)) return SendClientError(playerid, "Not in the same faction!");

    if(strfind(iRank, "'", true) != -1 || strfind(iRank, "=", true) != -1 || strfind(iRank, "|", true) != -1 || strlen(iRank) >= 64)

    {

        return SendClientError(playerid, "Invalid character(s) used (~,=,|)");

    }

    myStrcpy(PlayerInfo[iPlayer][rankname], iRank);

    format(iStr, sizeof(iStr), "10[RANK] %s has offline set the rank of %s to %s", PlayerName(playerid), PlayerName(iPlayer), iRank);

    iEcho(iStr);

    format(iStr, sizeof(iStr), "# [%s] %s has offline set the rank of %s to %s.", GetPlayerFactionName(playerid), RPName(playerid), RPName(iPlayer), iRank);

    SendClientMessageToTeam(PlayerInfo[iPlayer][playerteam],iStr,COLOR_PLAYER_VLIGHTBLUE);

    return 1;

}

Re: Why wont this work?? - SyS - 01.10.2017

Код:

myStrcpy(PlayerInfo[iPlayer][rankname], iRank);

That should be playerid instead of iPlayer string right ?

Re: Why wont this work?? - biker122 - 01.10.2017

You're completely using a string in the place of integral values (i.e.)PlayerInfo enumeration and GetPlayerFaction functions.
To set rank of an offline player (or who's not connected in your words), you have to edit the PLAYER FILE (.ini in case of INI file systems, or the database table in case of MySQL). A integer holder cannot hold a string.

Re: Why wont this work?? - 1fret - 01.10.2017

Quote:

Originally Posted by SyS

Код:

myStrcpy(PlayerInfo[iPlayer][rankname], iRank);

That should be playerid instead of iPlayer string right ?

But wouldn't that edit the rank of the player thats using the command , instead of the player thats offline, cause im a bit sure it would

Re: Why wont this work?? - Marricio - 01.10.2017

Quote:

Originally Posted by 1fret

But wouldn't that edit the rank of the player thats using the command , instead of the player thats offline, cause im a bit sure it would

Why are you trying to change a variable of a disconnected player in first place? That's not the point of the command. If you want to edit data from a disconnected player you should modify his user file data, not a server variable.

Re: Why wont this work?? - whadez - 01.10.2017

if( sscanf ( params, "s["MAX_PLAYER_NAME"]s[64]", iPlayer, iRank)