Incompatibility at OnPlayerDeath - Printable Version
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Incompatibility at OnPlayerDeath (/showthread.php?tid=639714)
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Incompatibility at OnPlayerDeath (/showthread.php?tid=639714)
Incompatibility at OnPlayerDeath - ByMatt20030 - 21.08.2017
Codes:
Code in my gamemode:
Код:
public OnVehicleDeath(vehicleid, killerid)
{
printf("%s destroyed", VehicleNames[VehicleModel[vehicleid]-400]);
if(IsValidVehicle(vehicleid))
{
new Nombre[24], Dueno;
for(new i = 0, j = GetPlayerPoolSize(); i <= j; i++)
{
GetPlayerName(i, Nombre, sizeof(Nombre));
if(GetPlayerVehicleAccess(i, vehicleid))
{
Dueno = i;
}
}
SFM(Dueno, COLOR_WHITE, "Your %s were destroyed. The goberment sent it to it's parking, but not at all repaired.", VehicleNames[VehicleModel[vehicleid]-400]);
vHealth[vehicleid] = 500.0;
}
return 1;
}
Код:
public OnVehicleDeath(vehicleid, killerid)
{
CheatVehicleInfo[vehicleid][elc_vX]=0;
#if defined INCLUDE_BASE_MODE
return CallLocalFunction("ELC_AC_OnVehicleDeath", "dd",vehicleid, killerid);
#else
return 1;
#endif
}
/*----------------------------------------------------------------------------*/
#if defined INCLUDE_BASE_MODE
//ALS_SYSTEME --------------------
#if defined _ALS_OnVehicleDeath
#undef OnVehicleDeath
#else
#define _ALS_OnVehicleDeath
#endif
#define OnVehicleDeath ELC_AC_OnVehicleDeath
forward ELC_AC_OnVehicleDeath(vehicleid, killerid);
#endif
Код:
[17:19:28] [debug] Run time error 4: "Array index out of bounds" [17:19:28] [debug] AMX backtrace: [17:19:28] [debug] #0 00066214 in public ELC_AC_OnVehicleDeath (vehicleid=12, killerid=0) at F:\Users\ByMatt20030\Desktop\San Jose\Scrath-RP 0.0.20\gamemodes\S-RP_Traducida.pwn:1390 [17:19:28] [debug] #1 native CallLocalFunction () from samp-server.exe [17:19:28] [debug] #2 00059df4 in public OnVehicleDeath (vehicleid=12, killerid=0) at F:\Users\ByMatt20030\Desktop\San Jose\Scrath-RP 0.0.20\pawno\include\ELC_AC_BASE.inc:1186
Re: Incompatibility at OnPlayerDeath - Jefff - 21.08.2017
line 1390 is ?
Re: Incompatibility at OnPlayerDeath - ByMatt20030 - 21.08.2017
Quote:
|
Originally Posted by Jefff
 line 1390 is ?
|
Код:
return CallLocalFunction("ELC_AC_OnVehicleDeath", "dd",vehicleid, killerid);
Re: Incompatibility at OnPlayerDeath - Jefff - 21.08.2017
gamemodes\S-RP_Traducida.pwn:1390
Re: Incompatibility at OnPlayerDeath - ByMatt20030 - 21.08.2017
Quote:
|
Originally Posted by Jefff
gamemodes\S-RP_Traducida.pwn:1390
|
Closed.
Re: Incompatibility at OnPlayerDeath - Sew_Sumi - 22.08.2017
Код:
SFM(Dueno, COLOR_WHITE, "Your %s were destroyed. The goberment sent it to it's parking, but not at all repaired.", VehicleNames[VehicleModel[vehicleid]-400]);
It could cause trouble in the future. If anything, that line, should be 'in' the loop, so if the car isn't owned by anyone it won't fire. That, or have a check to ensure that if the player isn't found, then it won't fire, such as setting Dueno to -1, and checking if it's not -1 before making the announcement.
Re: Incompatibility at OnPlayerDeath - ByMatt20030 - 22.08.2017
Quote:
|
Originally Posted by Sew_Sumi
Код:
SFM(Dueno, COLOR_WHITE, "Your %s were destroyed. The goberment sent it to it's parking, but not at all repaired.", VehicleNames[VehicleModel[vehicleid]-400]); It could cause trouble in the future. If anything, that line, should be 'in' the loop, so if the car isn't owned by anyone it won't fire. That, or have a check to ensure that if the player isn't found, then it won't fire, such as setting Dueno to -1, and checking if it's not -1 before making the announcement. |
After deleting the printf, i have problem with that line. I did just what you said.
Ty
Re: Incompatibility at OnPlayerDeath - TheCman - 22.08.2017
ByMatt20030, I use ELC too (unfortunately... gonna switch to NEX ASAP as I spend too much time patching the terrible thing than coding useful stuff), you might want to be careful about the systematic use of "return CallLocalFunction" in this script, it might prevent some client updates from being made (like OnVehicleMod). I replaced some of those with successive CallLocalFunction then return 1; to fix the issues.
EDIT: IIRC there might be a better way with some function that finds if symbols are declared or something, but that might be a bit more advanced and if you don't plan to prevent the updates in your FS anyways it's not necessary.