SA-MP Forums Archive
warning 209: function "S@@_OnPlayerDeath" should return a value - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: warning 209: function "S@@_OnPlayerDeath" should return a value (/showthread.php?tid=636602)


warning 209: function "S@@_OnPlayerDeath" should return a value - RoX123 - 30.06.2017

Код:
public OnPlayerDeath(playerid, killerid, reason)

    if(uduelu[playerid] == 1 && uduelu[killerid] == 1)
	{
		GivePlayerMoney(killerid, 2*Ulog);
		new Float:Health, Float:Armour, string[128];
		GetPlayerArmour(killerid, Armour);
		GetPlayerHealth(killerid, Health);
		format(string, sizeof(string), "{ff0000}[DUEL] %s(%d) {ffffff}je pobjedio %s(%d) i ostalo mu je %.2f HP %.2f ARMOR", PlayerName(killerid), killerid, PlayerName(playerid), playerid, Health, Armour);
		SendClientMessageToAll(-1, string);
		SetPlayerPos(playerid,1727.7881,-1667.6744,22.6094);
		SetPlayerPos(killerid,1727.7881,-1667.6744,22.6094);
		SetPlayerInterior(killerid, 18);
		SetPlayerInterior(playerid, 18);
		ResetPlayerWeapons(playerid);
		ResetPlayerWeapons(killerid);
		SpawnPlayer(killerid);
		new str[128];
		format(str, sizeof(str), "{ff0000}[DUEL]: {ffffff}Pobjedio si %s(%d) i osvojio $%d", PlayerName(playerid), playerid, Ulog);
		SCM(killerid, -1, str);
		tijek = 0;
		uduelu[playerid] = 0;
		uduelu[killerid] = 0;
		KillTimer(DUEL_TIMER);
		if(killerid != INVALID_PLAYER_ID)
  {
		SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
		GivePlayerMoney(killerid, 300);
		SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
		GivePlayerMoney(playerid, -100);
		SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
		}
		return 1;
		}
I have this warning:warning 209: function "S@@_OnPlayerDeath" should return a value
And its not work, when i kill someone i dont get +1 score, please help

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - Whatname - 30.06.2017

you forgot one bracket

PHP код:
public OnPlayerDeath(playerid, killerid, reason)
{
    if(uduelu[playerid] == 1 && uduelu[killerid] == 1)
    {
        GivePlayerMoney(killerid, 2*Ulog);
        new Float:Health, Float:Armour, string[128];
        GetPlayerArmour(killerid, Armour);
        GetPlayerHealth(killerid, Health);
        format(string, sizeof(string), "{ff0000}[DUEL] %s(%d) {ffffff}je pobjedio %s(%d) i ostalo mu je %.2f HP %.2f ARMOR", PlayerName(killerid), killerid, PlayerName(playerid), playerid, Health, Armour);
        SendClientMessageToAll(-1, string);
        SetPlayerPos(playerid,1727.7881,-1667.6744,22.6094);
        SetPlayerPos(killerid,1727.7881,-1667.6744,22.6094);
        SetPlayerInterior(killerid, 18);
        SetPlayerInterior(playerid, 18);
        ResetPlayerWeapons(playerid);
        ResetPlayerWeapons(killerid);
        SpawnPlayer(killerid);
        new str[128];
        format(str, sizeof(str), "{ff0000}[DUEL]: {ffffff}Pobjedio si %s(%d) i osvojio $%d", PlayerName(playerid), playerid, Ulog);
        SCM(killerid, -1, str);
        tijek = 0;
        uduelu[playerid] = 0;
        uduelu[killerid] = 0;
        KillTimer(DUEL_TIMER);
        if(killerid != INVALID_PLAYER_ID)
  {
        SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
        GivePlayerMoney(killerid, 300);
        SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
        GivePlayerMoney(playerid, -100);
        SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
        }
                }
        return 1;
        } 


Re: warning 209: function "S@@_OnPlayerDeath" should return a value - RoX123 - 30.06.2017

Quote:
Originally Posted by Whatname
Посмотреть сообщение
you forgot one bracket

PHP код:
public OnPlayerDeath(playerid, killerid, reason)
{
    if(uduelu[playerid] == 1 && uduelu[killerid] == 1)
    {
        GivePlayerMoney(killerid, 2*Ulog);
        new Float:Health, Float:Armour, string[128];
        GetPlayerArmour(killerid, Armour);
        GetPlayerHealth(killerid, Health);
        format(string, sizeof(string), "{ff0000}[DUEL] %s(%d) {ffffff}je pobjedio %s(%d) i ostalo mu je %.2f HP %.2f ARMOR", PlayerName(killerid), killerid, PlayerName(playerid), playerid, Health, Armour);
        SendClientMessageToAll(-1, string);
        SetPlayerPos(playerid,1727.7881,-1667.6744,22.6094);
        SetPlayerPos(killerid,1727.7881,-1667.6744,22.6094);
        SetPlayerInterior(killerid, 18);
        SetPlayerInterior(playerid, 18);
        ResetPlayerWeapons(playerid);
        ResetPlayerWeapons(killerid);
        SpawnPlayer(killerid);
        new str[128];
        format(str, sizeof(str), "{ff0000}[DUEL]: {ffffff}Pobjedio si %s(%d) i osvojio $%d", PlayerName(playerid), playerid, Ulog);
        SCM(killerid, -1, str);
        tijek = 0;
        uduelu[playerid] = 0;
        uduelu[killerid] = 0;
        KillTimer(DUEL_TIMER);
        if(killerid != INVALID_PLAYER_ID)
  {
        SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
        GivePlayerMoney(killerid, 300);
        SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
        GivePlayerMoney(playerid, -100);
        SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
        }
                }
        return 1;
        } 
Код:
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(317) : error 017: undefined symbol "UserPath"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(319) : error 017: undefined symbol "UserPath"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(333) : error 017: undefined symbol "OcistiChat"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(344) : error 017: undefined symbol "PlayerName"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(348) : error 017: undefined symbol "UserPath"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(398) : error 017: undefined symbol "PlayerName"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(480) : error 017: undefined symbol "PlayerName"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(490) : error 017: undefined symbol "PlayerName"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(504) : error 079: inconsistent return types (array & non-array)
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(511) : warning 217: loose indentation
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(511) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(511) : error 004: function "S@@_OnVehicleSpawn" is not implemented
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(513) : error 079: inconsistent return types (array & non-array)
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(516) : warning 225: unreachable code
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(516) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(516) : error 004: function "S@@_OnVehicleDeath" is not implemented
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(518) : error 079: inconsistent return types (array & non-array)
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(521) : warning 225: unreachable code
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(521) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(521) : error 004: function "S@@_OnPlayerText" is not implemented
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(523) : error 079: inconsistent return types (array & non-array)
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(526) : warning 225: unreachable code
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(526) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(526) : error 004: function "zcmd_OnPlayerCommandText" is not implemented
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(528) : error 079: inconsistent return types (array & non-array)
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(552) : warning 225: unreachable code
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(552) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(552) : error 004: function "OnPlayerCommandPerformed" is not implemented
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(554) : error 017: undefined symbol "cmdtext"
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(554) : error 029: invalid expression, assumed zero
C:\Users\User\Desktop\RB DM\gamemodes\gdm.pwn(554) : error 017: undefined symbol "cmdtext"

Compilation aborted.Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


26 Errors.
It doesnt works, now 26 errors

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - 1fret - 30.06.2017

Bro did you copy and paste that coding , because the coding the guy above gave you is right u are only missing an bracket

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - RoX123 - 30.06.2017

Quote:
Originally Posted by 1fret
Посмотреть сообщение
Bro did you copy and paste that coding , because the coding the guy above gave you is right u are only missing an bracket
Код:
public OnPlayerDeath(playerid, killerid, reason)
{
    if(uduelu[playerid] == 1 && uduelu[killerid] == 1)
    {
        GivePlayerMoney(killerid, 2*Ulog);
        new Float:Health, Float:Armour, string[128];
        GetPlayerArmour(killerid, Armour);
        GetPlayerHealth(killerid, Health);
        format(string, sizeof(string), "{ff0000}[DUEL] %s(%d) {ffffff}je pobjedio %s(%d) i ostalo mu je %.2f HP %.2f ARMOR", PlayerName(killerid), killerid, PlayerName(playerid), playerid, Health, Armour);
        SendClientMessageToAll(-1, string);
        SetPlayerPos(playerid,1727.7881,-1667.6744,22.6094);
        SetPlayerPos(killerid,1727.7881,-1667.6744,22.6094);
        SetPlayerInterior(killerid, 18);
        SetPlayerInterior(playerid, 18);
        ResetPlayerWeapons(playerid);
        ResetPlayerWeapons(killerid);
        SpawnPlayer(killerid);
        new str[128];
        format(str, sizeof(str), "{ff0000}[DUEL]: {ffffff}Pobjedio si %s(%d) i osvojio $%d", PlayerName(playerid), playerid, Ulog);
        SCM(killerid, -1, str);
        tijek = 0;
        uduelu[playerid] = 0;
        uduelu[killerid] = 0;
        KillTimer(DUEL_TIMER);
        if(UsaoDM[playerid] == 1 && UsaoDM[killerid] == 1)
  {
        SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
        GivePlayerMoney(killerid, 300);
        SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
        GivePlayerMoney(playerid, -100);
        SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
        }
                }
        return 1;
        }
I fixed erors but when i kill player in arena i dont get score, "UsaoDM" means joined arena, so i get score only when i kill someone in duel 1v1, but defined is "UsaoDM" i realy dont know why

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - 1fret - 30.06.2017

editing

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - 1fret - 30.06.2017

PHP код:
   if(UsaoDM[playerid] == 1)
       {
        GivePlayerMoney(playerid, -100);
        SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
        }
         
        if(UsaoDM[killerid] == 1)
       {
        SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
        GivePlayerMoney(killerid, 300);
        SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
       } 
The finishing product. I haven't tested it i just copied your coding and added the touches to it
PHP код:
public OnPlayerDeath(playerid, killerid, reason)
{
    if(uduelu[playerid] == 1 && uduelu[killerid] == 1)
    {
        GivePlayerMoney(killerid, 2*Ulog);
        new Float:Health, Float:Armour, string[128];
        GetPlayerArmour(killerid, Armour);
        GetPlayerHealth(killerid, Health);
        format(string, sizeof(string), "{ff0000}[DUEL] %s(%d) {ffffff}je pobjedio %s(%d) i ostalo mu je %.2f HP %.2f ARMOR", PlayerName(killerid), killerid, PlayerName(playerid), playerid, Health, Armour);
        SendClientMessageToAll(-1, string);
        SetPlayerPos(playerid,1727.7881,-1667.6744,22.6094);
        SetPlayerPos(killerid,1727.7881,-1667.6744,22.6094);
        SetPlayerInterior(killerid, 18);
        SetPlayerInterior(playerid, 18);
        ResetPlayerWeapons(playerid);
        ResetPlayerWeapons(killerid);
        SpawnPlayer(killerid);
        new str[128];
        format(str, sizeof(str), "{ff0000}[DUEL]: {ffffff}Pobjedio si %s(%d) i osvojio $%d", PlayerName(playerid), playerid, Ulog);
        SCM(killerid, -1, str);
        tijek = 0;
        uduelu[playerid] = 0;
        uduelu[killerid] = 0;
        KillTimer(DUEL_TIMER);
        if(UsaoDM[playerid] == 1)
        {
            GivePlayerMoney(playerid, -100);
            SendClientMessage(playerid, -1, "You lost 100$ because you got killed.");
        }
        if(UsaoDM[killerid] == 1)
        {
            SetPlayerScore(killerid, GetPlayerScore(killerid)+1);
            GivePlayerMoney(killerid, 300);
            SendClientMessage(killerid, -1, "Congratulation!You have gained 300$ and +1 score.");
        }
    }
    return 1;
} 
Shit, sorry for double posting

Re: warning 209: function "S@@_OnPlayerDeath" should return a value - RoX123 - 30.06.2017

Fixed, thank you guys a lot, REP++