Little help - Printable Version

Little help - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Little help (/showthread.php?tid=634713)

Little help - Kraeror - 24.05.2017

Hello guys. I made a house system. I need help please. I created /lock command and it works perfect, but I want, when the player is not in range of point, it return a message. I made this, but the server send me the message 40- 50 times, I think it's because of this code:

Quote:

for(new h = 0; h <= MAX_HOUSES; h++)

Can you tell me how to fix it?

Re: Little help - CheezIt - 24.05.2017

Create a function that returns the closest house within a certain radius, or at least the first house within the radius (break; the loop). Check if the return value is false in a if-then, then show the message.

If you don't want to create a function and use that loop, then use the loop only for getting a house in range (break; the loop when a house is found). Send the message or proceed with locking the house OUTSIDE the loop.

Re: Little help - ISmokezU - 24.05.2017

PHP код:



for(new h; h < MAX_HOUSES; h++)

Weird... o.O

Re: Little help - Kraeror - 24.05.2017

Quote:

Originally Posted by CheezIt

Create a function that returns the closest house within a certain radius, or at least the first house within the radius (break; the loop). Check if the return value is false in a if-then, then show the message.

If you don't want to create a function and use that loop, then use the loop only for getting a house in range (break; the loop when a house is found). Send the message or proceed with locking the house OUTSIDE the loop.

I created this:

Quote:

if(IsPlayerInRangeOfPoint(playerid, 1, HouseInfo[h][HouseX], HosueInfo[h][HouseY], HouseInfo[h][HouseZ]))
{
//here is the code
}
else SendClientMessage(playerid, Color, Message);

but it doesn't works

.
(This message sent to me wherever I am)
Can you fix it?

Re: Little help - DRIFT_HUNTER - 24.05.2017

Quote:

Originally Posted by Kraeror

Hello guys. I made a house system. I need help please. I created /lock command and it works perfect, but I want, when the player is not in range of point, it return a message. I made this, but the server send me the message 40- 50 times, I think it's because of this code:

Can you tell me how to fix it?

Well that line is a loop, and to assume that loop sends you 40-50 messages is the right way.
Inside that loop you need to check if player is in range of given house (point). If he is not continue, if he is, break.

Re: Little help - Kraeror - 24.05.2017

Quote:

Originally Posted by ISmokezU

PHP код:



for(new h; h < MAX_HOUSES; h++)

Weird... o.O

It's not weird, it's code for loop. :X

Re: Little help - Kraeror - 24.05.2017

Quote:

Originally Posted by DRIFT_HUNTER

Can you give me еxemplary code to fix?

Re: Little help - Kraeror - 24.05.2017

Please help me (give me code).
Here is my code:

Quote:

for(new h = 0; h <= MAX_HOUSES; h++)
{
if(IsPlayerInRangeOfPoint(playerid, 1, HouseInfo[h][HouseX], HouseInfo[h][HouseY], HouseInfo[h][HouseZ]))
{
//Here is the lock
}
else SendClientMessage(mymessage); //This message doesn't work as needed
}

Re: Little help - DRIFT_HUNTER - 24.05.2017

Код:

new houseid = -1;
for(new h = 0; h <= MAX_HOUSES; h++)
{
    if(IsPlayerInRangeOfPoint(playerid, 1, HouseInfo[h][HouseX], HouseInfo[h][HouseY], HouseInfo[h][HouseZ]))
    {
        houseid = h;//Lets save house id to a variable.
        //Here is the lock
        break;//And since we found house, we leave loop (no need to waste resources)
    }
}
if(houseid == -1) return SendClientMessage(mymessage); //This message doesn't work as needed

Keep in mind that you dont check if house is valid (if it exists)

Re: Little help - Unrea1 - 24.05.2017

More simple:

PHP код:



for(new h = 0; h <= MAX_HOUSES; h++)

{

    if(IsPlayerInRangeOfPoint(playerid, 1.0, HouseInfo[h][HouseX], HouseInfo[h][HouseY], HouseInfo[h][HouseZ]))

    {

        // If exist one house in range of player.

        return 1;

    }

}

// Message if don't exist one house in range.