MySQL vehicle ID problem. - Printable Version
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: MySQL vehicle ID problem. (/showthread.php?tid=634613)
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: MySQL vehicle ID problem. (/showthread.php?tid=634613)
MySQL vehicle ID problem. - Bwandon - 22.05.2017
I'll try to explain this problem to best of my ability, basically I have a command '/acar create < model id / model name.'
This inserts a new row in to the MySQL table `VehicleInfo` (a new vehicle). Once this has finished querying, I then send a new query to the database, getting the data from it and then spawning the vehicle. Although, during testing I created 6 vehicles then empty'd the table but when I go in to the server and create another new vehicle it's registering the ID as 7 instead of 1 again (Note: 1 - 6 vehicle ID's nolonger exist within the table)
I also stopped the server then empty'd the table.
Here is some code:
Command:
PHP код:
if(!strcmp(iParams, "create", true, 6)) {
if(PlayerInfo[playerid][aAdmin] < 4) return SendError(playerid, CANT_USE_CMD);
if(!strlen(iParamsEx)) return SCP(playerid, "/acar create", "< model / id >");
new slctedID;
if(!IsNumeric(iParamsEx)) slctedID = ModelFromName(iParamsEx);
else slctedID = strval(iParamsEx);
if(slctedID < 400 || slctedID > 611) return SCP(playerid, "/acar create", "< model / id >");
new Float:playerX, Float:playerY, Float:playerZ, Float:playerA;
GetPlayerPos(playerid, playerX, playerY, playerZ);
GetPlayerFacingAngle(playerid, playerA);
CreateNewVehicle(PlayerName(playerid), slctedID, playerX, playerY, playerZ, playerA);
new iFormat[159];
format(iFormat, sizeof(iFormat), "(( AdmCmd | {CCCCCC}You have successfully created a new vehicle: %s! {D13F3F}))", VehicleName[slctedID - 400]);
SendPlayerMessage(playerid, 0xD13F3FFF, iFormat, "(( AdmCmd | {CCCCCC}");
return 1;
}
PHP код:
stock CreateNewVehicle(vehOwner[], vehModel, Float:vehX, Float:vehY, Float:vehZ, Float:vehA, vVW = 0, rRes = VEHICLE_OWNED) {
new iQuery[450];
mysql_format(Pipeline, iQuery, sizeof(iQuery), "INSERT INTO `VehicleInfo` (`Owner`, `Model`, `X`, `Y`, `Z`, `A`, `VirtualWorld`, `Type`) VALUES ('%e', %d, %f, %f, %f, %f, %d, %d)", vehOwner, vehModel, vehX, vehY, vehZ, vehA, vVW, rRes);
mysql_tquery(Pipeline, iQuery, "OnVehicleCreation");
}
PHP код:
public OnVehicleCreation() {
new vehicleid = cache_insert_id();
printf("[ON VEHICLE CREATE] %d has been created successfully!", vehicleid);
new iQuery[159]; mysql_format(Pipeline, iQuery, sizeof(iQuery), "SELECT * FROM `VehicleInfo` WHERE `ID` = %d LIMIT 1", vehicleid);
mysql_tquery(Pipeline, iQuery, "OnLoadVehicles", "d", 0);
return 1;
}
Re: MySQL vehicle ID problem. - Vince - 22.05.2017
That's normal. Auto-generated ID's do not get reset or reused. And with reason. For example, this very topic has id 634613 in the database. If it gets deleted then that ID does not get re-used. If it did get reused then all existing links to it would suddenly point to another topic. If you want to start from scratch you should use TRUNCATE TABLE. This deletes all the data and it also resets the auto-increment id. However I don't believe truncate will work if there are foreign keys.
Quote:
|
Originally Posted by Bwandon
 Once this has finished querying, I then send a new query to the database, getting the data from it and then spawning the vehicle.
|
Also what's the deal with prefixing variables with "i"? When I see "i" in front of a variable I think "integer". This makes your code a bitch to read because none of those variables are integers.
Re: MySQL vehicle ID problem. - Bwandon - 22.05.2017
I understand now.
Sorry, it's a shitty habit. I'll try to get out of it.
And I'll fix the code when inserting a new row, like you said it's a waste of time to send a new query.
Thanks for your reply.
Re: MySQL vehicle ID problem. - DobbysGamertag - 22.05.2017
Quote:
|
Originally Posted by Vince
That's normal. Auto-generated ID's do not get reset or reused. And with reason. For example, this very topic has id 634613 in the database. If it gets deleted then that ID does not get re-used. If it did get reused then all existing links to it would suddenly point to another topic. If you want to start from scratch you should use TRUNCATE TABLE. This deletes all the data and it also resets the auto-increment id. However I don't believe truncate will work if there are foreign keys.
Why? That's extremely counter intuitive. You already have the data so why (again) do you need to query for it? Also what's the deal with prefixing variables with "i"? When I see "i" in front of a variable I think "integer". This makes your code a bitch to read because none of those variables are integers. |
pawn Код:
ALTER TABLE DROP `somecolumname`
ALTER TABLE `sometable` ADD `id` INT NOT NULL AUTO_INCREMENT FIRST, ADD PRIMARY KEY (`id`);