SA-MP Forums Archive
Help On this CMD - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Help On this CMD (/showthread.php?tid=634217)


Help On this CMD - Bojaa - 15.05.2017

This cmd have a problem when i join the server and type it does not show this message
PHP код:
SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness."); 
PHP код:
CMD:bizwithdraw(playerid, params[])
{
    for(new biz = 0; biz < MAX_BIZ; biz++)
    {
        if(IsPlayerInRangeOfPoint(playerid, 100, BizInfo[biz][IXCoord], BizInfo[biz][IYCoord], BizInfo[biz][IZCoord]))
        {
            if(GetPlayerVirtualWorld(playerid) == BizInfo[biz][VW])
            {
                if(!strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true))
                {
                    new money;
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]");
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!");
                    new string[150];
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money);
                    SendClientMessage(playerid, COLOR_GREY, string);
                     GivePlayerCash(playerid, money);
                     BizInfo[biz][Till] -= money;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness.");
                }
            }
        }
    }
    return 1;
} 


Re: Help On this CMD - XtremeRz - 15.05.2017

if(!strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true))

That line has something wrong with it, but I don't really know how to fix it.

Re: Help On this CMD - Bolex_ - 15.05.2017

Код:
CMD:bizwithdraw(playerid, params[])
{
    for(new biz = 0; biz < MAX_BIZ; biz++)
    {
        if(IsPlayerInRangeOfPoint(playerid, 100, BizInfo[biz][IXCoord], BizInfo[biz][IYCoord], BizInfo[biz][IZCoord]))
        {
            if(GetPlayerVirtualWorld(playerid) == BizInfo[biz][VW])
            {
                if(strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true)) == 0)
                {
                    new money;
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]");
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!");
                    new string[150];
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money);
                    SendClientMessage(playerid, COLOR_GREY, string);
                     GivePlayerCash(playerid, money);
                     BizInfo[biz][Till] -= money;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness.");
                }
            }
        }
    }
    return 1;
}


Re: Help On this CMD - Bojaa - 15.05.2017

Quote:
Originally Posted by Bolex_
Посмотреть сообщение
Код:
CMD:bizwithdraw(playerid, params[])
{
    for(new biz = 0; biz < MAX_BIZ; biz++)
    {
        if(IsPlayerInRangeOfPoint(playerid, 100, BizInfo[biz][IXCoord], BizInfo[biz][IYCoord], BizInfo[biz][IZCoord]))
        {
            if(GetPlayerVirtualWorld(playerid) == BizInfo[biz][VW])
            {
                if(strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true)) == 0)
                {
                    new money;
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]");
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!");
                    new string[150];
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money);
                    SendClientMessage(playerid, COLOR_GREY, string);
                     GivePlayerCash(playerid, money);
                     BizInfo[biz][Till] -= money;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness.");
                }
            }
        }
    }
    return 1;
}
This have not worked

Re: Help On this CMD - Tord - 15.05.2017

@Bolex, don't bother helping unless you know the obvious. According to wiki.sa-mp.com, you can find that strcmp = 0 when the string matches at the given length, and will be 1 (or -1) when not. Look at the picture further down, which is a screenshot from the wiki page.

PHP код:
                if(!strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true))  //here is the problem
                { 
                    new money; 
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]"); 
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!"); 
                    new string[150]; 
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money); 
                    SendClientMessage(playerid, COLOR_GREY, string); 
                     GivePlayerCash(playerid, money); 
                     BizInfo[biz][Till] -= money; 
                } 
                else  //because this code executes
                { 
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness."); 
                } 
So how can you solve it?
First of all you have to ensure that
PHP код:
BizInfo[biz][Owner] 
has been set correctly, when the owner is being set. If this doesn't match with the players name, it will eventually fail.
Can you show code where you set the biz owner, and does similar code work somewhere else?
Also, note that, if one of the strings are empy, they will return 0 on strcmp as well, so just in case - check that as well in order to avoid bugs.




Re: Help On this CMD - Bojaa - 15.05.2017

Quote:
Originally Posted by Bolex_
Посмотреть сообщение
Код:
CMD:bizwithdraw(playerid, params[])
{
    for(new biz = 0; biz < MAX_BIZ; biz++)
    {
        if(IsPlayerInRangeOfPoint(playerid, 100, BizInfo[biz][IXCoord], BizInfo[biz][IYCoord], BizInfo[biz][IZCoord]))
        {
            if(GetPlayerVirtualWorld(playerid) == BizInfo[biz][VW])
            {
                if(strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true)) == 0)
                {
                    new money;
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]");
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!");
                    new string[150];
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money);
                    SendClientMessage(playerid, COLOR_GREY, string);
                     GivePlayerCash(playerid, money);
                     BizInfo[biz][Till] -= money;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness.");
                }
            }
        }
    }
    return 1;
}
So Its False How to fix it?

Re: Help On this CMD - Tord - 15.05.2017

Did you check if the variable contained the correct username? (And that it's a string?)

Re: Help On this CMD - GTLS - 15.05.2017

Try This:
PHP код:
CMD:bizwithdraw(playerid, params[])
{
    for(new biz = 0; biz < MAX_BIZ; biz++)
    {
        if(IsPlayerInRangeOfPoint(playerid, 100, BizInfo[biz][IXCoord], BizInfo[biz][IYCoord], BizInfo[biz][IZCoord]))
        {
            if(GetPlayerVirtualWorld(playerid) == BizInfo[biz][VW])
            {
                if(!strcmp(BizInfo[biz][Owner], GetPlayerNameEx(playerid), true))
                {
                    new money;
                    if(sscanf(params,"d", money)) return SendClientMessage(playerid, COLOR_WHITE, "USAGE: /bizwithdraw [amount]");
                    if(money > BizInfo[biz][Till]) return SendClientMessage(playerid, COLOR_GRAD2, "You don't have that much money in your Till!");
                    new string[150];
                    format(string,sizeof(string),"You've taken $%d out of your Business Till.", money);
                    SendClientMessage(playerid, COLOR_GREY, string);
                     GivePlayerCash(playerid, money);
                     BizInfo[biz][Till] -= money;
                }
                else
                {
                    SendClientMessage(playerid, COLOR_GRAD2, "You're not in your bussiness.");
                }
            }
        }
    }
    return 1;
} 
Also, Make sure your Owner's name is getting saved correctly inside files.

Re: Help On this CMD - DRIFT_HUNTER - 15.05.2017

IsPlayerInRangeOfPoint 100 -> That's a huge range, lover it to about 2-3 units if you want player to stand at pickup/cp/entrance, or to about 10-20 if you want him to be in vicinity.