SA-MP Forums Archive
Issue, with if and for, help me please! - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Issue, with if and for, help me please! (/showthread.php?tid=632243)


Issue, with if and for, help me please! - XpoZzA - 11.04.2017

Код:
markers = 0;
 CMD:togmarks(playerid, params[]){
for(new i = 0; i<=MAX_PLAYERS;i++)
{
new PlayerColor = GetPlayerColor(playerid);
/*(line 1363)*/ if(PlayerColor == 0xFFFFFF00 && markers = 1)
{
SetPlayerColor(i, ServerColors[random(20)]);

}
else if(PlayerColor != 0xFFFFFF00){
SetPlayerColor(i,PlayerColor);

}
markers = 1;
}
//FOR END HERE//
SendClientMessage(playerid, 0x33AA33AA,"Poof! you can see em' all!!");
return 1;

}
ERRORS:
Код:
C:\Servers\racing_samp\gamemodes\race.pwn(1358) : error 010: invalid function or declaration
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : warning 211: possibly unintended assignment
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 022: must be lvalue (non-constant)
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : warning 215: expression has no effect
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 001: expected token: ";", but found ")"
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 029: invalid expression, assumed zero
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : fatal error 107: too many error messages on one line

Compilation aborted.Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


5 Errors.
Help please!

Re: Issue, with if and for, help me please! - jasperschellekens - 11.04.2017

Try this

PHP код:
 CMD:togmarks(playerid, params[]){
markers = 0;
for(new i = 0; i<=MAX_PLAYERS;i++)
{
new PlayerColor = GetPlayerColor(playerid);
if(PlayerColor[i] == 0xFFFFFF00 && markers = 1)
{
SetPlayerColor(i, ServerColors[random(20)]);

}
else if(PlayerColor[i] != 0xFFFFFF00){
SetPlayerColor(i,PlayerColor);

}
markers = 1;
}
//FOR END HERE//
SendClientMessage(playerid, 0x33AA33AA,"Poof! you can see em' all!!");
return 1;

} 


Re: Issue, with if and for, help me please! - XpoZzA - 11.04.2017

Quote:
Originally Posted by jasperschellekens
Посмотреть сообщение
Try this

PHP код:
 CMD:togmarks(playerid, params[]){
markers = 0;
for(new i = 0; i<=MAX_PLAYERS;i++)
{
new PlayerColor = GetPlayerColor(playerid);
if(PlayerColor[i] == 0xFFFFFF00 && markers = 1)
{
SetPlayerColor(i, ServerColors[random(20)]);
}
else if(PlayerColor[i] != 0xFFFFFF00){
SetPlayerColor(i,PlayerColor);
}
markers = 1;
}
//FOR END HERE//
SendClientMessage(playerid, 0x33AA33AA,"Poof! you can see em' all!!");
return 1;
} 
Now it says:
Код:
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 028: invalid subscript (not an array or too many subscripts): "PlayerColor"
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : warning 215: expression has no effect
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 001: expected token: ";", but found "]"
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : error 029: invalid expression, assumed zero
C:\Servers\racing_samp\gamemodes\race.pwn(1363) : fatal error 107: too many error messages on one line


Re: Issue, with if and for, help me please! - Sew_Sumi - 11.04.2017

By your code you're setting markers to 1, MAX_PLAYERS times...

Re: Issue, with if and for, help me please! - XpoZzA - 11.04.2017

Quote:
Originally Posted by Sew_Sumi
Посмотреть сообщение
By your code you're setting markers to 1, MAX_PLAYERS times...
Alright, I'll try to fix it, will update you guys.

Re: Issue, with if and for, help me please! - DarkSkull - 11.04.2017

PHP код:
 CMD:togmarks(playerid, params[]){
markers = 0;
for(new i = 0; i<=MAX_PLAYERS;i++)
{
new PlayerColor = GetPlayerColor(i);
if(PlayerColor == 0xFFFFFF00 && markers = 1)
{
SetPlayerColor(i, ServerColors[random(20)]);
}
else if(PlayerColor[i] != 0xFFFFFF00){
SetPlayerColor(i,PlayerColor);
}
markers = 1;
}
//FOR END HERE//
SendClientMessage(playerid, 0x33AA33AA,"Poof! you can see em' all!!");
return 1;
} 
PlayerColor is a variable and not an array. You can't you use it like that. Try this. Also, Could you explain what this command does so that We can fix this?

Re: Issue, with if and for, help me please! - DarkSkull - 11.04.2017

PHP код:
CMD:togmarks(playerid, params[]){
markers = 0;
for(new i = 0; i<=MAX_PLAYERS;i++)
{
if(!IsPlayerConnected(i)) continue;
new PlayerColor = GetPlayerColor(i);
if(PlayerColor == 0xFFFFFF00 && markers = 1)
{
SetPlayerColor(i, ServerColors[random(20)]);
}
else if(PlayerColor[i] != 0xFFFFFF00){
SetPlayerColor(i,PlayerColor);
}
markers = 1;
}
//FOR END HERE//
SendClientMessage(playerid, 0x33AA33AA,"Poof! you can see em' all!!");
return 1;
} 
You should also check if the player is connected. Try this, It would do that as well.

Re: Issue, with if and for, help me please! - Sew_Sumi - 11.04.2017

Further to this marker variable... You set it to 0 when you use the command, then set it MAX_PLAYER times to 1.

Also "Poof! you can see them all" will turn up whether you are disabling, or enabling the marks.