Elevator help - Printable Version

Elevator help - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Elevator help (/showthread.php?tid=628040)

Elevator help - ZxPower - 05.02.2017

PHP код:



CMD:Floor1(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 23.12810,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor2(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 28.61410,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor3(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 34.08010,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor4(playerid,params[])

{

    MoveObject(Elevator, 1786.65344, -1303.42200, 34.06210,   0.00000, 0.00000, -90.36000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor5(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 45.00410,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor6(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 50.38210,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor7(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 55.83810,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor8(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 61.30410,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor9(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 66.75410,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor10(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 72.18410,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor11(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 77.59010,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor12(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 83.04010,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor13r(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 88.50510,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor14(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 93.95810,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor15(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 99.42010,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Etajul16(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 104.81910,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor17(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 110.27310,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor18(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 115.73510,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor19(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 121.19710,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor20(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 126.65910,   0.00000, 0.00000, -88.68000);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

CMD:Floor(playerid,params[])

{

    MoveObject(Elevator, 1786.72803, -1303.36182, 14.55410,   0.00000, 0.00000, -88.67995);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

Never mind, i slove it

Re: Elevator help - BiosMarcel - 05.02.2017

This

PHP код:



MoveObject(,

occurs two times.

Re: Elevator help - ZxPower - 05.02.2017

Quote:

Originally Posted by [Bios]Marcel

This

PHP код:



MoveObject(,

occurs two times.

Never mind, i slove it

Re: Elevator help - BiosMarcel - 05.02.2017

Quote:

Originally Posted by ZxPower

Never mind, i slove it

those errors are on completly diffrent lines, anyways loose identation is because you don't properly indent your code, use a formatter to format your code. DONT USE PRAGMA TO FIX IT!

Re: Elevator help - ZxPower - 05.02.2017

Elevator won't move, what can i do?
help pls

Re: Elevator help - Vince - 05.02.2017

Efficiency is clearly not your top priority. Twenty commands that essentially all do the same thing. I could write it in a sixth of the space.

PHP код:



CMD:floor(playerid, params[])
{
    static const
        Float:ELEVATOR_X = 1786.72803,
        Float:ELEVATOR_Y = -1303.36182,
        Float:ELEVATOR_Z_BASE = 14.55410,
        Float:ELEVATOR_Z_INCREMENT = 5.605;

    new 
        floorNumber;
        
    if(sscanf(params, "d", floorNumber))
        return SendClientMessage(playerid, -1, "Usage: /floor [floor number]");
        
    if(!(0 <= floorNumber <= 20))
        return SendClientMessage(playerid, -1, "Floor number between 0 and 20");
        
    MoveObject(Elevator, ELEVATOR_X, ELEVATOR_Y, ELEVATOR_Z_BASE + ELEVATOR_Z_INCREMENT * floorNumber, 0.0, 0.0, -88.68);
    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");
    return 1;
}

Re: Elevator help - ZxPower - 05.02.2017

Quote:

Originally Posted by Vince

Efficiency is clearly not your top priority. Twenty commands that essentially all do the same thing. I could write it in a sixth of the space.

PHP код:



CMD:floor(playerid, params[])

{

    static const

        Float:ELEVATOR_X = 1786.72803,

        Float:ELEVATOR_Y = -1303.36182,

        Float:ELEVATOR_Z_BASE = 14.55410,

        Float:ELEVATOR_Z_INCREMENT = 5.605;


    new 

        floorNumber;

        

    if(sscanf(params, "d", floorNumber))

        return SendClientMessage(playerid, -1, "Usage: /floor [floor number]");

        

    if(!(0 <= floorNumber <= 20))

        return SendClientMessage(playerid, -1, "Floor number between 0 and 20");

        

    MoveObject(Elevator, ELEVATOR_X, ELEVATOR_Y, ELEVATOR_Z_BASE + ELEVATOR_Z_INCREMENT * floorNumber, 0.0, 0.0, -88.68);

    SendClientMessage(playerid,COLOR_YELLOW,"Elevator Has Succefully Activated !");

    return 1;

}

omg ty