SA-MP Forums Archive
Bad code done? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Bad code done? (/showthread.php?tid=627042)


Bad code done? - SukMathcuck - 23.01.2017

So, I did a script here but it is not working properly, what did I do wrong?

PHP код:
stock SpecialCharacters(playerid, modelid)
{
        if(modelid == 19 && PlayerData[playerid][pGangster] < 40.0) return 1; //DJ*(bmydj)
        else if(modelid == 21 && PlayerData[playerid][pGangster] < 60.0) return 1; //Pedestre afro americano (bmycr)
        else if(modelid == 22 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre afro americano (bmyst)
        else if(modelid == 28 && PlayerData[playerid][pGangster] < 50.0) return 1; //Drug Dealer Negro (bmydrug)
        else if(modelid == 29 && PlayerData[playerid][pGangster] < 45.0) return 1; //Drug Dealer Branco (wmydrug)
        else if(modelid == 30 && PlayerData[playerid][pGangster] < 40.0) return 1; //Drug Dealer Mexicano (hmydrug)
        else if(modelid == 47 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre Mexicano (hmycr)
        else if(modelid == 48 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre Mexicano*(hmyst)
        else if(modelid == 67 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pool Player*(bmypol2)
        else if(modelid == 102 && PlayerData[playerid][pGangster] < 80.0) return 1; //Ballas 1
        else if(modelid == 103 && PlayerData[playerid][pGangster] < 80.0) return 1; //Ballas 2
        else if(modelid == 104 && PlayerData[playerid][pGangster] < 85.0) return 1; //Ballas 3
        else if(modelid == 105 && PlayerData[playerid][pGangster] < 80.0) return 1; //Grove Street 1
        else if(modelid == 106 && PlayerData[playerid][pGangster] < 85.0) return 1; //Grove Street 2
        else if(modelid == 107 && PlayerData[playerid][pGangster] < 80.0) return 1; //Grove Street 3
        else if(modelid == 108 && PlayerData[playerid][pGangster] < 85.0) return 1; //Vagos 1
        else if(modelid == 109 && PlayerData[playerid][pGangster] < 80.0) return 1; //Vagos 2
        else if(modelid == 110 && PlayerData[playerid][pGangster] < 80.0) return 1; //Vagos 3
        else if(modelid == 111 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 1
        else if(modelid == 112 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 2
        else if(modelid == 113 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 3
        else if(modelid == 121 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 1
        else if(modelid == 122 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 2
        else if(modelid == 123 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 3
        else if(modelid == 86 && PlayerData[playerid][pGangster] < 90.0) return 1; //Ryder com mascara (ryder3)
        else if(modelid == 149 && PlayerData[playerid][pGangster] < 90.0) return 1; //Big Smoke com colete (smokev)
        else if(modelid == 269 && PlayerData[playerid][pGangster] < 90.0) return 1; //Melvin 'Big Smoke' Harris
        else if(modelid == 270 && PlayerData[playerid][pGangster] < 90.0) return 1; //Sean 'Sweet' Johnson
        else if(modelid == 271 && PlayerData[playerid][pGangster] < 90.0) return 1; //Lance 'Ryder' Wilson
        else if(modelid == 292 && PlayerData[playerid][pGangster] < 90.0) return 1; //Cesar Vialpando
        else if(modelid == 293 && PlayerData[playerid][pGangster] < 90.0) return 1; //Jeffery "OG Loc" Martin/Cross
        else variavel = 1;
}
public blabla()
{
    new variavel;
        SpecialCharacters(playerid, modelid, variavel);
          if(variavel == 1) return 1;
} 


Re: Bad code done? - saffierr - 23.01.2017

Depends on what you want the code should do, elaborate.

Re: Bad code done? - X337 - 23.01.2017

Код:
    stock SpecialCharacters(playerid, modelid)
    {
            if(modelid == 19 && PlayerData[playerid][pGangster] < 40.0) return 1; //DJ*(bmydj)
            else if(modelid == 21 && PlayerData[playerid][pGangster] < 60.0) return 1; //Pedestre afro americano (bmycr)
            else if(modelid == 22 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre afro americano (bmyst)
            else if(modelid == 28 && PlayerData[playerid][pGangster] < 50.0) return 1; //Drug Dealer Negro (bmydrug)
            else if(modelid == 29 && PlayerData[playerid][pGangster] < 45.0) return 1; //Drug Dealer Branco (wmydrug)
            else if(modelid == 30 && PlayerData[playerid][pGangster] < 40.0) return 1; //Drug Dealer Mexicano (hmydrug)
            else if(modelid == 47 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre Mexicano (hmycr)
            else if(modelid == 48 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pedestre Mexicano*(hmyst)
            else if(modelid == 67 && PlayerData[playerid][pGangster] < 40.0) return 1; //Pool Player*(bmypol2)
            else if(modelid == 102 && PlayerData[playerid][pGangster] < 80.0) return 1; //Ballas 1
            else if(modelid == 103 && PlayerData[playerid][pGangster] < 80.0) return 1; //Ballas 2
            else if(modelid == 104 && PlayerData[playerid][pGangster] < 85.0) return 1; //Ballas 3
            else if(modelid == 105 && PlayerData[playerid][pGangster] < 80.0) return 1; //Grove Street 1
            else if(modelid == 106 && PlayerData[playerid][pGangster] < 85.0) return 1; //Grove Street 2
            else if(modelid == 107 && PlayerData[playerid][pGangster] < 80.0) return 1; //Grove Street 3
            else if(modelid == 108 && PlayerData[playerid][pGangster] < 85.0) return 1; //Vagos 1
            else if(modelid == 109 && PlayerData[playerid][pGangster] < 80.0) return 1; //Vagos 2
            else if(modelid == 110 && PlayerData[playerid][pGangster] < 80.0) return 1; //Vagos 3
            else if(modelid == 111 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 1
            else if(modelid == 112 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 2
            else if(modelid == 113 && PlayerData[playerid][pGangster] < 80.0) return 1; //Varios Los Aztecas 3
            else if(modelid == 121 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 1
            else if(modelid == 122 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 2
            else if(modelid == 123 && PlayerData[playerid][pGangster] < 60.0) return 1; //Da Nang Boy 3
            else if(modelid == 86 && PlayerData[playerid][pGangster] < 90.0) return 1; //Ryder com mascara (ryder3)
            else if(modelid == 149 && PlayerData[playerid][pGangster] < 90.0) return 1; //Big Smoke com colete (smokev)
            else if(modelid == 269 && PlayerData[playerid][pGangster] < 90.0) return 1; //Melvin 'Big Smoke' Harris
            else if(modelid == 270 && PlayerData[playerid][pGangster] < 90.0) return 1; //Sean 'Sweet' Johnson
            else if(modelid == 271 && PlayerData[playerid][pGangster] < 90.0) return 1; //Lance 'Ryder' Wilson
            else if(modelid == 292 && PlayerData[playerid][pGangster] < 90.0) return 1; //Cesar Vialpando
            else if(modelid == 293 && PlayerData[playerid][pGangster] < 90.0) return 1; //Jeffery "OG Loc" Martin/Cross

            return 0; // Return 0 if conditions above are false
    }

    public blabla()
    {
        new variavel;

        variavel = SpecialCharacters(playerid, modelid); // assign value that returned by SpecialCharacters into variavel

        return variavel;
    }