SA-MP Forums Archive
Would this AC hypothetically work ? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Would this AC hypothetically work ? (/showthread.php?tid=619104)


Would this AC hypothetically work ? - NeXoR - 13.10.2016

Hey, would this Anti Weapon Hack work for your opinion ?
And do you think there is a way to improve it ?

PHP код:
// AntiCheat Callbacks
forward WeaponHack();
public WeaponHack()
{
    new weaponid;
    foreach(new playerid : Player)
    {
        weaponid = GetPlayerWeapon(playerid);
        if(weaponid != PlayerInfo[playerid][pWeapon][GetWeaponSlot(weaponid)]) Kick(playerid);
    }
} 
PHP код:
stock GetWeaponSlot(weaponid)
{
    new slot;
    switch(weaponid)
    {
        case 0, 1: slot = 0; // No weapon
        case 2 .. 9: slot = 1; // Melee
        case 22 .. 24: slot = 2; // Handguns
        case 25 .. 27: slot = 3; // Shotguns
        case 28, 29, 32: slot = 4; // Sub-Machineguns
        case 30, 31: slot = 5; // Machineguns
        case 33, 34: slot = 6; // Rifles
        case 35 .. 38: slot = 7; // Heavy Weapons
        case 16, 18, 39: slot = 8; // Projectiles
        case 42, 43: slot = 9; // Special 1
        case 14: slot = 10; // Gifts
        case 44 .. 46: slot = 11; // Special 2
        case 40: slot = 12; // Detonators
        default: slot = -1; // No slot
    }
    return slot;
} 


Re: Would this AC hypothetically work ? - Dignity - 13.10.2016

PHP код:
if(weaponid != PlayerInfo[playerid][pWeapon][GetWeaponSlot(weaponid)]) Kick(playerid); 
Will result in false positives. There's always a chance the variable doesn't store immediately, so it's better to send a warning to the admins instead of kicking instantly.

Re: Would this AC hypothetically work ? - NeXoR - 13.10.2016

Quote:
Originally Posted by Satori_Komeiji
Посмотреть сообщение
PHP код:
if(weaponid != PlayerInfo[playerid][pWeapon][GetWeaponSlot(weaponid)]) Kick(playerid); 
Will result in false positives. There's always a chance the variable doesn't store immediately, so it's better to send a warning to the admins instead of kicking instantly.
The variable is stored even before the weapon is given (first variable - then GivePlayerWeapon)

Re: Would this AC hypothetically work ? - azzerking - 14.10.2016

Information

I would suggest you hook the functions used for weapons. Example:
Код:
stock AC_GivePlayerWeapon( playerid, weaponid, ammo )
{
	// YOUR CODE GOES HERE

	return GivePlayerWeapon( playerid, weaponid, ammo );
}
#if defined _ALS_GivePlayerWeapon
	#undef GivePlayerWeapon
#else
	#define _ALS_GivePlayerWeapon
#endif

#define GivePlayerWeapon AC_GivePlayerWeapon
Save the weapon and ammo to a variable that can hold them, preferably by using weapon slots ( which means the array will be a max of 12 slots instead of all weapons which would mean it was equal to 47 ).

Also add a delay of 800 ms in the hooked functions before setting the weapons and then in the weapon check function, you can check to see if the time has passed and then check their weapons.

then you may use kick, but make sure to test it first.

Re: Would this AC hypothetically work ? - NeXoR - 14.10.2016

Quote:
Originally Posted by azzerking
Посмотреть сообщение
Information

I would suggest you hook the functions used for weapons. Example:
Код:
stock AC_GivePlayerWeapon( playerid, weaponid, ammo )
{
	// YOUR CODE GOES HERE

	return GivePlayerWeapon( playerid, weaponid, ammo );
}
#if defined _ALS_GivePlayerWeapon
	#undef GivePlayerWeapon
#else
	#define _ALS_GivePlayerWeapon
#endif

#define GivePlayerWeapon AC_GivePlayerWeapon
Save the weapon and ammo to a variable that can hold them, preferably by using weapon slots ( which means the array will be a max of 12 slots instead of all weapons which would mean it was equal to 47 ).

Also add a delay of 800 ms in the hooked functions before setting the weapons and then in the weapon check function, you can check to see if the time has passed and then check their weapons.

then you may use kick, but make sure to test it first.
I'm pretty sure I already have it

PHP код:
stock GiveNexWeapon(playerid, weaponid, ammo)
{
    PlayerPlaySound(playerid, 1052, 0.0, 0.0, 0.0);
    PlayerInfo[playerid][pWeapon][GetWeaponSlot(weaponid)] = weaponid;
    PlayerInfo[playerid][pWeaponAmmo][GetWeaponSlot(weaponid)] = ammo;
    GivePlayerWeapon(playerid, weaponid, ammo);
    return 1;
}