SA-MP Forums Archive
PutPlayerInVehicle BUG - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: PutPlayerInVehicle BUG (/showthread.php?tid=616686)


PutPlayerInVehicle BUG - NeXoR - 09.09.2016

Holla, I am creating a Derby filterscript, and I am actually freaking out here.
When the Admin starts the derby you have 15 seconds to enter it, and then you are teleported to your car.
But somehow, it DOESNT teleport me to my car.

Codes:
Vehicle creation and definition
PHP код:
    DerbyVehicle[0] = CreateVehicle(451, -4346.9165, -874.4612, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[1] = CreateVehicle(451, -4346.9170, -906.1724, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[2] = CreateVehicle(451, -4346.9814, -908.8787, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[3] = CreateVehicle(451, -4347.0225, -911.5813, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[4] = CreateVehicle(451, -4347.1064, -914.3591, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[5] = CreateVehicle(451, -4347.1304, -917.1533, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[6] = CreateVehicle(451, -4347.1743, -920.1483, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[7] = CreateVehicle(451, -4347.1587, -923.1850, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[8] = CreateVehicle(451, -4347.1777, -926.1649, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[9] = CreateVehicle(451, -4347.2012, -929.1449, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[10] = CreateVehicle(451, -4347.2671, -932.2801, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[11] = CreateVehicle(451, -4347.2109, -935.2451, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[12] = CreateVehicle(451, -4347.2285, -938.1091, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[13] = CreateVehicle(451, -4347.1670, -940.9660, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[14] = CreateVehicle(451, -4347.1865, -943.7744, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[15] = CreateVehicle(451, -4347.1860, -946.4242, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[16] = CreateVehicle(451, -4347.1475, -949.2472, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[17] = CreateVehicle(451, -4347.2119, -964.8876, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[18] = CreateVehicle(451, -4347.1606, -980.2925, 4.9349, 90.0000, 155, -1, 100);
    DerbyVehicle[19] = CreateVehicle(451, -4347.1401, -890.8838, 4.9349, 90.0000, 155, -1, 100); 
CMDerby (start the derby)
PHP код:
CMD:derby(playerid, params[])
{
    if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid, -1, ".айрк агойп йа орйач");
    new maxp;
    if(sscanf(params, "i", maxp)) return SendClientMessage(playerid, -1, "/Derby [Max Players] :щйоещ");
    if(maxp < 2 || maxp > 20) return SendClientMessage(playerid, -1, "осфш ощъъфйн бйп 2 м20 йа гбт");
    DerbyMaxP = maxp;
    Derby = 1;
    SendClientMessageToAll(-1, "/Join :фтймеъ дгшбй дзмд - тм оръ мдцишу дчщ");
    DerbyTimer[0] = SetTimer("DerbyGame", 15000, 0);
    return 1;
} 
DerbyGame public (Where it teleports everyone to their cars)
PHP код:
forward DerbyGame();
public DerbyGame()
{
    if(JoinedDerby < 2)
    {
        foreach(new i : Player)
        {
            if(DerbyKicked[i]) DerbyKicked[i] = 0;
            if(DerbyPlayer[i]) DerbyPlayer[i] = 0;
        }
        JoinedDerby = 0;
        DerbyMaxP = 0;
        SendClientMessageToAll(-1, ".йа жереъ фтн дбад ълрсе, дгшбй беим чцъ ойгй ощъъфйн");
        Derby = 0;
        for(new timer = 0; timer < 3; timer++) KillTimer(DerbyTimer[timer]);
    }
    for(new veh = 0; veh < 20; veh++) SetVehicleToRespawn(DerbyVehicle[veh]);
    foreach(new i : Player)
    {
        if(DerbyPlayer[i])
        {
            for(new j = 0; j < 20; j++)
            {
                if(IsVehicleOccupied(DerbyVehicle[j])) continue;
                 PutPlayerInVehicle(i, DerbyVehicle[j], 0); // This doesn't work
                TogglePlayerControllable(i, 0);
                SendClientMessage(i, -1, ".дщъвшъ мфтймеъ дгшбй йа лелб, 10 щрйеъ ъщъзшш оддчфад");
                break;
            }
        }
    }
    Derby = 2;
    DerbyTimer[1] = SetTimer("StartDerby", 10000, 0);
    return 1;
} 
IsVehicleOccupied
PHP код:
stock IsVehicleOccupied(vehicleid)
{
    foreach(new i : Player)
    {
        if(IsPlayerConnected(i))
        {
            if(GetPlayerVehicleID(i) == vehicleid && GetPlayerVehicleSeat(i) == 0) return true;
        }
    }
    return false;
} 


Re: PutPlayerInVehicle BUG - thefirestate - 09.09.2016

Can you replace your code with this one:

Код:
for(new j = 0; j < 20; j++) 
            { 
                if(!IsVehicleOccupied(DerbyVehicle[j]))
                {
                    PutPlayerInVehicle(i, DerbyVehicle[j], 0); 
                    TogglePlayerControllable(i, 0); 
                    SendClientMessage(i, -1, ".дщъвшъ мфтймеъ дгшбй йа лелб, 10 щрйеъ ъщъзшш оддчфад"); 
                    break;
                }
            }
If it doesn't work try print out the values of DerbyVehicle[j] and the other variable you use to try and find if you are lacking required information.

Re: PutPlayerInVehicle BUG - NeXoR - 09.09.2016

Quote:
Originally Posted by thefirestate
Посмотреть сообщение
Can you replace your code with this one:

Код:
for(new j = 0; j < 20; j++) 
            { 
                if(!IsVehicleOccupied(DerbyVehicle[j]))
                {
                    PutPlayerInVehicle(i, DerbyVehicle[j], 0); 
                    TogglePlayerControllable(i, 0); 
                    SendClientMessage(i, -1, ".дщъвшъ мфтймеъ дгшбй йа лелб, 10 щрйеъ ъщъзшш оддчфад"); 
                    break;
                }
            }
If it doesn't work try print out the values of DerbyVehicle[j] and the other variable you use to try and find if you are lacking required information.
At first it was your code, and then I edited it to the current version (with the continue;)
I tried debugging it in every possible way, nothing popped up.

Re: PutPlayerInVehicle BUG - thefirestate - 09.09.2016

When is this DerbyPlayer[i] changed to a value higher than 0? Also, do you get frozen or nothing under the code there gets executed? No SCM, no PutPlayerInVehicle, no TogglePlayerControllable nothing from these functions?

Re: PutPlayerInVehicle BUG - NeXoR - 09.09.2016

Quote:
Originally Posted by thefirestate
Посмотреть сообщение
When is this DerbyPlayer[i] changed to a value higher than 0? Also, do you get frozen or nothing under the code there gets executed? No SCM, no PutPlayerInVehicle, no TogglePlayerControllable nothing from these functions?
Alright, I tried debugging it
When I tried to print DerbyVehicle[j] it told me "(null)" like the vehicle doesn't exist
And when I printed "j" it told me "0" like it's 0

The rest of the code works, SCM & Toggle works.

Debug code:
PHP код:
for(new vehicle = 0; vehicle < 20; vehicle++)
            {
                if(IsVehicleOccupied(DerbyVehicle[vehicle])) continue;
                print(DerbyVehicle[vehicle]);
                printf("id: %d", vehicle); 
Console:
Код:
[04:24:50] (null) -- playerid 0
[04:24:50] id: 0  -- playerid 0
[04:24:50] (null) -- playerid 1
[04:24:50] id: 0 -- playerid 1


Re: PutPlayerInVehicle BUG - thefirestate - 09.09.2016

And that is showed for all 20 vehicles?

Re: PutPlayerInVehicle BUG - NeXoR - 09.09.2016

Quote:
Originally Posted by thefirestate
Посмотреть сообщение
And that is showed for all 20 vehicles?
It looks like it doesn't detect DerbyVehicle[vehicle] as a vehicleid.
I tried doing DerbyVehicle[0] and it teleported me to the vehicle

Re: PutPlayerInVehicle BUG - thefirestate - 09.09.2016

What would happen if you try to end the loop with return instead of break?