SA-MP Forums Archive
GetClosestVehicle - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: GetClosestVehicle (/showthread.php?tid=612135)


GetClosestVehicle - Jonesy96 - 14.07.2016

Hi all,

I have the following command:

Код:
stock GetClosestVehicle(playerid, Float:range){
    new Float:p_X;
    new Float:p_Y;
    new Float:p_Z;

    new Float:Distance;
    new Float:PretendentDistance = range +1;
    new Pretendent;

    GetPlayerPos(playerid, p_X, p_Y, p_Z);

    for(new vehicleid=1; vehicleid < MAX_VEHICLES; vehicleid++){
        Distance = GetVehicleDistanceFromPoint(vehicleid, p_X, p_Y, p_Z);

        if(Distance <= range && Distance <= PretendentDistance){
            Pretendent = vehicleid;
            PretendentDistance = Distance;
        }
    }

    return Pretendent;
}


new vehicleid = GetClosestVehicle(playerid, 10.0);
However, unfortunately when I print the contents of vehicleid on executing the command right next to a vehicle, it only prints the value of 0, which means this isn't working.

Pulling my hair out with this...any ideas?

Re: GetClosestVehicle - Stinged - 14.07.2016

You should start using GetVehiclePoolSize (Unless you're not using SA-MP 0.3.7)
It retrieves the highest vehicle ID, so instead of 2000 (MAX_VEHICLES), you'd be using something much lower if there isn't a lot of vehicles.

I just wrote this, so I'm not sure if it has any bugs or not.
Код:
native IsValidVehicle(vehicleid); // According to the wiki, it doesn't exist in the default sa-mp includes, so you have to add it.

GetClosestVehicle(playerid, Float: range)
{
    new
        vehicleid = -1,
        Float: last = range,
        Float: current,
        
        Float: x, Float: y, Float: z;
    GetPlayerPos(playerid, x, y, z);
    for (new i = 1, j = GetVehiclePoolSize(); i <= j; i++) // for (new i = 1; i < MAX_VEHICLES; i++)
    {
        if (!IsValidVehicle(i)) continue;
        current = GetVehicleDistanceFromPoint(i, x, y, z);
        if (current < last)
        {
            vehicleid = i;
            last = current;
        }
    }
    return vehicleid;
}


Re: GetClosestVehicle - Luicy. - 14.07.2016

PHP код:
native IsValidVehicle(vehicleid);
GetClosestVehicle(playerid, Float:range) {
   new Float:VehiclePos[4], nearestID;
   nearestID = 65535;
   for(new vehicleid = 0; vehicleid < MAX_VEHICLES; vehicleid++) {
      if(IsValidVehicle(vehicleid)) {
         GetVehiclePos(vehicleid, VehiclePos[1], VehiclePos[2], VehiclePos[3]);
         if(IsPlayerInRangeOfPoint(playerid, range, VehiclePos[1], VehiclePos[2], VehiclePos[3])) {
            nearestID = vehicleid;
            break;
         }
      }
   }
   return nearestID;
} 


Re: GetClosestVehicle - Jonesy96 - 14.07.2016

Quote:
Originally Posted by Stinged
Посмотреть сообщение
You should start using GetVehiclePoolSize (Unless you're not using SA-MP 0.3.7)
It retrieves the highest vehicle ID, so instead of 2000 (MAX_VEHICLES), you'd be using something much lower if there isn't a lot of vehicles.

I just wrote this, so I'm not sure if it has any bugs or not.
Код:
native IsValidVehicle(vehicleid); // According to the wiki, it doesn't exist in the default sa-mp includes, so you have to add it.

GetClosestVehicle(playerid, Float: range)
{
    new
        vehicleid = -1,
        Float: last = range,
        Float: current,
        
        Float: x, Float: y, Float: z;
    GetPlayerPos(playerid, x, y, z);
    for (new i = 1, j = GetVehiclePoolSize(); i <= j; i++) // for (new i = 1; i < MAX_VEHICLES; i++)
    {
        if (!IsValidVehicle(i)) continue;
        current = GetVehicleDistanceFromPoint(i, x, y, z);
        if (current < last)
        {
            vehicleid = i;
            last = current;
        }
    }
    return vehicleid;
}

Thank you, great help. Didn't know about GetVehiclePoolSize, thanks!

Thanks everyone else.

Re: GetClosestVehicle - Konstantinos - 14.07.2016

If enabling camera target (EnablePlayerCameraTarget), retrieving the closest vehicle (GetPlayerCameraTargetVehicle) and then disabling the camera target would be possible, that would be great and we wouldn't even need a loop. Unfortunately, it has to be enabled on connect otherwise it returns INVALID_VEHICLE_ID (just tested it).

Re: GetClosestVehicle - Jonesy96 - 14.07.2016

Quote:
Originally Posted by Konstantinos
Посмотреть сообщение
If enabling camera target (EnablePlayerCameraTarget), retrieving the closest vehicle (GetPlayerCameraTargetVehicle) and then disabling the camera target would be possible, that would be great and we wouldn't even need a loop. Unfortunately, it has to be enabled on connect otherwise it returns INVALID_VEHICLE_ID (just tested it).
That's very interesting actually. I may use this, as I have another system in mind (A type of LSPD dashcam) where this could be quite useful!