Giving money with mysql query has no effect

Giving money with mysql query has no effect - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Giving money with mysql query has no effect (/showthread.php?tid=609508)

Giving money with mysql query has no effect - bartje01 - 13.06.2016

Hello everyone,

I've been out of scripting sa-mp for years now. I would like to get back into it a littlebit to play around with MySQL.
Now I am trying to give money to a player with the following function:

Код:

forward updateStats(playerid);
public updateStats(playerid)
{
    new query[128], playername[MAX_PLAYER_NAME];
    GetPlayerName(playerid, playername, sizeof(playername));
    mysql_format(mysql, query, sizeof(query), "SELECT `Money` FROM `accounts` WHERE `Name` = '%e' LIMIT 1", playername);
    mysql_tquery(mysql, query, "", "i", playerid);
    Player[playerid][Money] = cache_get_field_content_int(0, "Money");
	GivePlayerMoney(playerid, Player[playerid][Money]);
	SendClientMessage(playerid, -1, "Updated");
    return 1;
}

Now it does send the client message, but it doesn't give the player his money. Is there something wrong with the query or perhaps the mysql_tquery?

Thanks in advance

Re: Giving money with mysql query has no effect - F1N4L - 13.06.2016

Код:

forward updateStats(playerid);
public updateStats(playerid)
{
    new query[128], playername[MAX_PLAYER_NAME];
    GetPlayerName(playerid, playername, sizeof(playername));
    mysql_format(mysql, query, sizeof(query), "SELECT `Money` FROM `accounts` WHERE `Name` = '%s' LIMIT 1", playername);
    mysql_query(mysql, query);
    if(cache_num_rows())
   {
        Player[playerid][Money] = cache_get_field_content_int(0, "Money");
	GivePlayerMoney(playerid, Player[playerid][Money]);
	SendClientMessage(playerid, -1, "Updated");
    }
    return 1;
}

Re: Giving money with mysql query has no effect - bartje01 - 13.06.2016

Quote:

Originally Posted by F1N4L

Код:

forward updateStats(playerid);
public updateStats(playerid)
{
    new query[128], playername[MAX_PLAYER_NAME];
    GetPlayerName(playerid, playername, sizeof(playername));
    mysql_format(mysql, query, sizeof(query), "SELECT `Money` FROM `accounts` WHERE `Name` = '%s' LIMIT 1", playername);
    mysql_query(mysql, query);
    if(cache_num_rows())
   {
        Player[playerid][Money] = cache_get_field_content_int(0, "Money");
	GivePlayerMoney(playerid, Player[playerid][Money]);
	SendClientMessage(playerid, -1, "Updated");
    }
    return 1;
}

Aah, great!

This also makes much more sense to me.

Thanks!

Re: Giving money with mysql query has no effect - Konstantinos - 13.06.2016

mysql_tquery needs a callback to call the cache functions there otherwise using it directly will results in warnings for no active cache.

I can't understand the purpose of your code though. Why don't you simply give the money once when the login?

@F1N4L: You should store the cache result id and at the end to delete it to avoid memory leaks. Non-threaded queries are not very recommended either.

Re: Giving money with mysql query has no effect - F1N4L - 13.06.2016

Quote:

Originally Posted by Konstantinos

@F1N4L: You should store the cache result id and at the end to delete it to avoid memory leaks. Non-threaded queries are not very recommended either.

Could you give me an example? Are you suggesting a loop?
I use this way, I have no problems, but if there is a safer way to get the values in the DB ...

Re: Giving money with mysql query has no effect - Konstantinos - 13.06.2016

Quote:

Originally Posted by F1N4L

Could you give me an example? Are you suggesting a loop?
I use this way, I have no problems, but if there is a safer way to get the values in the DB ...

Non-threaded queries: https://sampwiki.blast.hk/wiki/MySQL/R33#mysql_query
Threaded queries: https://sampwiki.blast.hk/wiki/MySQL/R33#mysql_tquery

Re: Giving money with mysql query has no effect - bartje01 - 13.06.2016

Quote:

Originally Posted by Konstantinos

mysql_tquery needs a callback to call the cache functions there otherwise using it directly will results in warnings for no active cache.

I can't understand the purpose of your code though. Why don't you simply give the money once when the login?

@F1N4L: You should store the cache result id and at the end to delete it to avoid memory leaks. Non-threaded queries are not very recommended either.

Well, I want a live update on my server. So if the money gets updated from an external way (from a website by example) it should automatically change ingame as well. Don't want the player to have to logout first.