Help with my garage system - Printable Version

Help with my garage system - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Help with my garage system (/showthread.php?tid=601239)

Help with my garage system - Hellman92 - 18.02.2016

I get this idk what i am doing wrong

Код:

C:\Users\Nate\Desktop\test\gamemodes\test.pwn(6517 -- 6530) : warning 213: tag mismatch
C:\Users\Nate\Desktop\test\gamemodes\test.pwn(6517 -- 6530) : error 032: array index out of bounds (variable "GarageInfo")

PHP код:



enum gInfo

{

    gEnterX,

    gEnterY,

    gEnterZ,

    gEnterAngle,

    gExitX,

    gExitY,

    gExitZ,

    gExitAngle,

    gOwned,

    gOwner,

    gPrice,

    gLocked,

    gPickupID

};

new GarageInfo[SCRIPT_MAXGARGES][gInfo];

PHP код:



public SaveGarage()

{

    new idx, File: file2, coordsstring[256];

    while (idx < sizeof(GarageInfo))

    {

        format(coordsstring, sizeof(coordsstring), "%f|%f|%f|%f|%f|%f|%f|%f|%d|%s|%d|%d\n",

        GarageInfo[idx][gEnterX],

        GarageInfo[idx][gEnterY],

        GarageInfo[idx][gEnterZ],

        GarageInfo[idx][gEnterAngle],

        GarageInfo[idx][gExitX],

        GarageInfo[idx][gExitY],

        GarageInfo[idx][gExitZ],

        GarageInfo[idx][gExitAngle],

        GarageInfo[idx][gOwned],

        GarageInfo[idx][gOwner],

        GarageInfo[idx][gPrice],

        GarageInfo[idx][gLocked],

        GarageInfo[idx][hPickupID]);

        if(idx == 0) file2 = fopen("garage.ini", io_write);

        else file2 = fopen("garage.ini", io_append);

        fwrite(file2, coordsstring);

        idx++;

        fclose(file2);

    }

    return 1;

}

PHP код:



public LoadGarage()

{

    printf("Loading Garages...");

    new arrCoords[13][64], strFromFile2[256];

    new File: file = fopen("garage.ini", io_read);

    if (file)

    {

        new idx;

        while (idx < sizeof(GarageInfo))

        {

            fread(file, strFromFile2);

            split(strFromFile2, arrCoords, ',');

            GarageInfo[idx][gEnterX] = floatstr(arrCoords[0]);

            GarageInfo[idx][gEnterY] = floatstr(arrCoords[1]);

            GarageInfo[idx][gEnterZ] = floatstr(arrCoords[2]);

            GarageInfo[idx][gEnterAngle] = floatstr(arrCoords[3]);

            GarageInfo[idx][gExitX] = floatstr(arrCoords[4]);

            GarageInfo[idx][gExitY] = floatstr(arrCoords[5]);

            GarageInfo[idx][gExitZ] = floatstr(arrCoords[6]);

            GarageInfo[idx][gExitAngle] = floatstr(arrCoords[7]);

            GarageInfo[idx][gOwned] = strval(arrCoords[8]);

            strmid(GarageInfo[idx][gOwner], arrCoords[9], 0, strlen(arrCoords[9]), 255);

            GarageInfo[idx][gPrice] = strval(arrCoords[10]);

            GarageInfo[idx][gLocked] = strval(arrCoords[11]);

            GarageInfo[idx][gPickupID] = strval(arrCoords[12]);

            idx++;

        }

    }

    fclose(file);

    return 1;

}

Re: Help with my garage system - xTURBOx - 19.02.2016

Not sure but try this

PHP код:



enum gInfo
{
    gEnterX,
    gEnterY,
    gEnterZ,
    gEnterAngle,
    gExitX,
    gExitY,
    gExitZ,
    gExitAngle,
    gOwned,
    gOwner,
    gPrice,
    gLocked,
    gPickupID,
};
new GarageInfo[SCRIPT_MAXGARGES][gInfo];

Re: Help with my garage system - -CaRRoT - 19.02.2016

Код:

gOwner

is a string, should be

Код:

gOwner[MAX_PLAYER_NAME],

You also need to add Float: infront of these vars

Код:

    gEnterX, 
    gEnterY, 
    gEnterZ, 
    gEnterAngle, 
    gExitX, 
    gExitY, 
    gExitZ, 
    gExitAngle,

Plus you really should code it yourself instead of copying another system and changing the vars as it wont teach you anything.

Код:

GarageInfo[idx][hPickupID]);

Clearly copied from a house system, you didnt switch the h with a g

Re: Help with my garage system - Vince - 19.02.2016

I want to add that it is terrible practice to open and close the file for each line written. This leads to lots of unnecessary IO and it is very slow. Open file, loop, close files. The structure also does not follow the INI file format so it shouldn't realistically have the extension .ini, either.

Re: Help with my garage system - NelsonM - 19.02.2016

You miss the size on gEnter's, you are using the floatstr function and you need to put the string size in the enum:
gEnterX[16]
Or you just change the savesystem and put Float: before the vars un the enum. Sorry my english hahaha

Re: Help with my garage system - Hellman92 - 19.02.2016

Quote:

Originally Posted by Hellman92

Like this?

PHP код:



Float:gEnterX,

Quote:

Originally Posted by Vince

I want to add that it is terrible practice to open and close the file for each line written. This leads to lots of unnecessary IO and it is very slow. Open file, loop, close files. The structure also does not follow the INI file format so it shouldn't realistically have the extension .ini, either.

So how should be it done then?

Quote:

Originally Posted by -CaRRoT

Код:

gOwner

is a string, should be

Код:

gOwner[MAX_PLAYER_NAME],

You also need to add Float: infront of these vars

Код:

    gEnterX, 
    gEnterY, 
    gEnterZ, 
    gEnterAngle, 
    gExitX, 
    gExitY, 
    gExitZ, 
    gExitAngle,

Plus you really should code it yourself instead of copying another system and changing the vars as it wont teach you anything.

Код:

GarageInfo[idx][hPickupID]);

Clearly copied from a house system, you didnt switch the h with a g

I copy my own house system and convert into a garage system lol.

Re: Help with my garage system - Vince - 19.02.2016

Quote:

Originally Posted by Hellman92

So how should be it done then?

Open file before loop. Do the entire loop. Close the file after loop. I reckon my earlier instructions were pretty straightforward.

Re: Help with my garage system - Hellman92 - 19.02.2016

Quote:

Originally Posted by Vince

Open file before loop. Do the entire loop. Close the file after loop. I reckon my earlier instructions were pretty straightforward.

Okey but i did not understand to 100 but now i get it thanks!