SA-MP Forums Archive
SaveAccount taking too long time - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: SaveAccount taking too long time (/showthread.php?tid=600746)


SaveAccount taking too long time - Terrorizt - 12.02.2016

Hi everyone, I had a problem which is whenever the player dies / changes his name or anything with SaveAccount in it. It takes like 5 - 7 seconds to be done and i hate this. Is there anyway to make it faster? here is the SaveAccount code:
Код:
stock File__SaveAccount(playerid)
{
	if(PLAYERLIST_authed[playerid] == 0) return 1;
	new pname[24];
    GetPlayerName(playerid, pname, 24);
	if(PLAYERLIST_authed[playerid])
	{
		new query[750];
		format(query, sizeof(query), "UPDATE PlayerInfo SET bank=%d WHERE user='%s'", PlayerInfo[playerid][bank], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET curmoney=%d WHERE user='%s'", PlayerTemp[playerid][sm], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET playerlvl=%d WHERE user='%s'", PlayerInfo[playerid][playerlvl], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET rpoints=%d WHERE user='%s'", PlayerInfo[playerid][rpoints], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET playertime=%d WHERE user='%s'", PlayerInfo[playerid][playertime], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET jail=%d WHERE user='%s'", PlayerInfo[playerid][jail], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET jailreason='%s' WHERE user='%s'", PlayerInfo[playerid][jailreason], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET jailtime=%d WHERE user='%s'", PlayerInfo[playerid][jailtime], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET banned=%d WHERE user='%s'", PlayerInfo[playerid][banned], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET banreason='%s' WHERE user='%s'", PlayerInfo[playerid][banreason], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET whobannedme='%s' WHERE user='%s'", PlayerInfo[playerid][whobannedme], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET whenigotbanned='%s' WHERE user='%s'", PlayerInfo[playerid][whenigotbanned], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET forumname='%s' WHERE user='%s'", PlayerInfo[playerid][forumname], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET Skin=%d WHERE user='%s'", PlayerInfo[playerid][Skin], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET ranklvl=%d WHERE user='%s'", PlayerInfo[playerid][ranklvl], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET rentprice=%d WHERE user='%s'", PlayerInfo[playerid][rentprice], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET driverlic=%d WHERE user='%s'", PlayerInfo[playerid][driverlic], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET flylic=%d WHERE user='%s'", PlayerInfo[playerid][flylic], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET boatlic=%d WHERE user='%s'", PlayerInfo[playerid][boatlic], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET weaplic=%d WHERE user='%s'", PlayerInfo[playerid][weaplic], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET jobtime=%d WHERE user='%s'", PlayerInfo[playerid][jobtime], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET jobskill=%d WHERE user='%s'", PlayerInfo[playerid][jobskill], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET totalpayt=%d WHERE user='%s'", PlayerInfo[playerid][totalpayt], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET pbkills=%d WHERE user='%s'", PlayerInfo[playerid][pbkills], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET pbdeaths=%d WHERE user='%s'", PlayerInfo[playerid][pbdeaths], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET housenum=%d WHERE user='%s'", PlayerInfo[playerid][housenum], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET loan=%d WHERE user='%s'", PlayerInfo[playerid][loan], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET guns=%d WHERE user='%s'", PlayerInfo[playerid][guns], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET sguns=%d WHERE user='%s'", PlayerInfo[playerid][sguns], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET sdrugs=%d WHERE user='%s'", PlayerInfo[playerid][sdrugs], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET power=%d WHERE user='%s'", PlayerInfo[playerid][power], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET female=%d WHERE user='%s'", PlayerInfo[playerid][female], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET ethnic=%d WHERE user='%s'", PlayerInfo[playerid][ethnic], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET bail=%d WHERE user='%s'", PlayerInfo[playerid][bail], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET premium=%d WHERE user='%s'", PlayerInfo[playerid][premium], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET gotphone=%d WHERE user='%s'", PlayerInfo[playerid][gotphone], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET phonenumber=%d WHERE user='%s'", PlayerInfo[playerid][phonenumber], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET phonebook=%d WHERE user='%s'", PlayerInfo[playerid][phonebook], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET laptop=%d WHERE user='%s'", PlayerInfo[playerid][laptop], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET age=%d WHERE user='%s'", PlayerInfo[playerid][age], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET premiumexpire=%d WHERE user='%s'", PlayerInfo[playerid][premiumexpire], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET playerteam=%d WHERE user='%s'", PlayerInfo[playerid][playerteam], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET radio=%d WHERE user='%s'", PlayerInfo[playerid][radio], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET freq1=%d WHERE user='%s'", PlayerInfo[playerid][freq1], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET freq2=%d WHERE user='%s'", PlayerInfo[playerid][freq2], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET freq3=%d WHERE user='%s'", PlayerInfo[playerid][freq3], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET tutorial=%d WHERE user='%s'", PlayerInfo[playerid][tutorial], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET tbanned=%d WHERE user='%s'", PlayerInfo[playerid][tbanned], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET city='%s' WHERE user='%s'", PlayerInfo[playerid][city], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET PTeamName='%s' WHERE user='%s'", PlayerInfo[playerid][PTeamName], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET job='%s' WHERE user='%s'", PlayerInfo[playerid][job], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET totalruns=%d WHERE user='%s'", PlayerInfo[playerid][totalruns], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET fpay=%d WHERE user='%s'", PlayerInfo[playerid][fpay], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET warns=%d WHERE user='%s'", PlayerInfo[playerid][warns], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET helper=%d WHERE user='%s'", PlayerInfo[playerid][helper], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET curfreq=%d WHERE user='%s'", PlayerInfo[playerid][curfreq], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET rankname='%s' WHERE user='%s'", PlayerInfo[playerid][rankname], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET phonechanges=%d WHERE user='%s'", PlayerInfo[playerid][phonechanges], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET namechanges=%d WHERE user='%s'", PlayerInfo[playerid][namechanges], pname);
		mysql_query(query);
 		format(query, sizeof(query), "UPDATE PlayerInfo SET lastonline='%s' WHERE user='%s'", TimeDate(), pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET iPod=%d WHERE user='%s'", PlayerInfo[playerid][iPod], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET finvite='%d' WHERE user='%s'", PlayerInfo[playerid][finvite], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET fradio='%d' WHERE user='%s'", PlayerInfo[playerid][fradio], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET fstock='%d' WHERE user='%s'", PlayerInfo[playerid][fstock], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET fwarehouse='%d' WHERE user='%s'", PlayerInfo[playerid][fwarehouse], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET fweplic='%d' WHERE user='%s'", PlayerInfo[playerid][fweplic], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET fbarrier='%d' WHERE user='%s'", PlayerInfo[playerid][fwarehouse], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET tracker='%d' WHERE user='%s'", PlayerInfo[playerid][tracker], pname);
		mysql_query(query);
        format(query, sizeof(query), "UPDATE PlayerInfo SET fbk='%d' WHERE user='%s'", PlayerInfo[playerid][fbk], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET bslot='%d' WHERE user='%s'", PlayerInfo[playerid][bslot], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET vslot='%d' WHERE user='%s'", PlayerInfo[playerid][vslot], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET hslot='%d' WHERE user='%s'", PlayerInfo[playerid][hslot], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET dealer=%d WHERE user='%s'", PlayerInfo[playerid][dealer], pname);
		mysql_query(query);
  		format(query, sizeof(query), "UPDATE PlayerInfo SET accent='%s' WHERE user='%s'", PlayerInfo[playerid][accent], pname);
		mysql_query(query);
   		format(query, sizeof(query), "UPDATE PlayerInfo SET togspawn='%d' WHERE user='%s'", PlayerTemp[playerid][togspawn], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET spawnX='%f' WHERE user='%s'", PlayerInfo[playerid][spawnX], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET spawnY='%f' WHERE user='%s'", PlayerInfo[playerid][spawnY], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET spawnZ='%f' WHERE user='%s'", PlayerInfo[playerid][spawnZ], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET spawnINT='%d' WHERE user='%s'", PlayerInfo[playerid][spawnINT], pname);
		mysql_query(query);
		format(query, sizeof(query), "UPDATE PlayerInfo SET spawnVW='%d' WHERE user='%s'", PlayerInfo[playerid][spawnVW], pname);
		mysql_query(query);
		
		new iString[ 50 ], tmp[ 10 ];
	    for(new c = 0; c < sizeof(drugtypes); c++)
		{
		    format(tmp,sizeof(tmp),"%d,", PlayerInfo[playerid][hasdrugs][c]);
		    strcat(iString,tmp);
		}
		strdel(iString,strlen(iString)-1, strlen(iString));
		format(query, sizeof(query), "UPDATE `PlayerInfo` SET `hasdrugs` = '%s' WHERE `user` = '%s'", iString, pname);
		mysql_query(query);
	}
    return 1;
}


Re: SaveAccount taking too long time - Morpheine - 12.02.2016

All this query are used? If aren't used remove them, try to update your mysql to r39-4.

Re: SaveAccount taking too long time - SecretBoss - 12.02.2016

What The Hell is that, you make a query to save one variable while you can save all of them with just one query

Here is a correct usage (Not made by me)

Код:
SaveData(playerid)
{
	new query[2500];
	format(query, sizeof(query), "UPDATE `accounts` SET");
	format(query, sizeof(query), "%s `score` = '%d',", query, Data[playerid][Score]);
	format(query, sizeof(query), "%s `kills` = '%d',", query, Data[playerid][Kills]);
	format(query, sizeof(query), "%s `deaths` = '%d',", query, Data[playerid][Deaths]);
	format(query, sizeof(query), "%s `money` = '%d',", query, Data[playerid][Money]);

	mysql_format(connection, query, sizeof(query), "%s", query);
	mysql_query(connection, query, false);
	return 1;
}


Re: SaveAccount taking too long time - Vince - 12.02.2016

That's what you get for treating SQL like a simple filesystem. And I could probably go on and on and on. Use it right or don't use it all otherwise it's going to give you more problems than it's worth.

Re: SaveAccount taking too long time - Terrorizt - 12.02.2016

So it took me like 1 hour or 30 minutes to put all of them in 1 query:
Код:
stock File__SaveAccount(playerid)
{
	if(PLAYERLIST_authed[playerid] == 0) return 1;
	new pname[24];
    GetPlayerName(playerid, pname, 24);
	if(PLAYERLIST_authed[playerid])
	{
		new query[750];
		format(query, sizeof(query), "UPDATE PlayerInfo SET bank=%d, curmoney=%d, playerlvl=%d, rpoints=%d, playertime=%d, jail=%d, jailreason='%s', jailtime=%d banned=%d, banreason='%s', whobannedme='%s', whenigotbanned='%s', forumname='%s', Skin=%d, ranklvl=%d, rentprice=%d, driverlic=%d, flylic=%d, boatlic=%d, weaplic=%d, jobtime=%d, totalpayt=%d, pbkills=%d, pbdeaths=%d, housenum=%d, loan=%d, guns=%d, sguns=%d, sdrugs=%d, power=%d, female=%d, ethnic=%d, bail=%d, premium=%d, gotphone=%d, phonenumber=%d, phonebook=%d, laptop=%d, age=%d , premiumexpire=%d, playerteam=%d, radio=%d, freq1=%d, freq2=%d, freq3=%d, tutorial=%d, tbanned=%d, city='%s', PTeamName='%s',job='%s', totalruns=%d, fpay=%d, warns=%d, helper=%d, curfreq=%d, rankname='%s', phonechanges=%d, namechanges=%d,lastonline='%s', iPod=%d, finvite='%d', fradio='%d', fstock='%d', fwarehouse='%d', fweplic='%d', fbarrier='%d',tracker='%d', fbk='%d', bslot='%d', vslot='%d', hslot='%d', dealer=%d, accent='%s', togspawn='%d', spawnX='%f',spawnY='%f',spawnZ='%f',spawnINT='%d', spawnVW='%d' WHERE user='%s'", PlayerInfo[playerid][bank],PlayerTemp[playerid][sm],PlayerInfo[playerid][playerlvl],PlayerInfo[playerid][rpoints],PlayerInfo[playerid][playertime],PlayerInfo[playerid][jail], PlayerInfo[playerid][jailreason], PlayerInfo[playerid][jailtime],PlayerInfo[playerid][banned],PlayerInfo[playerid][banreason],PlayerInfo[playerid][whobannedme],PlayerInfo[playerid][whenigotbanned],PlayerInfo[playerid][forumname],PlayerInfo[playerid][Skin],PlayerInfo[playerid][ranklvl], PlayerInfo[playerid][rentprice], PlayerInfo[playerid][driverlic],PlayerInfo[playerid][flylic], PlayerInfo[playerid][boatlic], PlayerInfo[playerid][weaplic],PlayerInfo[playerid][jobtime], PlayerInfo[playerid][jobskill], PlayerInfo[playerid][totalpayt],PlayerInfo[playerid][pbkills], PlayerInfo[playerid][pbdeaths], PlayerInfo[playerid][housenum], PlayerInfo[playerid][loan], PlayerInfo[playerid][guns], PlayerInfo[playerid][sguns], PlayerInfo[playerid][sdrugs] PlayerInfo[playerid][power], PlayerInfo[playerid][female], PlayerInfo[playerid][ethnic], PlayerInfo[playerid][bail], PlayerInfo[playerid][premium], PlayerInfo[playerid][gotphone], PlayerInfo[playerid][phonenumber], PlayerInfo[playerid][phonebook], PlayerInfo[playerid][laptop], PlayerInfo[playerid][age], PlayerInfo[playerid][premiumexpire], PlayerInfo[playerid][playerteam],PlayerInfo[playerid][radio], PlayerInfo[playerid][freq1], PlayerInfo[playerid][freq2], PlayerInfo[playerid][freq3],PlayerInfo[playerid][tutorial], PlayerInfo[playerid][tbanned],PlayerInfo[playerid][city],PlayerInfo[playerid][PTeamName],PlayerInfo[playerid][job], PlayerInfo[playerid][totalruns], PlayerInfo[playerid][fpay],PlayerInfo[playerid][warns], PlayerInfo[playerid][helper],PlayerInfo[playerid][curfreq], PlayerInfo[playerid][rankname], PlayerInfo[playerid][phonechanges], PlayerInfo[playerid][namechanges], TimeDate(), PlayerInfo[playerid][iPod], PlayerInfo[playerid][finvite], PlayerInfo[playerid][fradio], PlayerInfo[playerid][fstock], PlayerInfo[playerid][fwarehouse],PlayerInfo[playerid][fweplic],PlayerInfo[playerid][fwarehouse],PlayerInfo[playerid][tracker], PlayerInfo[playerid][fbk],PlayerInfo[playerid][bslot],PlayerInfo[playerid][vslot],PlayerInfo[playerid][hslot],PlayerInfo[playerid][dealer], PlayerInfo[playerid][accent],PlayerTemp[playerid][togspawn],PlayerInfo[playerid][spawnX], PlayerInfo[playerid][spawnY],PlayerInfo[playerid][spawnZ], PlayerInfo[playerid][spawnINT],PlayerInfo[playerid][spawnVW], pname);
		mysql_query(query);


		new iString[ 50 ], tmp[ 10 ];
	    for(new c = 0; c < sizeof(drugtypes); c++)
		{
		    format(tmp,sizeof(tmp),"%d,", PlayerInfo[playerid][hasdrugs][c]);
		    strcat(iString,tmp);
		}
		strdel(iString,strlen(iString)-1, strlen(iString));
		format(query, sizeof(query), "UPDATE `PlayerInfo` SET `hasdrugs` = '%s' WHERE `user` = '%s'", iString, pname);
		mysql_query(query);
	}
    return 1;
}
I'm getting these errors, can anyone fix this? help:
Код:
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18407) : error 075: input line too long (after substitutions)
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18408) : error 037: invalid string (possibly non-terminated string)
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18408) : error 017: undefined symbol "UPDATE"
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18408) : warning 215: expression has no effect
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18408) : error 001: expected token: ";", but found "-identifier-"
C:\Users\Asser\Desktop\CMRP\gamemodes\CMRP.pwn(18408) : fatal error 107: too many error messages on one line

Compilation aborted.Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


5 Errors.


Re: SaveAccount taking too long time - Terrorizt - 12.02.2016

Quote:
Originally Posted by Vince
Посмотреть сообщение
That's what you get for treating SQL like a simple filesystem.
  • Using a query for each variable
  • Not using threaded queries
  • Using the name as the key instead of the id
  • Probably not having an index on the name either = full table scan = much slower queries
  • Saving multiple values in one columns (drugs) = seriously not done => different table
  • Saving too many variables at on‌ce => update as needed!
  • Having too many columns in one table => split up into association tables (e.g. User ↔ License ↔ LicenseType)
  • ...
And I could probably go on and on and on. Use it right or don't use it all otherwise it's going to give you more problems than it's worth.
Can you give me the fix please? cuze i didn't get a single thing of what you said xd
EDIT: I deleted all mysql_query(query); and put only one. It is no longer slow but does this affect something?

Re: SaveAccount taking too long time - AmigaBlizzard - 12.02.2016

Only update what needs to be updated ==> if your server-variable changes, use a small query to update that value in the database too.

Don't update 100 values in the database when only 1 value changes.

For a file-system, yes, you NEED to do that, because you probably need to overwrite the entire file.

But you're using a DATABASE, which has the possibility to change value per value.

I always get furious when people use such huge queries for saving everything at once, and then they complain why it's so slow or they get silly errors, just because they didn't see a little mistake like a misplaced comma or whatever.
But they get those errors because their query is a huge block of text and you can't spot the error by just looking at it.

Split your query over your entire gamemode and use functions to make it easier.

http://forum.sa-mp.com/showpost.php?...31&postcount=5

This is an example from my own code.
Instead of using GivePlayerMoney, I'm using that function listed there.
It changes the values in the server-memory and it also updates the correct values in the database using a small query.

It's very easy to debug and easy to follow and you won't make mistakes that often.

It also uses threaded queries, so it doesn't slow down the script at all, not even when this function is called every second per player for example (that won't happen anyway because nobody's money should change that often).
Threaded queries are executed in the background and don't let your script wait until the query has been executed completely.

Re: SaveAccount taking too long time - Sew_Sumi - 12.02.2016

When you don't understand something, you'd be best to ****** it, and read up on it.

Quote:
Originally Posted by Vince
Посмотреть сообщение
That's what you get for treating SQL like a simple filesystem.
  • Using a query for each variable
  • Not using threaded queries
  • Using the name as the key instead of the id
  • Probably not having an index on the name either = full table scan = much slower queries
  • Saving multiple values in one columns (drugs) = seriously not done => different table
  • Saving too many variables at on‌ce => update as needed!
  • Having too many columns in one table => split up into association tables (e.g. User ↔ License ↔ LicenseType)
  • ...
And I could probably go on and on and on. Use it right or don't use it all otherwise it's going to give you more problems than it's worth.
What he actually said was quite straight forward in the sense of the previous reply to his.

Quote:
Originally Posted by SecretBoss
Посмотреть сообщение
What The Hell is that, you make a query to save one variable while you can save all of them with just one query

Here is a correct usage (Not made by me)

Код:
SaveData(playerid)
{
	new query[2500];
	format(query, sizeof(query), "UPDATE `accounts` SET");
	format(query, sizeof(query), "%s `score` = '%d',", query, Data[playerid][Score]);
	format(query, sizeof(query), "%s `kills` = '%d',", query, Data[playerid][Kills]);
	format(query, sizeof(query), "%s `deaths` = '%d',", query, Data[playerid][Deaths]);
	format(query, sizeof(query), "%s `money` = '%d',", query, Data[playerid][Money]);

	mysql_format(connection, query, sizeof(query), "%s", query);
	mysql_query(connection, query, false);
	return 1;
}
Both of which are saying the same thing. You need to optimize your script.

Re: SaveAccount taking too long time - Tamer - 12.02.2016

I strongly advice optimizing that code. You should do what Vince and the other guys said.I just want to state that what they said is correct and that is how it is supposed to be done.

However, something which catched my eye is the "input line too long" error.

This error can be addressed by using the updated compiler made by ZeeX. Use that, however don't use it to fix that error specifically, but to make coding easier on your side.

Re: SaveAccount taking too long time - Sew_Sumi - 14.02.2016

Who said anything about compiler settings?

Tamer said about another compiler that handles pawn better, and has various fixes in it.

Re: SaveAccount taking too long time - Tamer - 15.02.2016

Quote:
Originally Posted by AmigaBlizzard
Посмотреть сообщение
And try to stay away from compiler adjustments, unless there is no other way to get what you need.
But whatever you need should be do-able with some code-adjustments.

Adjusting compiler settings to suit bad programming style is bad on top of bad (= not done).
Some people make gamemodes of 50k+ lines long and never adjust a single compiler setting and get their code to work just fine, so can you.
The compiler made by ZeeX fixes many compiler issues. It is not an adjustment, it is a fixed and updated version of the compiler which is very useful.

Re: SaveAccount taking too long time - AmigaBlizzard - 16.02.2016

Quote:
Originally Posted by Tamer
Посмотреть сообщение
I strongly advice optimizing that code. You should do what Vince and the other guys said.I just want to state that what they said is correct and that is how it is supposed to be done.

However, something which catched my eye is the "input line too long" error.

This error can be addressed by using the updated compiler made by ZeeX. Use that, however don't use it to fix that error specifically, but to make coding easier on your side.
This is what I meant about adjusting stuff with compiler settings to get rid of the "input line too long".
Adding a fix to the compiler to remove/hide that warning.

With normal code, you won't get that warning.
I've seen gamemodes of 15k+ lines of code without that warning ever coming up.