[HELP] Optimize Code - Printable Version

[HELP] Optimize Code - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: [HELP] Optimize Code (/showthread.php?tid=593669)

[HELP] Optimize Code - EditPawn - 08.11.2015

Hello,
I returned to program pawn a few days and I'm trying to make a code but can not find a solution to optimize it if someone can help me with what function to use for this would be great.

I need to show the player some PlayerTextDraw, but as it is registered or not, takes leave of showing a PlayerTextDraw, as are many did a loop but in time to remove this single PlayerTextDraw not know how to do.

Not optimally, I not found a solution to my problem to optimize it.

PHP код:



for(new i; i != 24; i++) {

        if(DOF2_FileExists(File)) {

            PlayerTextDrawShow(playerid, Text_Login[0]);

            PlayerTextDrawShow(playerid, Text_Login[1]);

            PlayerTextDrawShow(playerid, Text_Login[2]);

            PlayerTextDrawShow(playerid, Text_Login[3]);

            PlayerTextDrawShow(playerid, Text_Login[4]);

            PlayerTextDrawShow(playerid, Text_Login[5]);

            PlayerTextDrawShow(playerid, Text_Login[6]);

            PlayerTextDrawShow(playerid, Text_Login[7]);

            PlayerTextDrawShow(playerid, Text_Login[8]);

            PlayerTextDrawShow(playerid, Text_Login[9]);

            PlayerTextDrawShow(playerid, Text_Login[10]);

            PlayerTextDrawShow(playerid, Text_Login[11]);

            PlayerTextDrawShow(playerid, Text_Login[12]);

            PlayerTextDrawShow(playerid, Text_Login[13]);

            PlayerTextDrawShow(playerid, Text_Login[14]);

            PlayerTextDrawShow(playerid, Text_Login[15]);

            PlayerTextDrawShow(playerid, Text_Login[16]);

            PlayerTextDrawShow(playerid, Text_Login[17]);

            PlayerTextDrawShow(playerid, Text_Login[18]);

            PlayerTextDrawShow(playerid, Text_Login[19]);

            PlayerTextDrawShow(playerid, Text_Login[20]);

            PlayerTextDrawShow(playerid, Text_Login[21]);

            PlayerTextDrawShow(playerid, Text_Login[22]);

            //PlayerTextDrawShow(playerid, Text_Login[i]);

        } else {

            PlayerTextDrawShow(playerid, Text_Login[0]);

            PlayerTextDrawShow(playerid, Text_Login[1]);

            PlayerTextDrawShow(playerid, Text_Login[2]);

            PlayerTextDrawShow(playerid, Text_Login[3]);

            PlayerTextDrawShow(playerid, Text_Login[4]);

            PlayerTextDrawShow(playerid, Text_Login[5]);

            PlayerTextDrawShow(playerid, Text_Login[6]);

            PlayerTextDrawShow(playerid, Text_Login[7]);

            PlayerTextDrawShow(playerid, Text_Login[8]);

            PlayerTextDrawShow(playerid, Text_Login[9]);

            PlayerTextDrawShow(playerid, Text_Login[10]);

            PlayerTextDrawShow(playerid, Text_Login[11]);

            PlayerTextDrawShow(playerid, Text_Login[12]);

            PlayerTextDrawShow(playerid, Text_Login[13]);

            PlayerTextDrawShow(playerid, Text_Login[14]);

            PlayerTextDrawShow(playerid, Text_Login[15]);

            PlayerTextDrawShow(playerid, Text_Login[16]);

            PlayerTextDrawShow(playerid, Text_Login[17]);

            PlayerTextDrawShow(playerid, Text_Login[18]);

            PlayerTextDrawShow(playerid, Text_Login[19]);

            PlayerTextDrawShow(playerid, Text_Login[20]);

            PlayerTextDrawShow(playerid, Text_Login[22]);

            PlayerTextDrawShow(playerid, Text_Login[23]);

            //PlayerTextDrawShow(playerid, Text_Login[i]);

        }

Sorry for my english.

Re: [HELP] Optimize Code - Sellize - 08.11.2015

I believe this is what you're trying.
Remove the for loop that you put in, it is not placed correctly.

PHP код:



        if(DOF2_FileExists(File)) {
            for(new i=0; i != 22; i++){
                PlayerTextDrawShow(playerid, Text_Login[i]);
             }
        } else {
            Pfor(new i=0; i != 23; i++){
                PlayerTextDrawShow(playerid, Text_Login[i]);
             }
        }

Re: [HELP] Optimize Code - ATGOggy - 08.11.2015

pawn Код:

for(new i; i != 24; i++) { 
        if(DOF2_FileExists(File)) { 
            PlayerTextDrawShow(playerid, Text_Login[i]); 
        } else { 
            PlayerTextDrawShow(playerid, Text_Register[i]); 
        }

Re: [HELP] Optimize Code - Sellize - 08.11.2015

Quote:

Originally Posted by ATGOggy

pawn Код:

for(new i; i != 24; i++) { 
        if(DOF2_FileExists(File)) { 
            PlayerTextDrawShow(playerid, Text_Login[i]); 
        } else { 
            PlayerTextDrawShow(playerid, Text_Register[i]); 
        }

You could do this too, but it would be more demanding since every loop it would check the if statement again and again.
If you use the code I posted, it will only run the loop inside the if statement.

Re: [HELP] Optimize Code - EditPawn - 08.11.2015

Thank you, I managed to find a way to solve my problem, the two ways mentioned would not work the way I wanted, because a PlayerTextDraw would stay on top of the other, managed to solve the problem with this code:

PHP код:



    if(DOF2_FileExists(GetDataPlayer(playerid))) for(new i; i != 23; i++) PlayerTextDrawShow(playerid, Text_Login[playerid][i]);

    else {

        for(new i; i != 24; i++) {

            if(i == 21) continue;

            PlayerTextDrawShow(playerid, Text_Login[playerid][i]);

        }

    }