Dialog buggy + rep for those who help !!!

Dialog buggy + rep for those who help !!! - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Dialog buggy + rep for those who help !!! (/showthread.php?tid=582841)

Dialog buggy + rep for those who help !!! - iTakelot - 23.07.2015

I'm doing a command / report with the information that players are online or offline, only the second line of dialogue informs properly if the player is online or not, the second line down is all offline, help please?

PHP код:



command(relato, playerid, params[]) { 


    new OtherPlayer, Name[24], Reason[128], Msg[128]; 


    SendAdminText(playerid, "/relato", params); 


    if (APlayerData[playerid][LoggedIn] == true) 

    { 

        if (sscanf(params, "us[128]", OtherPlayer, Reason)) SendClientMessage(playerid, 0xFF0000AA, "Uso: \"/relato [id] [causa]"); 

        else 

        { 

            if (APlayerData[OtherPlayer][LoggedIn] == true) 

            { 

                SendReportToAdmins(OtherPlayer, Reason); 



                GetPlayerName(OtherPlayer, Name, sizeof(Name)); 


                format(Msg, 128, "Seu relato contra jogador(a) %s foi enviado aos administradores ", Name)); 

                SendClientMessage(playerid, 0x808080FF, Msg); 

                 

                if (AReports[0][ReportUsed] == true) 

                format(ReportList, 5000, "%s: %s - %s\n", AReports[0][ReportName], AReports[0][ReportReason], IsPlayerConnected(OtherPlayer) ? ("Online") : ("Offline")); 


            for (new i = 1; i < 50; i++) 

            { 

                if (AReports[i][ReportUsed] == true) 

                { 

                    format(ReportList, 5000, "%s%s: %s - %s\n", ReportList, AReports[i][ReportName], AReports[i][ReportReason], IsPlayerConnected(i) ? ("Online") : ("Offline")); 

                } 

            } 


            ShowPlayerDialog(playerid, DialogReports, DIALOG_STYLE_MSGBOX, "Relatуrio:", ReportList, "OK", "Cancelar"); 

            } 

            else 

                SendClientMessage(playerid, 0xff000099, "ERRO:O jogador nao estб conectado."); 

        } 

    } 

    else 

        return 0; 


     

    return 1; 

}

AW: Dialog buggy + rep for those who help !!! - Mencent - 23.07.2015

Hello!

Can you send us your code of this command?

- Mencent

Re: AW: Dialog buggy + rep for those who help !!! - iTakelot - 23.07.2015

Quote:

Originally Posted by Mencent

Hello!

Can you send us your code of this command?

- Mencent

Yes friend, added code

AW: Dialog buggy + rep for those who help !!! - Mencent - 23.07.2015

Yes, thanks!

Try this, please:

PHP код:



command(relato,playerid,params[])

{

    new OtherPlayer,Name[24],Reason[128],Msg[145];

    SendAdminText(playerid,"/relato",params);

    if(APlayerData[playerid][LoggedIn] == true)

    {

        if(sscanf(params,"us[128]",OtherPlayer,Reason))return SendClientMessage(playerid,0xFF0000AA,"Uso: \"/relato [id] [causa]");

        if(APlayerData[OtherPlayer][LoggedIn] == true)

        {

            SendReportToAdmins(OtherPlayer,Reason);

            GetPlayerName(OtherPlayer,Name,sizeof Name);

            format(Msg,sizeof Msg,"Seu relato contra jogador(a) %s foi enviado aos administradores",Name);

            SendClientMessage(playerid,0x808080FF,Msg);

            for(new i;i<50;i++)

            {

                if(AReports[i][ReportUsed] == true)

                {

                    format(ReportList,5000,"%s%s: %s - %s\n",ReportList,AReports[i][ReportName],AReports[i][ReportReason],(IsPlayerConnect(i)) ? ("Online") : ("Offline"));

                }

            }

            ShowPlayerDialog(playerid, DialogReports, DIALOG_STYLE_MSGBOX, "Relatуrio:", ReportList, "OK", "Cancelar");

        }

        return SendClientMessage(playerid, 0xff000099, "ERRO:O jogador nao estб conectado.");

    }

    return 1;

}

If it doesn't work, can you do a screenshot?

- Mencent

Re: Dialog buggy + rep for those who help !!! - iTakelot - 23.07.2015

Thank you for trying to help but it did not work ...

see as it was:

AW: Dialog buggy + rep for those who help !!! - Mencent - 23.07.2015

PHP код:



command(relato,playerid,params[])

{

    new OtherPlayer,Name[24],Reason[128],Msg[145];

    SendAdminText(playerid,"/relato",params);

    if(APlayerData[playerid][LoggedIn] == true)

    {

        if(sscanf(params,"us[128]",OtherPlayer,Reason))return SendClientMessage(playerid,0xFF0000AA,"Uso: \"/relato [id] [causa]");

        if(APlayerData[OtherPlayer][LoggedIn] == true)

        {

            SendReportToAdmins(OtherPlayer,Reason);

            GetPlayerName(OtherPlayer,Name,sizeof Name);

            format(Msg,sizeof Msg,"Seu relato contra jogador(a) %s foi enviado aos administradores",Name);

            SendClientMessage(playerid,0x808080FF,Msg);

            for(new i;i<50;i++)

            {

                if(AReports[i][ReportUsed] == true)

                {

                    format(ReportList,5000,"%s%s: %s - %s\n",ReportList,AReports[i][ReportName],AReports[i][ReportReason],(IsPlayerConnected(GetPlayerID(AReports[i][ReportName]))) ? ("Online") : ("Offline"));

                }

            }

            ShowPlayerDialog(playerid, DialogReports, DIALOG_STYLE_MSGBOX, "Relatуrio:", ReportList, "OK", "Cancelar");

        }

        return SendClientMessage(playerid, 0xff000099, "ERRO:O jogador nao estб conectado.");

    }

    return 1;

}



GetPlayerID(name[])//at the end of the script

{

    new tmp[MAX_PLAYER_NAME];

    for(new i;i<MAX_PLAYERS;i++)

    {

        if(!GetPlayerName(i,tmp,sizeof tmp))break;

        if(!strcmp(name,tmp,true))return i;

    }

    return -1;

}

And so?

Re: Dialog buggy + rep for those who help !!! - iTakelot - 23.07.2015

it was not : '( , I think there's no way to fazer

Re: Dialog buggy + rep for those who help !!! - iTakelot - 23.07.2015

up...?

AW: Dialog buggy + rep for those who help !!! - Mencent - 24.07.2015

PHP код:



format(ReportList,5000,"%s%s: %s - %s\n"

For what is the second %s and the third %s?

• second %s => The player who wrote the report?
• third %s => The title of the report?

Please answer the question so that I can help you.

- Mencent

Re: Dialog buggy + rep for those who help !!! - xVIP3Rx - 25.07.2015

pawn Код:

CMD:reportar(playerid, params[])
{
    if(!APlayerData[playerid][LoggedIn]) return 0;
    
    new OtherPlayer, Reason[128];
    if (sscanf(params, "us[128]", OtherPlayer, Reason)) return SendClientMessage(playerid, 0xFF0000AA, "Digite: \"/reportar <Player> <Seu Report>\"");
    if (!APlayerData[OtherPlayer][LoggedIn]) return SendClientMessage(playerid, 0xFFFFFFFF, "O Player nao esta Online");

    new Name[24], Msg[128];
    SendReportToAdmins(OtherPlayer, Reason);

    GetPlayerName(OtherPlayer, Name, sizeof(Name));
    
    format(Msg, 128, "Voce Reportou {FFFFFF}%s", Name);
    SendClientMessage(playerid, 0xFFFFFFFF, Msg);
    return 1;
}

command(relato,playerid,params[])
{
    SendAdminText(playerid,"/relato",params);
    if(!APlayerData[playerid][LoggedIn]) return 0;
    
    new OtherPlayer, Reason[128];
    if(sscanf(params,"us[128]",OtherPlayer,Reason))return SendClientMessage(playerid,0xFF0000AA,"Uso: \"/relato [id] [causa]");
    if(!APlayerData[OtherPlayer][LoggedIn]) return SendClientMessage(playerid, 0xff000099, "ERRO:O jogador nao estб conectado.");

    SendReportToAdmins(OtherPlayer,Reason);

    new Name[24], msg[128], dest[256]
    GetPlayerName(OtherPlayer,Name,sizeof Name);
    format(msg,128,"Seu relato contra jogador(a) %s foi enviado aos administradores", Name);
    SendClientMessage(playerid,0x808080FF,msg);
    
    for(new i;i<sizeof(AReports);i++)
    {
        if(AReports[i][ReportUsed])
        {
            format(ReportList,5000,"%s%s: %s - %s\n",ReportList,AReports[i][ReportName],AReports[i][ReportReason],(IsPlayerConnect(i)) ? ("Online") : ("Offline"));

            strcat(dest, ReportList);
        }
    }
    ShowPlayerDialog(playerid, DialogReports, DIALOG_STYLE_MSGBOX, "Relatуrio:", dest, "OK", "Cancelar");
    
    return 1;
}

AW: Dialog buggy + rep for those who help !!! - Mencent - 25.07.2015

Why do you use "i"?

i has the value of sizeof(AReports) (50).

You should use the playerid...

- Mencent

Re: Dialog buggy + rep for those who help !!! - iTakelot - 25.07.2015

To testando aqui ja venho falar se deu certo...

AW: Dialog buggy + rep for those who help !!! - Mencent - 25.07.2015

Well. Does it work now?

- Mencent

Re: Dialog buggy + rep for those who help !!! - iTakelot - 25.07.2015

Enfim deu certo Mencent muito obrigado

vou reputalo.

Re: AW: Dialog buggy + rep for those who help !!! - xVIP3Rx - 25.07.2015

Quote:

Originally Posted by Mencent

Why do you use "i"?

i has the value of sizeof(AReports) (50).

You should use the playerid...

- Mencent

It isn\'t for the ID/Name, the names are already saved in his "AReports[i][ReportName]" so I don\'t have to get his name again, I didn\'t notice "IsPlayerConnect(i)" though, thanks for pointing that out

pawn Code:

CMD:reportar(playerid, params[])
{
    if(!APlayerData[playerid][LoggedIn]) return 0;

    new OtherPlayer, Reason[128];
    if (sscanf(params, "us[128]", OtherPlayer, Reason)) return SendClientMessage(playerid, 0xFF0000AA, "Digite: \"/reportar <Player> <Seu Report>\"");
    if (!APlayerData[OtherPlayer][LoggedIn]) return SendClientMessage(playerid, 0xFFFFFFFF, "O Player nao esta Online");

    new Name[24], Msg[128];
    SendReportToAdmins(OtherPlayer, Reason);

    GetPlayerName(OtherPlayer, Name, sizeof(Name));

    format(Msg, 128, "Voce Reportou {FFFFFF}%s", Name);
    SendClientMessage(playerid, 0xFFFFFFFF, Msg);
    return 1;
}

command(relato,playerid,params[])
{
    SendAdminText(playerid,"/relato",params);
    if(!APlayerData[playerid][LoggedIn]) return 0;

    new OtherPlayer, Reason[128];
    if(sscanf(params,"us[128]",OtherPlayer,Reason))return SendClientMessage(playerid,0xFF0000AA,"Uso: \"/relato [id] [causa]");
    if(!APlayerData[OtherPlayer][LoggedIn]) return SendClientMessage(playerid, 0xff000099, "ERRO:O jogador nao estб conectado.");

    SendReportToAdmins(OtherPlayer,Reason);

    new Name[24], msg[128], dest[256], bool:OnlineState;
    GetPlayerName(OtherPlayer,Name,sizeof Name);
    format(msg,128,"Seu relato contra jogador(a) %s foi enviado aos administradores", Name);
    SendClientMessage(playerid,0x808080FF,msg);
    
    for(new i;i<sizeof(AReports);i++)
    {
        if(AReports[i][ReportUsed])
        {
            for(new p, j = GetPlayerPoolSize(); i<j; i++) if(IsPlayerConnected(p))
            {
                GetPlayerName(p, name, MAX_PLAYER_NAME);
                if(!strcmp(name, AReports[i][ReportName])) OnlineState = true;
            }

            format(ReportList,5000,"%s%s: %s - %s

",ReportList,AReports[i][ReportName],AReports[i][ReportReason],(OnlineState) ? ("Online") : ("Offline"));

            strcat(dest, ReportList);
            OnlineState = false;
        }
    }
    ShowPlayerDialog(playerid, DialogReports, DIALOG_STYLE_MSGBOX, "Relatуrio:", dest, "OK", "Cancelar");

    return 1;
}

This isn\'t the best way to do this though.