[FilterScript] SAMP Clock - Printable Version

[FilterScript] SAMP Clock - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Filterscripts (https://sampforum.blast.hk/forumdisplay.php?fid=17)
+--- Thread: [FilterScript] SAMP Clock (/showthread.php?tid=582063)

SAMP Clock - hamzajaved780 - 17.07.2015

SAMP Clock

Not my first piece of code, but first public release. Its very simple and took me just 10 mins. Hope you like it

Download Link:
http://pastebin.com/iPZ62fVk

Re: SAMP Clock - WASD - 17.07.2015

Why timer = 6 sec?
And this:

PHP код:



        TextDrawShowForPlayer(playerid, Clock[0]);

        TextDrawShowForPlayer(playerid, Clock[1]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                TextDrawHideForPlayer(i, Clock[0]);

                TextDrawHideForPlayer(i, Clock[1]);

                TextDrawShowForPlayer(i, Clock[0]);

                TextDrawShowForPlayer(i, Clock[1]);

    }

Change to:

PHP код:



for(new t; t != 2; t++) TextDrawShowForPlayer(playerid, Clock[t]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                for(new t; t != 2; t++) TextDrawHideForPlayer(i, Clock[t]),TextDrawShowForPlayer(i, Clock[t]);

    }

Re: SAMP Clock - Crayder - 17.07.2015

Quote:

Originally Posted by WASD

Why timer = 6 sec?
And this:

PHP код:



        TextDrawShowForPlayer(playerid, Clock[0]);

        TextDrawShowForPlayer(playerid, Clock[1]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                TextDrawHideForPlayer(i, Clock[0]);

                TextDrawHideForPlayer(i, Clock[1]);

                TextDrawShowForPlayer(i, Clock[0]);

                TextDrawShowForPlayer(i, Clock[1]);

    }

Change to:

PHP код:



for(new t; t != 2; t++) TextDrawShowForPlayer(playerid, Clock[t]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                for(new t; t != 2; t++) TextDrawHideForPlayer(i, Clock[t]),TextDrawShowForPlayer(i, Clock[t]);

    }

1. Don't force him to do anything, his version is fine and faster than yours.
2. Are you really still using MAX_PLAYERS as a loop's upper bound? It's 2015, use GetPlayerPoolSize.
3. Using commas to continue a statement is supposed to only work in returns, but either way it is bad coding practice. In fact, I think Y-Less says something about it in a comment on his old Code Optimisations thread.

Re: SAMP Clock - SickAttack - 17.07.2015

Quote:

Originally Posted by WASD

Why timer = 6 sec?
And this:

PHP код:



        TextDrawShowForPlayer(playerid, Clock[0]);

        TextDrawShowForPlayer(playerid, Clock[1]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                TextDrawHideForPlayer(i, Clock[0]);

                TextDrawHideForPlayer(i, Clock[1]);

                TextDrawShowForPlayer(i, Clock[0]);

                TextDrawShowForPlayer(i, Clock[1]);

    }

Change to:

PHP код:



for(new t; t != 2; t++) TextDrawShowForPlayer(playerid, Clock[t]);

PHP код:



    for(new i = 0; i < MAX_PLAYERS; i++)

    {

                for(new t; t != 2; t++) TextDrawHideForPlayer(i, Clock[t]),TextDrawShowForPlayer(i, Clock[t]);

    }

You should avoid using loops for such matters (hiding/showing textdraws), they are actually slower than allotting them internally.

Want proof?

1 variable alternated 50,000 times in two different manners.

Re: SAMP Clock - hamzajaved780 - 18.07.2015

Quote:

Originally Posted by Crayder

Sorry about the max player thing, I personally use foreach so I forgot about that. About the third point can you give an example. I will be very thankful.

Re: SAMP Clock - hamzajaved780 - 18.07.2015

Quote:

Originally Posted by SickAttack

You are right it is faster to execute plain code than loops.

Re: SAMP Clock - Kursed - 19.07.2015

Keep up the great work I say!

Re: SAMP Clock - Blacky4Life - 19.07.2015

Great work!

Re: SAMP Clock - dionisak0s - 19.07.2015

Quote:

Originally Posted by SickAttack

I see that you have a very beautiful PAWN Editor there, mind if you share it with us?

Re: SAMP Clock - Crayder - 19.07.2015

Quote:

Originally Posted by dionisak0s

I see that you have a very beautiful PAWN Editor there, mind if you share it with us?

Are you serious, you've never heard of Sublime Text?

Re: SAMP Clock - BladeFire - 20.07.2015

Nice