SA-MP Forums Archive
optimize code - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: optimize code (/showthread.php?tid=578814)


optimize code - JoshNudock - 22.06.2015

I made a code, but want to let him 100 percent functional, the problem is that when I approach a vehicle it checks another vehicle farther than what I desire, sometimes function checks as far even though vehicle one in front of you .. how can I fix it?

PHP Code:
public PlacaVeiculoPerto(playerid)
{
    for( new i; i < MAX_VEHICLES; i++) {
        new Float:Pos[3];
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]);
        if(IsPlayerInRangeOfPoint(playerid, 7.0, Pos[0], Pos[1], Pos[2])) {
            return i;
        }
    }
    return 0;
} 


Re: optimize code - CoaPsyFactor - 22.06.2015

well, you should not return on IsPlayerInRange of point, but instead save in variable distance and vehicle id and continue with loop, when you get to another vehicle that is in radius check distance again and compare it with last one, if it is smaller than update variable with vehicle id and variable with distance to new values.

And after that return vehicle id out of loop.

something like this

PHP Code:
public PlacaVeiculoPerto(playerid)
{
    new Float:distance = 10.0, Float: currentDistance = 11.0, vehicleid = 0, Pos[3];
    for( new i; i < MAX_VEHICLES; i++) {
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]);
        currentDistance = GetPlayerDistanceFromPoint(playerid, Pos[0], Pos[1], Pos[2]);
        if(currentDistance <= 7.0 && currentDistance < distance) {
            vehicleid = i;
            distance = currentDistance;
        }
    }
   
    return vehicleid;
} 


Re: optimize code - JoshNudock - 22.06.2015

error


Code:
C:\Users\2\Desktop\gamemode\gamemodes\2.pwn(3075) : warning 213: tag mismatch
C:\Users\2\Desktop\gamemode\gamemodes\2.pwn(3075) : warning 213: tag mismatch
C:\Users\2\Desktop\gamemode\gamemodes\2.pwn(3075) : warning 213: tag mismatch
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


3 Warnings.
PHP Code:
stock PlacaVeiculoPerto(playerid)
{
    new Float:distance = 10.0, Float: currentDistance = 11.0, vehicleid = 0, Pos[3];
    for(new i; i < MAX_VEHICLES; i++)
    {
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]); //error <<<<<<<<<<<
        currentDistance = GetPlayerDistanceFromPoint(playerid, Pos[0], Pos[1], Pos[2]);
        if(currentDistance <= 7.0 && currentDistance < distance) {
            vehicleid = i;
            distance = currentDistance;
        }
    }
    return vehicleid;
} 
Please

AW: optimize code - Mencent - 22.06.2015

Hello!

You forgot the Float:-Tag.
PHP Code:
stock PlacaVeiculoPerto(playerid)
{
    new Float:distance = 10.0, Float: currentDistance = 11.0, vehicleid = 0, Float:Pos[3];
    for(new i; i < MAX_VEHICLES; i++)
    {
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]);
        currentDistance = GetPlayerDistanceFromPoint(playerid, Pos[0], Pos[1], Pos[2]);
        if(currentDistance <= 7.0 && currentDistance < distance) {
            vehicleid = i;
            distance = currentDistance;
        }
    }
    return vehicleid;
} 

- Mencent

Re: AW: optimize code - JoshNudock - 22.06.2015

Quote:
Originally Posted by Mencent
View Post
Hello!

You forgot the Float:-Tag.
PHP Code:
stock PlacaVeiculoPerto(playerid)
{
    new Float:distance = 10.0, Float: currentDistance = 11.0, vehicleid = 0, Float:Pos[3];
    for(new i; i < MAX_VEHICLES; i++)
    {
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]);
        currentDistance = GetPlayerDistanceFromPoint(playerid, Pos[0], Pos[1], Pos[2]);
        if(currentDistance <= 7.0 && currentDistance < distance) {
            vehicleid = i;
            distance = currentDistance;
        }
    }
    return vehicleid;
} 

- Mencent
Tranks!

@topic
Sorry, but it was not that above code that was in error, is the code below that checks the id of the vehicle, and it checks where this really the vehicle, this is the code with the error:

PHP Code:

public PlayerPertoVeiculo(playerid)
{
    static Float:Pos[3];
    for( new i; i < MAX_VEHICLES; i++) {
        GetVehiclePos(i, Pos[0], Pos[1], Pos[2]);
        if(IsPlayerInRangeOfPoint(playerid, 7.0, Pos[0], Pos[1], Pos[2])) {
            return 1;
        }
    }
    return 0;
}