MySQL doesn't update table? - Printable Version

MySQL doesn't update table? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: MySQL doesn't update table? (/showthread.php?tid=578809)

MySQL doesn't update table? - [XST]O_x - 22.06.2015

So I'm trying to learn MySQL, for some reason loading information into player seems to work fine, but updating the data when a player leaves doesn't.

pawn Код:

public OnPlayerDisconnect(playerid, reason)
{
    new query[512];
    new Float: tmpX, Float: tmpY, Float: tmpZ, Float: tmpA;

    GetPlayerPos(playerid, tmpX, tmpY, tmpZ);
    GetPlayerFacingAngle(playerid, tmpA);

    pData[playerid][p_SavePosInterior] = GetPlayerInterior(playerid);
    pData[playerid][p_SavePosVW] = GetPlayerVirtualWorld(playerid);

    mysql_format(mysql, query, sizeof query, "UPDATE `players` SET `AdminLevel`=%d `SavePos`=%d `SavePosX`=%f `SavePosY`=%f `SavePosZ`=%f `SavePosA`=%f `SavePosInterior`=%d `SavePosVW`=%d `Kills`=%d `Deaths`=%d \
                    `Score`=%d `Money`=%d WHERE ID=%d", pData[playerid][p_AdminLevel], pData[playerid][p_SavePos], tmpX, tmpY, tmpZ, tmpA,
                    pData[playerid][p_SavePosInterior], pData[playerid][p_SavePosVW], pData[playerid][p_Kills], pData[playerid][p_Deaths], GetPlayerScore(playerid), GetPlayerMoney(playerid), pData[playerid][p_ID]);

    mysql_tquery(mysql, query, "", "");
    return 1;
}

And generally, does anyone know any good place to start learning?
I've read so many tutorials on the forum, but it seems like none of them explains the BASIC of the language, making it really hard to understand.

Re: MySQL doesn't update table? - X337 - 22.06.2015

Escape float like this :

Код:

`SavePosX`='%f' `SavePosY`='%f' `SavePosZ`='%f' `SavePosA`='%f'

You can learn mysql from this site http://www.w3schools.com/sql/

Re: MySQL doesn't update table? - [XST]O_x - 22.06.2015

Quote:

Originally Posted by bondowocopz

Escape float like this :

Код:

`SavePosX`='%f' `SavePosY`='%f' `SavePosZ`='%f' `SavePosA`='%f'

You can learn mysql from this site http://www.w3schools.com/sql/

Thanks for the site, it looks great for starting out.

But the data still won't update.

pawn Код:

mysql_format(mysql, query, sizeof query, "UPDATE `players` SET `AdminLevel`=%d `SavePos`=%d `SavePosX`='%f' `SavePosY`='%f' `SavePosZ`='%f' `SavePosA`='%f' `SavePosInterior`=%d `SavePosVW`=%d `Kills`=%d `Deaths`=%d \
                    `Score`=%d `Money`=%d WHERE ID=%d", pData[playerid][p_AdminLevel], pData[playerid][p_SavePos], tmpX, tmpY, tmpZ, tmpA,
                    pData[playerid][p_SavePosInterior], pData[playerid][p_SavePosVW], pData[playerid][p_Kills], pData[playerid][p_Deaths], GetPlayerScore(playerid), GetPlayerMoney(playerid), pData[playerid][p_ID]);

Re: MySQL doesn't update table? - mamorunl - 22.06.2015

In the root of your server, you will find a log file for MySQL. Does that contain any errors?

Re: MySQL doesn't update table? - [XST]O_x - 22.06.2015

Quote:

Originally Posted by mamorunl

In the root of your server, you will find a log file for MySQL. Does that contain any errors?

Yeah you're right!
It says my SQL syntax contains an error, but it seems fine to me...

Quote:

[17:20:37] [ERROR] CMySQLQuery::Execute[] - (error #1064) You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '`SavePos`=0 `SavePosX`='1959.273' `SavePosY`='1343.243' `SavePosZ`='15.375' `Sav' at line 1

Re: MySQL doesn't update table? - Konstantinos - 22.06.2015

You have to separate the fields it's going to update by a comma:

pawn Код:

"... SET `AdminLevel`=%d, `SavePos`=%d, `SavePosX`=%f, `SavePosY`=%f, `SavePosZ`=%f, ..."

and no need to use ` ` around fields' or table's name and neither ' ' around integers or float; although it's a must in strings.

Re: MySQL doesn't update table? - [XST]O_x - 22.06.2015

Quote:

Originally Posted by Konstantinos

You have to separate the fields it's going to update by a comma:

pawn Код:

"... SET `AdminLevel`=%d, `SavePos`=%d, `SavePosX`=%f, `SavePosY`=%f, `SavePosZ`=%f, ..."

and no need to use ` ` around fields' or table's name and neither ' ' around integers or float; although it's a must in strings.

Still, I'm getting the same error:

pawn Код:

mysql_format(mysql, query, sizeof query, "UPDATE `players` SET `AdminLevel`=%d, `SavePos`=%d,, `SavePosX`=%f, `SavePosY`=%f, `SavePosZ`=%f, `SavePosA`=%f, `SavePosInterior`=%d, `SavePosVW`=%d, `Kills`=%d, `Deaths`=%d, \
                    `Score`=%d, `Money`=%d WHERE `ID`=%d", pData[playerid][p_AdminLevel], pData[playerid][p_SavePos], tmpX, tmpY, tmpZ, tmpA, 
                    pData[playerid][p_SavePosInterior], pData[playerid][p_SavePosVW], pData[playerid][p_Kills], pData[playerid][p_Deaths], GetPlayerScore(playerid), GetPlayerMoney(playerid), pData[playerid][p_ID]);

The error:

Quote:

[17:48:13] [ERROR] CMySQLQuery::Execute[] - (error #1064) You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' `SavePosX`=1955.152, `SavePosY`=1367.763, `SavePosZ`=9.258, `SavePosA`=3.203, `' at line 1

It's strange that the error is only pointing at the floats part... Are you sure there is no need to use ' ' around them?

Re: MySQL doesn't update table? - zPain - 22.06.2015

Print the query and check if the string length is enough.

Re: MySQL doesn't update table? - [XST]O_x - 22.06.2015

Oh god.
I've had an extra comma after `SavePos=%d`,,
Wouldn't have seen it without printing it, so thanks for that!

Thanks everyone.