Changename Problem - Printable Version

Changename Problem - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Changename Problem (/showthread.php?tid=574692)

Changename Problem - kalanerik99 - 19.05.2015

Hello!
I have a /changename command to change player name and rename player file!
But file doesn't change [%s.ini(name)]

Код:

if(dialogid == CHANGE_NAME)
{
if (response)
{

if(strlen(inputtext) < 4) return ShowPlayerDialog(playerid, CHANGE_NAME, DIALOG_STYLE_INPUT, "{AA3333}New Name", "Input your new name below\nName must be at least 4 lethers long!:", "Change", "Cancel");
if (dini_Exists(inputtext)) return SendClientMessage(playerid,COLOR_RED,"This User Name Is Taken!");
new name1[MAX_PLAYER_NAME],name2[MAX_PLAYER_NAME];
format(name1, sizeof(name1), PLAYERS, PlayerName(playerid));
format(name2, sizeof(name2), PLAYERS, inputtext);
SetPlayerName(playerid,inputtext);
frename(name1, name2);
}
}

Код:

stock frename(const oldname[], const newname[])
{
if (!fexist(oldname)) return 0;

new
File: oldfile = fopen(oldname, io_read),
File: newfile = fopen(newname, io_write),
line[128];
if (!oldfile || !newfile) return 0;
while (fread(oldfile, line)) fwrite(newfile, line);
fclose(oldfile);
fclose(newfile);
fremove(oldname);
return 1;
}

Re: Changename Problem - azzerking - 19.05.2015

Okay change this:

Код:

format(name1, sizeof(name1), PLAYERS, PlayerName(playerid));
format(name2, sizeof(name2), PLAYERS, inputtext);

to this:

Код:

format(name1, sizeof(name1), "%s", PlayerName(playerid));
format(name2, sizeof(name2), "%s", inputtext);

%s is a replacement character for strings.

Re: Changename Problem - kalanerik99 - 19.05.2015

#define PLAYERS Server/Players/%s

Re: Changename Problem - azzerking - 19.05.2015

You didn't explain what Players was,

Also I am pretty sure you need to put quotes around the define like #define PLAYERS "Server/Players/%s"

if it still doesn't work try doing it like I said, just manually type it out.

Re: Changename Problem - Konstantinos - 19.05.2015

In case frename returns 0, it will not create a new file, write from the old file to new and delete the old.

You can return an error if that happens:

pawn Код:

format(name1, sizeof(name1), PLAYERS, PlayerName(playerid));
format(name2, sizeof(name2), PLAYERS, inputtext);
if (!frename(name1, name2)) return SendClientMessage(playerid, -1, "Could not be changed. Please try again later.");
SetPlayerName(playerid,inputtext);

Re: Changename Problem - kalanerik99 - 19.05.2015

Quote:

Originally Posted by Konstantinos

In case frename returns 0, it will not create a new file, write from the old file to new and delete the old.

You can return an error if that happens:

pawn Код:

format(name1, sizeof(name1), PLAYERS, PlayerName(playerid));
format(name2, sizeof(name2), PLAYERS, inputtext);
if (!frename(name1, name2)) return SendClientMessage(playerid, -1, "Could not be changed. Please try again later.");
SetPlayerName(playerid,inputtext);

I change the code as you sad
I says "Unable to change ...."
What should I do?

Re: Changename Problem - kalanerik99 - 20.05.2015

Bump!
Please help!

Re: Changename Problem - kalanerik99 - 21.05.2015

I dont now how to fix I tried but still the same

Re: Changename Problem - Konstantinos - 21.05.2015

If it fails to open the files most of the times, then you may need to read this: http://forum.sa-mp.com/showpost.php?...20&postcount=6

Re: Changename Problem - kyriakos587 - 21.05.2015

Quote:

if(strlen(inputtext) < 4) return ShowPlayerDialog(playerid, CHANGE_NAME, DIALOG_STYLE_INPUT, "{AA3333}New Name", "Input your new name below\nName must be at least 4 lethers long!:", "Change", "Cancel");
if (dini_Exists(inputtext)) return SendClientMessage(playerid,COLOR_RED,"This User Name Is Taken!");
new name1[MAX_PLAYER_NAME],name2[MAX_PLAYER_NAME];
format(name1, sizeof(name1), PLAYERS, PlayerName(playerid));
format(name2, sizeof(name2), PLAYERS, strval(inputtext));
SetPlayerName(playerid,strval(inputtext));
frename(name1, name2);

You have to add STRVAL to SetPlayerName and format(name2..