Whats wrong? - Printable Version

Whats wrong? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Whats wrong? (/showthread.php?tid=572954)

Whats wrong? - NoDi522 - 03.05.2015

Hey!!
Problem is that when I make somebody leader of org it says: You made (e.g.) mirko leader of ORG: leader 0 2 <- This is what i want to fix. It has to come: ORG: Bolnica.

Here is the code:

PHP код:



CMD:makeleader(playerid,params[])

{

    new ID,ime[MAX_PLAYER_NAME],ime2[MAX_PLAYER_NAME],ORGID,poruka[128],poruka2[128];

    if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Nemate dozvolu za tu komandu");

    if(!IsPlayerConnected(playerid)) return SendClientMessage(playerid,1,""COLOR_CRVENA"Greska:{FFFFFF} Niste ulogirani na serveru");

    if(sscanf(params,"ud",ID,ORGID)) return SendClientMessage(playerid,-1,"{FFFFFF}Koristenje:"COLOR_LAGANA" /makeleader [ID/Ime] [OrgID]");

    if(ID == INVALID_PLAYER_ID) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Igrac nije ulogiran na server");

    if(ORGID > 3 || ORGID < 0) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Maximum organizacija je '3'");

    else

    {

        GetPlayerName(playerid,ime,sizeof(ime));

        GetPlayerName(ID,ime2,sizeof(ime2));

        format(poruka,sizeof(poruka),""COLOR_ZELENA2"[ORG-Info]:"COLOR_CRVENA" VLASNIK{FFFFFF} %s vam je postavio leadera organizacije. ORG: %s",ime,GetOrgName(ORGID));

        SendClientMessage(ID,-1,poruka);

        format(poruka,sizeof(poruka),""COLOR_WG"WG:{FFFFFF} Postavili ste lidera %s. ORG: %s",ime2,GetOrgName(ORGID));

        SendClientMessage(playerid,-1,poruka);

        format(poruka2,sizeof(poruka2),""COLOR_SIVA"[A-Obavijest]:{FFFFFF} %s je postavio %s leadera. ORG: %s",ime,ime2,GetOrgName(ORGID));

        PlayerTeam[ID][ORG_Ime] = GetOrgName(ORGID);

        PlayerTeam[ID][ORG_Leader] = 1;

    }

    return 1;

}

PHP код:



stock GetOrgName(orgid)

{

    switch(orgid)

    {

        case 0: orgid = ORG_PD;

        case 1: orgid = ORG_Bolnica;

        case 2: orgid = ORG_News;

    }

    return 1;

}

Re: Whats wrong? - Konstantinos - 03.05.2015

What you want to return is a string, so:

PHP код:



GetOrgName(orgid) 

{ 

    new org_name[12];

    switch(orgid) 

    { 

        case 0: strcat(org_name, "ORG_PD", sizeof (org_name)); 

        case 1: strcat(org_name, "ORG_Bolnica", sizeof (org_name));

        case 2: strcat(org_name, "ORG_News", sizeof (org_name));

        default: strcat(org_name, "N/A", sizeof (org_name));

    } 

    return org_name; 

}

EDIT: Also if PlayerTeam[ID][ORG_Ime] is supposed to be a string, copy it like that:

PHP код:



strcat((PlayerTeam[ID][ORG_Ime][0] = EOS, PlayerTeam[ID][ORG_Ime]), GetOrgName(ORGID), 12);

otherwise if it's not a string but an integer, you have to assign ORGID instead.

Re: Whats wrong? - NoDi522 - 03.05.2015

PHP код:



C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1438) : error 001: expected token: ")", but found "["

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1438) : warning 215: expression has no effect

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1438) : error 001: expected token: ";", but found "]"

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1438) : error 029: invalid expression, assumed zero

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1438) : fatal error 107: too many error messages on one line


Compilation aborted.Pawn compiler 3.2.3664              Copyright (c) 1997-2006, ITB CompuPhase



4 Errors.

when i add code in command:

PHP код:



CMD:makeleader(playerid,params[])

{

    new ID,ime[MAX_PLAYER_NAME],ime2[MAX_PLAYER_NAME],ORGID,poruka[128],poruka2[128];

    if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Nemate dozvolu za tu komandu");

    if(!IsPlayerConnected(playerid)) return SendClientMessage(playerid,1,""COLOR_CRVENA"Greska:{FFFFFF} Niste ulogirani na serveru");

    if(sscanf(params,"ud",ID,ORGID)) return SendClientMessage(playerid,-1,"{FFFFFF}Koristenje:"COLOR_LAGANA" /makeleader [ID/Ime] [OrgID]");

    if(ID == INVALID_PLAYER_ID) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Igrac nije ulogiran na server");

    if(ORGID > 3 || ORGID < 0) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Maximum organizacija je '3'");

    else

    {

        GetPlayerName(playerid,ime,sizeof(ime));

        GetPlayerName(ID,ime2,sizeof(ime2));

        format(poruka,sizeof(poruka),""COLOR_ZELENA2"[ORG-Info]:"COLOR_CRVENA" VLASNIK{FFFFFF} %s vam je postavio leadera organizacije. ORG: %s",ime,GetOrgName(ORGID));

        SendClientMessage(ID,-1,poruka);

        format(poruka,sizeof(poruka),""COLOR_WG"WG:{FFFFFF} Postavili ste lidera %s. ORG: %s",ime2,GetOrgName(ORGID));

        SendClientMessage(playerid,-1,poruka);

        format(poruka2,sizeof(poruka2),""COLOR_SIVA"[A-Obavijest]:{FFFFFF} %s je postavio %s leadera. ORG: %s",ime,ime2,GetOrgName(ORGID));

        // strcat((PlayerTeam[ID][ORG_Ime][0] = EOS, PlayerTeam[ID][ORG_Ime]), GetOrgName(ORGID), 12);

        PlayerTeam[ID][ORG_Leader] = 1;

    }

    return 1;

}

Re: Whats wrong? - Konstantinos - 03.05.2015

And the the error is given is the commented one?

I told you that if ORG_Ime is not a string, then assign the ORGID. Otherwise, it use the strcat and ORG_Ime needs to have a size itself.

Re: Whats wrong? - NoDi522 - 03.05.2015

What did you just say. Im still new and that so you made me confused

ORG_Ime is string because i want to save ORG name not integer and i tried to paste that code you gave me and i got errors.

Re: Whats wrong? - Konstantinos - 03.05.2015

Okay, sorry. What is the line 1438 which gives the errors?

Also since ORG_Ime is string, it should have a size in the enum.

Re: Whats wrong? - NoDi522 - 03.05.2015

PHP код:



C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1442) : error 001: expected token: ")", but found "["

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1442) : warning 215: expression has no effect

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1442) : error 001: expected token: ";", but found "]"

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1442) : error 029: invalid expression, assumed zero

C:\Users\Dino Covic\Desktop\SAMP Server\gamemodes\Server_Skripta.pwn(1442) : fatal error 107: too many error messages on one line


Compilation aborted.Pawn compiler 3.2.3664              Copyright (c) 1997-2006, ITB CompuPhase



4 Errors.

This are errors.

PHP код:



CMD:makeleader(playerid,params[])

{

    new ID,ime[MAX_PLAYER_NAME],ime2[MAX_PLAYER_NAME],ORGID,poruka[128],poruka2[128];

    if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Nemate dozvolu za tu komandu");

    if(!IsPlayerConnected(playerid)) return SendClientMessage(playerid,1,""COLOR_CRVENA"Greska:{FFFFFF} Niste ulogirani na serveru");

    if(sscanf(params,"ud",ID,ORGID)) return SendClientMessage(playerid,-1,"{FFFFFF}Koristenje:"COLOR_LAGANA" /makeleader [ID/Ime] [OrgID]");

    if(ID == INVALID_PLAYER_ID) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Igrac nije ulogiran na server");

    if(ORGID > 3 || ORGID < 0) return SendClientMessage(playerid,-1,""COLOR_CRVENA"Greska:{FFFFFF} Maximum organizacija je '3'");

    else

    {

        GetPlayerName(playerid,ime,sizeof(ime));

        GetPlayerName(ID,ime2,sizeof(ime2));

        format(poruka,sizeof(poruka),""COLOR_ZELENA2"[ORG-Info]:"COLOR_CRVENA" VLASNIK{FFFFFF} %s vam je postavio leadera organizacije. ORG: %s",ime,GetOrgName(ORGID));

        SendClientMessage(ID,-1,poruka);

        format(poruka,sizeof(poruka),""COLOR_WG"WG:{FFFFFF} Postavili ste lidera %s. ORG: %s",ime2,GetOrgName(ORGID));

        SendClientMessage(playerid,-1,poruka);

        format(poruka2,sizeof(poruka2),""COLOR_SIVA"[A-Obavijest]:{FFFFFF} %s je postavio %s leadera. ORG: %s",ime,ime2,GetOrgName(ORGID));

        strcat((PlayerTeam[ID][ORG_Ime][0] = EOS, PlayerTeam[ID][ORG_Ime]), GetOrgName(ORGID), 12);

        PlayerTeam[ID][ORG_Leader] = 1;

    }

    return 1;

}

This is code.

PHP код:



strcat((PlayerTeam[ID][ORG_Ime][0] = EOS, PlayerTeam[ID][ORG_Ime]), GetOrgName(ORGID), 12);

And this is line 1442 which gives me errors.

++ This is its enum:

PHP код:



enum pTeam

{

    ORG_Ime,

    ORG_Rank,

    ORG_Leader

};

new PlayerTeam[MAX_PLAYERS][pTeam];

Re: Whats wrong? - Konstantinos - 03.05.2015

Actually I've told you how to fix it:

Quote:

Originally Posted by Konstantinos

[..] ORG_Ime needs to have a size itself.

Quote:

Originally Posted by Konstantinos

[..] Also since ORG_Ime is string, it should have a size in the enum.

In the enum is used for PlayerTeam, ORG_Ime needs a size. For example:

pawn Код:

enum some_name_used_for_PlayerTeam_array
{
    ...,
    ORG_Ime[12],
    ...
};