SA-MP Forums Archive
OnPlayerEnterVehicle - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: OnPlayerEnterVehicle (/showthread.php?tid=571408)


OnPlayerEnterVehicle - Alpay0098 - 18.04.2015

Hi, I don't know what's problem but it seems that normal players can drive and get in some faction-restricted vehicles.
So , I put all these codes here. Please check them out and if you can , reply. thanks.
OnPlayerEnterVehicle Code :
PHP Code:
public OnPlayerEnterVehicle(playerid, vehicleid, ispassenger)
{
    new Float:x, Float:y, Float:z;
    if(GetPlayerSurfingVehicleID(playerid) == vehicleid)
    {
        new Float:hp;
        GetPlayerHealth(playerid,hp);
           GetPlayerPos(playerid, x, y, z);
        if(!PlayerInfo[playerid][pMask]) format(string, sizeof(string), "* %s slipped off the top of the vehicle and fell.", PlayerRPName(playerid));
        else format(string, sizeof(string), "* Gharibe slipped off the top of the vehicle and fell.");
        ProxDetector(30.0, playerid, string, COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE,COLOR_PURPLE);
        SetPlayerPos(playerid, x+3, y+3, z+1);
        SetPlayerHealth(playerid,hp-3);
        PlayerPlaySound(playerid, 1130, 0.0, 0.0, 0.0);
        LoopingAnim(playerid,"PED","BIKE_fallR",4.0,0,1,1,1,0);
    }
    if(!ispassenger)
    {
        else if(IsACopCar(vehicleid))
        {
            if(!IsACop(playerid))
            {
                displayCenterHUDInfo(playerid,  "You are not a member of the~n~~b~LSPD/FBI/SAST~w~.", 8);
                PlayerPlaySound(playerid, 1058, 0.0, 0.0, 0.0);
                ClearAnimations(playerid);
            }
        }
    else if(PlayerTied[playerid] != 0) { ClearAnimations(playerid); }
    else if(PlayerCuffed[playerid] != 0) { ClearAnimations(playerid); }
    else if(PlayerFrozen[playerid] != 0) { ClearAnimations(playerid); }
    else if(RapidResKitActive[playerid] != 0) { ClearAnimations(playerid); }
    else if(PlayerJustDied[playerid] != 0) { ClearAnimations(playerid); }
    return 1;
} 
* I've deleted some codes (Other Factions Codes)
IsACop Code :
PHP Code:
stock IsACop(playerid)
{
    if(IsPlayerConnected(playerid))
    {
        new leader = PlayerInfo[playerid][pLeader];
        new member = PlayerInfo[playerid][pMember];
        if(member==1 || member==2 || member==3)
        {
            return 1;
        }
        else if(leader==1 || leader==2 || leader==3)
        {
            return 1;
        }
        else if(IsAnAgent(playerid))
        {
            return 1;
        }
    }
    return 0;
} 
IsACopCar Code :
PHP Code:
stock IsACopCar(vehicleid)
{
    for(new i; i<50; i++)
    {
        if(vehicleid == FacInfo[1][fCars][i])return 1;
    }
    return 0;
} 
* There's too many cars that defined like this : (FacInfo[1] ; 1 Is LSPD)
FacInfo[1][fCars][1] = CreateVehicle ...


I'll +Rep for the best answer.

And also it's about 2 month that I'm dealing with this problem.

Re: OnPlayerEnterVehicle - Fel486 - 18.04.2015

Use OnPlayerStateChange, instead, with your codes

pawn Code:
public OnPlayerStateChange(playerid, newstate, oldstate)
{
    if(newstate == PLAYER_STATE_DRIVER && oldstate == PLAYER_STATE_ONFOOT)
    {
    }
}


Re: OnPlayerEnterVehicle - fuckingcruse - 18.04.2015

Hey

Change this
Code:
else if(IsACopCar(vehicleid))
{
            if(IsACop(playerid))
            {
            //other codes
             }
}
To

Code:
else if(!IsACopCar(vehicleid))
{
           if(IsACop(playerid))
           {
             //other codes
            }
}
Because when you use
! It is true
If you don't use it is false , so if he is not a cop then

Code:
if(IsACop(playerid))
And if he is a cop

Code:
if(!IsACop(playerid))
If you understand what I say.. good day

Re: OnPlayerEnterVehicle - Alpay0098 - 19.04.2015

You mean like this?
PHP Code:
else if(!IsACopCar(vehicleid))
        {
            if(!IsACop(playerid))
            {
                displayCenterHUDInfo(playerid,  "You are not a member of the~n~~b~LSPD/FBI/SAST~w~.", 8); //display for 8 seconds
                PlayerPlaySound(playerid, 1058, 0.0, 0.0, 0.0);
                ClearAnimations(playerid);
            }
        } 


Re: OnPlayerEnterVehicle - fuckingcruse - 19.04.2015

Code:
else if(!IsACopCar(vehicleid))
{
         if(IsACop(playerid)
        {
         //if he he not a cop your codes
         }
}
If he is a cop then if(!IsACop(playerid)
Use this ! When he is something , and don't use it when he is not

Re: OnPlayerEnterVehicle - Alpay0098 - 19.04.2015

It didn't work.

Re: OnPlayerEnterVehicle - fuckingcruse - 19.04.2015

Pm me your whole code I will make and send you tomorrow

Re: OnPlayerEnterVehicle - Threshold - 19.04.2015

What are you talking about Cruse? The exclamation mark represents a false or negative value.

if(!variable)
Means 'variable' is either 0 or less, or is false.

if(variable)
Means 'variable' is greater than 0, or true.

You have everything in reverse...

Re: OnPlayerEnterVehicle - Alpay0098 - 19.04.2015

Quote:
Originally Posted by Threshold
View Post
What are you talking about Cruse? The exclamation mark represents a false or negative value.

if(!variable)
Means 'variable' is either 0 or less, or is false.

if(variable)
Means 'variable' is greater than 0, or true.

You have everything in reverse...
I don't know Threshold but can you check IsACop? Returns won't change !'s?

Re: OnPlayerEnterVehicle - Threshold - 19.04.2015

Your code seems correct. Do you get the "you are not a member of..." message?

If you do, then OnPlayerEnterVehicle and ClearAnimations is not a good combination for players with reasonable lag. I'd try alternative methods such as OnPlayerStateChange and SetVehicleParams to lock vehicle doors.

EDIT: oh and change 'else if(IsCopCar' to just 'if(IsCopCar'