SA-MP Forums Archive
/(w)hisper crashes the server lol wtf - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: /(w)hisper crashes the server lol wtf (/showthread.php?tid=568694)


/(w)hisper crashes the server lol wtf - Ritzy2K - 24.03.2015

this command compiles perfectly...but when someone uses it ingame it crashes the server

pawn Код:
COMMAND:w(playerid, params[])
{
    return cmd_whisper(playerid, params);
}
COMMAND:whisper(playerid, params[])
{
    if (PlayerInfo[playerid][pSpawn] == 1){

        new COLOR = GetPlayerColor(playerid);

        new idx,string[512],length = strlen(params);
        while ((idx < length) && (params[idx] <= ' '))
        {
            idx++;
        }
        new offset = idx;
        new result[512];
        while ((idx < length) && ((idx - offset) < (sizeof(result) - 1)))
        {
            result[idx - offset] = params[idx];
            idx++;
        }
        result[idx - offset] = EOS;

        if (PlayerInfo[playerid][pMute] == 1)
        {
            SCM(playerid,COLOR_ERROR,"#Error: You Muted.");
            return 1;
        }

        if (!strlen(result))
        {
            SendClientMessage(playerid, COLOR_ERROR, "USAGE: /whisper (message).");
            return 1;
        }

        format(string, sizeof(string), "(WHISPER) %s (%d): %s",PlayerInfo[playerid][pName],playerid,result);
        SendClientMessage(playerid,COLOR, string);
        for (new i = 0; i < GetMaxPlayers(); i++)
        {

            i = GetClosestPlayer(playerid);
            if (IsPlayerConnected(i))
            {
                if (i != playerid)
                {
                    if (GetDistanceBetweenPlayers(playerid, i) < 10)
                    {
                        SendClientMessage(i,COLOR, string);
                    }
                }
            }
        }

    }else{
        SendClientMessage(playerid, COLOR_ERROR, "You Cannot Use This Command When You're Dead.");
    }

    return 1;
}


Re: /(w)hisper crashes the server lol wtf - ATGOggy - 24.03.2015

Try this:
PHP код:
COMMAND:w(playerid, params[])
{
    return cmd_whisper(playerid, params);
}
COMMAND:whisper(playerid, params[])
{
    if (PlayerInfo[playerid][pSpawn] == 1){

        new idx,string[144],length = strlen(params);
        while ((idx < length) && (params[idx] <= ' '))
        {
            idx++;
        }
        new offset = idx;
        new result[144];
        while ((idx < length) && ((idx - offset) < (sizeof(result) - 1)))
        {
            result[idx - offset] = params[idx];
            idx++;
        }
        result[idx - offset] = EOS;

        if (PlayerInfo[playerid][pMute] == 1)
        {
            SCM(playerid,COLOR_ERROR,"#Error: You Muted.");
            return 1;
        }

        if (!strlen(result))
        {
            SendClientMessage(playerid, COLOR_ERROR, "USAGE: /whisper (message).");
            return 1;
        }

        format(string, sizeof(string), "(WHISPER) %s (%d): %s",PlayerInfo[playerid][pName],playerid,result);
        SendClientMessage(playerid,GetPlayerColor(playerid), string);
        for (new i = 0; i < GetMaxPlayers(); i++)
        {

            i = GetClosestPlayer(playerid);
            if (IsPlayerConnected(i))
            {
                if (i != playerid)
                {
                    if (GetDistanceBetweenPlayers(playerid, i) < 10)
                    {
                        SendClientMessage(i,GetPlayerColor(playerid), string);
                    }
                }
            }
        }

    }else{
        SendClientMessage(playerid, COLOR_ERROR, "You Cannot Use This Command When You're Dead.");
    }

    return 1;
} 
Post the log of crashdetect.dll

Re: /(w)hisper crashes the server lol wtf - KayJ - 24.03.2015

COMMAND:w(playerid, params[]) return cmd_whisper(playerid, params);
Try this

Re: /(w)hisper crashes the server lol wtf - Sew_Sumi - 24.03.2015

Quote:
Originally Posted by StuartIndia
Посмотреть сообщение
COMMAND:w(playerid, params[]) return cmd_whisper(playerid, params);
Try this
If you looked at his code, it's the same... It's not that.

Re: /(w)hisper crashes the server lol wtf - BroZeus - 24.03.2015

What exactly are you trying to do with these lines
Код:
new idx,string[512],length = strlen(params);
		while ((idx < length) && (params[idx] <= ' '))
		{
			idx++;
		}
		new offset = idx;
		new result[512];
		while ((idx < length) && ((idx - offset) < (sizeof(result) - 1)))
		{
			result[idx - offset] = params[idx];
			idx++;
		}
		result[idx - offset] = EOS;
And also this loop will send the nearest player many messages..
Код:
 for (new i = 0; i < GetMaxPlayers(); i++)
        {

            i = GetClosestPlayer(playerid);
            if (IsPlayerConnected(i))
            {
                if (i != playerid)
                {
                    if (GetDistanceBetweenPlayers(playerid, i) < 10)
                    {
                        SendClientMessage(i,GetPlayerColor(playerid), string);
                    }
                }
            }
        }
If u are trying to send message to all players within range of 10 to playerid then use this
Код:
 for (new i = 0; i < GetMaxPlayers(); i++)
        {
            if (IsPlayerConnected(i))
            {
                if (i != playerid)
                {
                    if (GetDistanceBetweenPlayers(playerid, i) < 10)
                    {
                        SendClientMessage(i,GetPlayerColor(playerid), string);
                    }
                }
            }
        }


Re: /(w)hisper crashes the server lol wtf - Sew_Sumi - 24.03.2015

^^ This fella is on to something...

Re: /(w)hisper crashes the server lol wtf - SickAttack - 24.03.2015

Let me make your life easier:

Download this (check out the features as well and if you like it): https://sampforum.blast.hk/showthread.php?tid=520734

And then you could do this:
pawn Код:
CMD:whisper(playerid, params[])
{
    new string[256], message[128];
    if(sscanf(params, "s[128]", message)) return SendMessage(playerid, 0xFFFF00FF, "Usage: /whisper (message).");
    format(string, sizeof(string), "[WHISPER]: (%d) %s: %s.", playerid, PlayerName(playerid), message);
    SendWhisperMessage(10.0, playerid, 0x00FFFFFF, string);
    return 1;
}

CMD:w(playerid, params[]) return cmd_whisper(playerid, params);

stock PlayerName(playerid)
{
    new pname[MAX_PLAYER_NAME];
    GetPlayerName(playerid, pname, sizeof(pname));
    return pname;
}